osu-lazer

Fix incorrect behaviour

Dan Balasescu · 2024-12-18 23:19:14 +09:00

159f6025b8

Merge branch 'master' into ios-osu-is-not-document-app

Dan Balasescu · 2024-12-18 21:39:21 +09:00

546f0044bb

Fix free mod button overriding enabled state

Dan Balasescu · 2024-12-18 20:45:19 +09:00

5a2cae89ff

Merge pull request #31156 from frenzibyte/mobile-delayed-resume-overlay

Use time-based resume overlay when playing osu! on touchscreen

Dan Balasescu · 2024-12-18 15:25:10 +09:00

d54238240a

Fix null inspections on GameplayChatDisplay

Dean Herbert · 2024-12-17 19:10:09 +09:00

47d81e7dee

Fix iOS app configuration missing certain specifications

Salman Alshamrani · 2024-12-16 12:22:28 -05:00

22e74cc0ee

Disallow opening settings menu when external edit ovelay is open

Also disallows using the random skin keybind when the external edit
overlay is open. SkinEditor should already be disabling it, but I
figured we might as well add this in for redundancy

smallketchup82 · 2024-12-16 11:33:51 -05:00

7a5e613cf6

Use time-based resume overlay when playing osu! on touchscreen

Salman Alshamrani · 2024-12-16 08:24:22 -05:00

4bf90a5571

Roll our own iOS application delegates

Salman Alshamrani · 2024-12-16 06:51:21 -05:00

c46e81d890

Hide !mp commands from tournament streaming chat

Dean Herbert · 2024-12-16 17:39:27 +09:00

09fc30e377

Add test coverage

Bartłomiej Dach · 2024-12-16 16:03:26 +09:00

68a5618e81

Change beat snap divisior adjust defaults to be Ctrl+Scroll instead of Ctrl+Shift+Scroll

Matches stable.

- [ ] Depends on https://github.com/ppy/osu/pull/31146, else this will
adjust the global volume.

Dean Herbert · 2024-12-16 15:22:30 +09:00

d97ea78136

Move "global" scroll-adjusts-volume to a per-screen component-based implementation

Dean Herbert · 2024-12-16 15:21:07 +09:00

bdd417c1a1

Merge pull request #31084 from NicholasChin28/mania-profile-overlay-tooltip

Add missing mania tooltip overlay for 4k and 7k

Bartłomiej Dach · 2024-12-16 14:22:41 +09:00

d72a0b04b8

Skip the pause cooldown when in intro / break time

Had a quick look at adding test coverage in `TestScenePause` but the
setup to get into either of these states seems a bit annoying..

Dean Herbert · 2024-12-16 14:14:30 +09:00

85ada3275b

Merge pull request #31139 from peppy/settings-sensitivity

Expose high precision mouse toggle when searching for "sensitivity" and other keywords

Bartłomiej Dach · 2024-12-16 13:40:32 +09:00

8a2f161619

Merge pull request #31110 from peppy/timing-current-point-indicator

Change the way "current" points are hinted on timing screen

Bartłomiej Dach · 2024-12-16 13:27:06 +09:00

9652c5a7ca

Revert "Fix text anchor for mania tooltip"

This reverts commit c0b6e784a5.

The change affects editor and other stuff and I'm not sure it's correct.
It's not like client needs to match the appearance really. It already
doesn't in many places.

Bartłomiej Dach · 2024-12-16 13:18:47 +09:00

ecb7a809f2

Split actual methods & fix completely broken localisation

Localisable strings cannot be plainly interpolated or joined. That is a
lossy operation that loses data.

Bartłomiej Dach · 2024-12-16 13:16:52 +09:00

cfdb959cf6

Clean up model

- Properly annotate things as nullable
- Remove weird passthrough property (more on that later)

Bartłomiej Dach · 2024-12-16 13:14:21 +09:00

8d1d026f56

Expose high precision mouse toggle when searching for "sensitivity" and other keywords

Dean Herbert · 2024-12-16 13:12:21 +09:00

a8948628e6

Merge pull request #31109 from peppy/fix-editor-timing-undo-redo

Fix adjusting control point offset after undo/redo causing catastrophic failure

Bartłomiej Dach · 2024-12-16 12:40:22 +09:00

573d709fae

Merge branch 'master' into timing-current-point-indicator

Bartłomiej Dach · 2024-12-16 12:22:14 +09:00

98e8d0b497

Fix code quality

Bartłomiej Dach · 2024-12-16 12:22:06 +09:00

1058abb4ab

Implement ability to mark beatmap as played

Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1.

Would you believe it that this button that has been there for literal
years never did anything?

Implemented at a per-beatmap level. Also additionally added to context
menu (at @peppy's suggestion), and also copy reworded from "Delete from
unplayed" to "Mark as played" because double negation hurt my tiny
brain.

Bartłomiej Dach · 2024-12-16 10:49:19 +09:00

a6e00d6eac

Fix code quality issues

Nicholas Chin · 2024-12-15 13:53:33 +08:00

e2edd9e0d5

Use Count comparison instead of Any

Nicholas Chin · 2024-12-14 08:29:32 +08:00

153e6c0c22

Merge pull request #31108 from peppy/quick-retry-for-replays

Allow using "quick retry" shortcut in more cases from results screen

Dean Herbert · 2024-12-13 08:18:59 -08:00

c93b6dba2b

Fix text anchor for mania tooltip

Nicholas Chin · 2024-12-13 21:58:23 +08:00

c0b6e784a5

Reword comment to hopefully be more understandable

Dean Herbert · 2024-12-13 20:02:17 +09:00

9025103b8b

Change the way "current" points are hinted on timing screen

I actually thought things were bugged with the previous display method,
since the hinting was very similar to the hover colour/state.

I've adjusted this to hopefully give users a better idea of what this is
intending to show them.

Dean Herbert · 2024-12-13 19:45:18 +09:00

da840e3fac

Fix adjusting control point offset after undo/redo causing catastrophic failure

Closes https://github.com/ppy/osu/issues/31098.

Low effort fix because it was already half broken. The test was testing
in isolation but in actual editor usage it wasn't working as expected.

Dean Herbert · 2024-12-13 19:33:51 +09:00

64555debc2

Merge pull request #31106 from peppy/player-settings-fix-overlap-skins

Fix player settings overlay cog overlapping skin elements

Dan Balasescu · 2024-12-13 19:30:39 +09:00

35c70ceb18

Add note about player settings overlay button

Dean Herbert · 2024-12-13 18:58:20 +09:00

4b0cdd761d

Merge pull request #31101 from Joehuu/recommended-diff-beatmap-listing

Add recommended difficulty numerical value near filter in beatmap listing

Dan Balasescu · 2024-12-13 18:57:16 +09:00

f84c67babd

Merge pull request #31107 from bdach/flaky-editor-test

Attempt to fix flaky editor beatmap creation test

Dan Balasescu · 2024-12-13 18:53:43 +09:00

e2af8820de

Merge branch 'master' into player-settings-fix-overlap-skins

Dan Balasescu · 2024-12-13 18:36:12 +09:00

22a5ed8a07

Merge pull request #31105 from peppy/player-settings-no-show-skin-editor

Fix player settings overlay appearing while in skin editor

Dan Balasescu · 2024-12-13 18:34:05 +09:00

c29c3d48bf

Also allow using "quick retry" for other replays

Dean Herbert · 2024-12-13 18:14:45 +09:00

d00bc4bdd1

Fix "quick retry" hotkey not working for autoplay

Dean Herbert · 2024-12-13 18:08:29 +09:00

0e0d96829f

Fix test

Dan Balasescu · 2024-12-13 17:41:55 +09:00

edbaaa9468

Fix flaky editor beatmap creation test

As seen in
https://github.com/ppy/osu/actions/runs/12289146465/job/34294167417#step:5:1588
or
https://github.com/ppy/osu/actions/runs/12310133160/job/34358241666#step:5:53.

Exception messages hint pretty strongly at this being a threading issue
and there does seem to be a rather frivolous lack of waiting for
`CreateNewDifficulty()` to do its thing, so I'm thinking maybe this will
help.

Bartłomiej Dach · 2024-12-13 17:35:41 +09:00

fdc41ace7e

Fix player settings overlay cog overlapping skin elements

This brings it down to be in line with the flowing elements that usually
do their best to not get in the way.

Decided against putting it in the `HUDOverlay` flow for simplicity. It
will work fine until it doesn't.

Dean Herbert · 2024-12-13 17:28:15 +09:00

a796af9511

Fix player settings overlay appearing while in skin editor

Dean Herbert · 2024-12-13 17:18:34 +09:00

1e809c7f16

Add failing test showing player settings appearing in skin editor

Dean Herbert · 2024-12-13 17:18:34 +09:00

b470e30cc0

Merge pull request #31073 from bdach/filter-playing-rooms

Add ability to filter out currently playing rooms

Dan Balasescu · 2024-12-13 17:03:30 +09:00

2930db5d6e

Unbind event on disposal

Dan Balasescu · 2024-12-13 16:39:16 +09:00

7bb1a5118e

Merge branch 'master' into recommended-diff-beatmap-listing

Dan Balasescu · 2024-12-13 16:38:07 +09:00

62a1a5883a

Fix incorrect lastPattern value

In particular, mania-specific beatmaps that normally go via the
"passthrough" generator should not adjust the stored pattern value.

The "spinner" generator, which was previously intended to be used for
non-mania-specific beatmaps, is now valid even for mania-specific
beatmaps, and uses this value.

In other words, another way of writing this would be:
```csharp
if (conversion is SpinnerPatternGenerator || conversion is
PassThroughPatternGenerator) ? lastPattern : newPattern;
```

Dan Balasescu · 2024-12-13 16:08:12 +09:00

d597232c2a

Add another failing test

Dan Balasescu · 2024-12-13 15:53:27 +09:00

12e5999700

75266 Commits