48098 Commits

• Merge pull request #29533 from bdach/fix-sample-bank-stuff-again

  Fix incorrect bank set / sample addition logic

  Dan Balasescu · 2024-08-29 21:36:26 +09:00
  fec8fa46fa
• Rework played filter to a boolean value
  Dan Balasescu · 2024-08-29 20:59:48 +09:00
  fde790c014
• Change accuracy circle to show badges based on score rank
  Dan Balasescu · 2024-08-29 20:22:54 +09:00
  d97a94aadd
• Fix realm changes being applied before detach finishes
  Dean Herbert · 2024-08-29 18:42:43 +09:00
  d1d2591b67
• Fix some tests not always waiting long enough for beatmap loading

  These used to work because there was a huge blocking load operation,
  which is now more asynchronous.
  
  Note that the change made in `SongSelect` is not required, but defensive
  (feels it should have been doing this the whole time).

  Dean Herbert · 2024-08-29 18:42:43 +09:00
  def1abaeca
• Hide pinned comment replies initially to match web
  Joseph Madamba · 2024-08-28 23:05:15 -07:00
  ef443b0b5d
• Remove loadedTestBeatmaps flag
  Dean Herbert · 2024-08-28 23:28:44 +09:00
  1776d38809
• Tidy up test beatmap loading
  Dean Herbert · 2024-08-28 23:28:44 +09:00
  e04b5bb3f2
• Fix multiple test failures
  Dean Herbert · 2024-08-28 23:28:43 +09:00
  9123d2cb7f
• Merge pull request #29576 from peppy/allow-seek-in-more-places

  Allow seeking via music controller overlay on more screens

  Bartłomiej Dach · 2024-08-28 12:23:09 +02:00
  d49cd717d6
• Always debounce external Filter requests (except for tests)

  The only exception to the rule here was "when screen isn't active apply
  without debounce" but I'm not sure we want this. It would cause a
  stutter on returning to song select and I'm not even sure this is a
  common scenario.
  
  I'd rather remove it and see if someone finds an actual case where this
  is an issue.

  Dean Herbert · 2024-08-28 19:13:50 +09:00
  dd4a1104e4
• Allow running initial filter criteria asynchronously

  This reverts a portion of https://github.com/ppy/osu/pull/9539.
  
  The rearrangement in `SongSelect` is required to get the initial filter
  into `BeatmapCarousel` (and avoid the `FilterChanged` event firing,
  causing a delayed/scheduled filter application).

  Dean Herbert · 2024-08-28 19:13:50 +09:00
  336abadbd1
• Remove song select preloading

  Really unnecessary now.

  Dean Herbert · 2024-08-28 19:13:49 +09:00
  5ed0c6e91a
• Detach beatmap sets asynchronously
  Dean Herbert · 2024-08-28 19:13:49 +09:00
  c2c1dccf2d
• Fix enumeration over modified collection
  Dean Herbert · 2024-08-28 19:13:49 +09:00
  b1f653899c
• Fix null reference in change handling code
  Dean Herbert · 2024-08-28 19:13:49 +09:00
  81b36d897d
• Fix incorrect cancellation / disposal handling of DetachedBeatmapStore
  Dean Herbert · 2024-08-28 17:21:19 +09:00
  081c9eb21b
• Changed ModCustomisationPanelState names
  Fabep · 2024-08-28 10:09:47 +02:00
  6adaf6a41f
• change sample seek keybind to ctrl shift
  OliBomby · 2024-08-28 09:57:13 +02:00
  cadbb0f27a
• Removed on click event for expanding the Mod Customisation Header.
  Fabep · 2024-08-28 09:51:17 +02:00
  be0e2efda2
• Use bindable list implementation
  Dean Herbert · 2024-08-28 16:03:37 +09:00
  4d42274771
• Add basic detached beatmap store
  Dean Herbert · 2024-08-28 16:03:37 +09:00
  466ed5de78
• Change middle text to only animate initially
  Dean Herbert · 2024-08-28 15:57:42 +09:00
  eb70a1b72d
• Revert "Add slight parallax to centre content"

  This reverts commit 90d06d4496.

  Dean Herbert · 2024-08-28 15:32:59 +09:00
  47a52d10eb
• Automatic seek to sample point on right-click
  OliBomby · 2024-08-27 19:40:33 +02:00
  b5b4f915a9
• change default seek hotkeys
  OliBomby · 2024-08-27 19:40:18 +02:00
  1117fd56a1
• Add float comparison leniency just in case
  OliBomby · 2024-08-27 19:04:16 +02:00
  daad476593
• fix difference in sample time calculation
  OliBomby · 2024-08-27 19:02:40 +02:00
  71044a0766
• Merge branch 'master' into break-overlay-animation
  Bartłomiej Dach · 2024-08-27 11:17:56 +02:00
  a3b0ff4808
• Merge pull request #29615 from peppy/break-overlay-improvements

  Add shadow around break overlay middle content to make sure it remains visible

  Bartłomiej Dach · 2024-08-27 11:16:08 +02:00
  321e509f11
• Add slight parallax to centre content
  Dean Herbert · 2024-08-27 16:37:27 +09:00
  90d06d4496
• Merge pull request #29560 from peppy/fix-daily-challenge-intro-mod-display

  Fix mod icons potentially showing incorrectly at daily challenge intro

  Bartłomiej Dach · 2024-08-27 09:37:11 +02:00
  8d7053d367
• Add beat-synced animation to break overlay

  I've been meaning to make the progress bar synchronise with the beat
  rather than a continuous countdown, just to give the overlay a bit more
  of a rhythmic feel.
  
  Not completely happy with how this feels but I think it's a start?
  
  I had to refactor how the break overlay works in the process. It no
  longer creates transforms for all breaks ahead-of-time, which could be
  argued as a better way of doing things. It's more dynamically able to
  handle breaks now (maybe useful for the future, who knows).

  Dean Herbert · 2024-08-27 16:34:37 +09:00
  6f1664f0a6
• Apply NRT to BreakOverlay
  Dean Herbert · 2024-08-27 15:01:51 +09:00
  98faa07590
• Add shadow around break overlay middle content to make sure it remains visible
  Dean Herbert · 2024-08-27 15:01:50 +09:00
  797b020747
• Move break overlay (and cursor) further forward in depth

  I didn't really want to move the cursor in front of the HUD, but we face
  a bit of an impossible scenario otherwise (it should definitely be in
  front of the break overlay for visibility).
  
  So I'll deal with it for now.

  Dean Herbert · 2024-08-27 14:52:11 +09:00
  abdbe510b8
• Assume we can always fetch the ruleset
  Dean Herbert · 2024-08-26 15:38:58 +09:00
  84bceca778
• Increase mod icon acronym font weight
  clayton · 2024-08-25 20:42:57 -07:00
  70d08b9e97
• Use more contrasting color for mod icon foreground
  clayton · 2024-08-25 20:42:34 -07:00
  2bb72762ad
• Add DailyChallengeButton for intro played flag reset logic
  Salman Ahmed · 2024-08-24 22:19:17 +09:00
  b54487031a
• Fix Daily Challenge play count using a different colour than osu-web
  Jonas Brandstötter · 2024-08-24 11:21:28 +02:00
  89a4025c01
• Fix deserialise failing with some old skins
  Dean Herbert · 2024-08-23 20:44:45 +09:00
  885d832e98
• Add a bit of logging around medal awarding

  Might help with https://github.com/ppy/osu/issues/29119.

  Dean Herbert · 2024-08-23 19:49:24 +09:00
  1e39af8ac5
• Remove conditional inhibiting seek when beatmap change is not allowed

  In testing I can't find a reason for this to exist. Blaming back shows
  that it existed before we had `AllowTrackControl` and was likely being
  used as a stop-gap measure to achieve the same thing. It's existed since
  over 6 years ago.
  
  Let's give removing it a try to fix some usability concerns?
  
  Closes https://github.com/ppy/osu/issues/29563.

  Dean Herbert · 2024-08-23 18:21:31 +09:00
  2a479a84dc
• Merge pull request #29564 from peppy/skinnable-components-what-2

  Remove requirement of `base` calls to ensure user skin container layouts are retrieved

  Dean Herbert · 2024-08-23 17:52:46 +09:00
  60271fb0f7
• Component -> Lookup
  Dean Herbert · 2024-08-23 14:48:50 +09:00
  48cfd77ee8
• Merge remote-tracking branch 'upstream/master' into scroll-speed-std
  OliBomby · 2024-08-22 20:17:14 +02:00
  2de5ecceb8
• Fix scroll speed visualisation missing on start kiai effect points

  They were being drawn far offscreen because the width of the kiai multiplied with the X coordinate of the scroll speed vis.

  OliBomby · 2024-08-22 20:17:09 +02:00
  ad8e7f1897
• Add property EditorShowScrollSpeed to Ruleset
  OliBomby · 2024-08-22 19:53:34 +02:00
  998b5fdc12
• move public member to top of file
  OliBomby · 2024-08-22 19:18:38 +02:00
  adbdb39e9f