48098 Commits

• Fix one more unnecessary enumerator allocation
  Dean Herbert · 2024-09-04 15:22:31 +09:00
  97a51af5a0
• Fix per-frame allocations in BeatmapCarousel
  Dean Herbert · 2024-09-04 14:31:59 +09:00
  421f245c31
• Fix rewind causing weirdness with progress bar animation
  Dean Herbert · 2024-09-03 18:50:57 +09:00
  6c89c4eed6
• persist analysis settings
  Sheppsu · 2024-09-03 04:49:50 -04:00
  a549cdd5b9
• rework code logic to make more sense

  analysis container creates settings and the settings items are created more nicely
  also removed use of localized strings because that can be done separately

  Sheppsu · 2024-09-03 00:59:42 -04:00
  a2b15fcdee
• Woopsie! I accidentally added one too many semi-colons, so I moved it here into the commit instead ;
  Fabep · 2024-09-02 19:17:07 +02:00
  582ffcfc97
• Mod customisation header's color is now based on the state of the panel rather than the hover of the container.
  Fabep · 2024-09-02 19:14:08 +02:00
  e3457d8501
• Merge branch 'master' into Fabep/master
  Bartłomiej Dach · 2024-09-02 14:35:44 +02:00
  d99b2312cd
• Handle changes to the automatic download setting immediately
  Dean Herbert · 2024-09-02 19:20:05 +09:00
  7b13943377
• Fix incorrect handling of ordered playlist items
  Dean Herbert · 2024-09-02 19:18:43 +09:00
  872d14ed88
• Merge pull request #29446 from OliBomby/last-anchor

  Fix path control points losing curve type on save/reload or undo

  Dan Balasescu · 2024-09-02 18:40:19 +09:00
  5d09aaae27
• Fix mod customisation header being non-functional on mobile

  As expected the previous touch handling would prevent the header from
  working entirely when click handling was removed from the header.

  Bartłomiej Dach · 2024-09-02 11:33:43 +02:00
  5211e606b5
• Fix weirdness around spurious adjustments firing due to overloaded bindable
  Bartłomiej Dach · 2024-09-02 10:49:31 +02:00
  57f1259a33
• Make application of offset/BPM object adjustments more sane
  Bartłomiej Dach · 2024-09-02 10:40:58 +02:00
  3eaffbb70a
• Retouch & document helper methods
  Bartłomiej Dach · 2024-09-02 10:27:43 +02:00
  e61fd080c1
• Move helper class out to separate file
  Bartłomiej Dach · 2024-09-02 09:52:00 +02:00
  ca2dc702e6
• Apply NRT to MultiplayerSpectateButton
  Dean Herbert · 2024-09-02 16:37:38 +09:00
  6227e4f848
• Add automatic downloading support when spectating a multiplayer room
  Dean Herbert · 2024-09-02 16:37:38 +09:00
  38a62eed44
• Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm
  Bartłomiej Dach · 2024-09-02 09:21:42 +02:00
  d5ef32e46b
• Merge branch 'master' into replay-analysis-settings
  Sheppsu · 2024-09-01 19:32:25 -04:00
  1ed94e598a
• Merge pull request #29542 from frenzibyte/show-daily-challenge-intro-once-per-session

  Show daily challenge intro screen once per session

  Dean Herbert · 2024-09-01 21:27:16 +09:00
  e79604cc13
• Update framework
  Dean Herbert · 2024-09-01 19:10:08 +09:00
  f7da7193ff
• Use FastCircle for kiai visualisation
  Andrei Zavatski · 2024-08-31 17:32:24 +03:00
  837fa1b8dc
• Merge branch 'master' into fast-circle
  Andrei Zavatski · 2024-08-31 17:31:30 +03:00
  501ea68a21
• Merge branch 'master' into velopack
  Dan Balasescu · 2024-08-31 15:44:21 +09:00
  d5b52152f4
• Simplify scroll speed point display code now that it only serves one purpose
  Dean Herbert · 2024-08-31 13:14:56 +09:00
  6b8b49e4f1
• Rework kiai handling in summary timeline
  Andrei Zavatski · 2024-08-31 01:59:40 +03:00
  225418dbb3
• Use FastCircle in demanding places in the editor
  Andrei Zavatski · 2024-08-30 17:45:26 +03:00
  f5a2b5ea03
• Merge pull request #29656 from peppy/provide-api-earlier

  Provide API context earlier to api requests in order to fix missing schedules

  Dean Herbert · 2024-08-30 23:15:28 +09:00
  a09c6e2a25
• Merge pull request #29639 from peppy/detached-beatmap-cache

  Improve song select load and reload with large beatmap databases

  Bartłomiej Dach · 2024-08-30 15:00:20 +02:00
  4811481483
• Fix NRT inspections
  Bartłomiej Dach · 2024-08-30 13:41:34 +02:00
  8ffd4aa82c
• Fix beatmap not being detached on hide/unhide

  The explicit detach call was removed from `updateBeatmapSet`, causing
  this to occur. We could optionally add it back (it will be a noop in all
  cases though).

  Dean Herbert · 2024-08-30 18:50:08 +09:00
  7b6e62283f
• Add very basic error handling for failed beatmap detach
  Dean Herbert · 2024-08-30 18:50:03 +09:00
  de208fd5c3
• Add disposal of ManualResetEventSlim
  Dean Herbert · 2024-08-30 18:50:02 +09:00
  2033a5e157
• Mark BeatmapSets as internal
  Dean Herbert · 2024-08-30 18:44:04 +09:00
  1b9942cb30
• Remove TODO
  Dean Herbert · 2024-08-30 18:37:27 +09:00
  291dd5b101
• Apply NRT to APIRequest
  Dean Herbert · 2024-08-30 18:35:31 +09:00
  2d745fb67e
• Fix weird test critical failure if exception happens too early in execution

  Noticed in passing.
  
  ```
  Exit code is 134 (Unhandled exception. System.NullReferenceException:
  Object reference not set to an instance of an object.
     at osu.Game.OsuGameBase.onExceptionThrown(Exception ex) in
  /Users/dean/Projects/osu/osu.Game/OsuGameBase.cs:line 695
     at osu.Framework.Platform.GameHost.abortExecutionFromException(Object
  sender, Exception exception, Boolean isTerminating)
     at osu.Framework.Platform.GameHost.unobservedExceptionHandler(Object
  sender, UnobservedTaskExceptionEventArgs args)
     at System.Threading.Tasks.TaskExceptionHolder.Finalize())
  ```

  Dean Herbert · 2024-08-30 18:35:31 +09:00
  dd7133657d
• Use IAPIProvider interface and correctly support scheduling from DummyAPIAccess
  Dean Herbert · 2024-08-30 18:35:31 +09:00
  07611bd8f5
• Provide API context earlier to api requests in order to fix missing schedules

  Closes https://github.com/ppy/osu/issues/29546.

  Dean Herbert · 2024-08-30 18:10:36 +09:00
  5836f497ac
• Merge branch 'master' into master
  Fabian Bech Persson · 2024-08-30 11:06:54 +02:00
  363fc0d5da
• Merge pull request #29653 from peppy/fix-multiplayer-event-leak

  Fix event leak in `Multiplayer` implementation

  Dan Balasescu · 2024-08-30 16:58:27 +09:00
  ae0931cfc3
• Merge pull request #28737 from OliBomby/doubleclick

  Add more ways to seek to sample points

  Dean Herbert · 2024-08-30 16:22:50 +09:00
  a71bc3a24a
• Fix event leak in Multiplayer implementation

  Very likely closes #29088. It's the only thing I could find odd in the
  memory dump.

  Dean Herbert · 2024-08-30 16:14:19 +09:00
  3bc42db3a6
• Merge pull request #29440 from OliBomby/spacebar-resume

  Allow play/pause with spacebar while placing hitobjects

  Dean Herbert · 2024-08-30 12:58:41 +09:00
  60c1e0fa72
• Merge remote-tracking branch 'upstream/master' into doubleclick
  OliBomby · 2024-08-29 19:34:18 +02:00
  ba0c4df2a9
• dont seek on right-click, only on keyboard request
  OliBomby · 2024-08-29 19:34:14 +02:00
  8fe7ab131c
• Merge branch 'master' into scroll-speed-std
  Dan Balasescu · 2024-08-30 00:41:05 +09:00
  4e8fb0dcab
• Merge pull request #29644 from smoogipoo/unplayed-filter-query-2

  Adjust `played` song select filter to accept a boolean value

  Dean Herbert · 2024-08-29 23:52:37 +09:00
  dd675fef45
• Merge branch 'master' into detached-beatmap-cache
  Dean Herbert · 2024-08-29 22:49:11 +09:00
  c013974790