48098 Commits

• Rename classes for better discoverability / grouping
  Dean Herbert · 2025-02-12 19:34:42 +09:00
  554884710c
• Mark Action as init only
  Dean Herbert · 2025-02-12 19:24:30 +09:00
  151101be70
• Remove unnecessary V2 suffixes
  Dean Herbert · 2025-02-12 19:22:57 +09:00
  3a0464299a
• Update height specification for playlist screen too
  Dean Herbert · 2025-02-12 18:45:00 +09:00
  c049ae6937
• Merge branch 'master' into freestyle-mods
  Dean Herbert · 2025-02-12 18:32:01 +09:00
  bc94ffe21e
• Flash footer freemod/freestyle buttons when active
  Dean Herbert · 2025-02-12 18:30:34 +09:00
  218151bb3c
• Change free mods button to show "all" when freestyle is enabled
  Dean Herbert · 2025-02-12 18:27:10 +09:00
  9c3e9e7c55
• Adjust some paddings and text

  Mostly trying to give more space to the queue as we add more vertical
  elements to the middle area of multiplayer / playerlists. This whole UI
  will likely change – this is just a stop-gap fix.

  Dean Herbert · 2025-02-12 17:43:49 +09:00
  9aef95c381
• Fix layout of user setting areas when aspect ratio is vertically tall
  Dean Herbert · 2025-02-12 17:31:55 +09:00
  b92e9f515b
• Add comment warning about enum entry order in GlobalAction
  Marvin Schürz · 2025-02-11 18:04:23 +01:00
  a8f07ae7b1
• Merge pull request #22932 from peppy/collection-counts

  Show count of beatmaps in collections in manage dialog

  Bartłomiej Dach · 2025-02-11 15:43:22 +01:00
  46e8187d48
• Merge branch 'master' into room-management-lio
  Dean Herbert · 2025-02-11 22:36:01 +09:00
  d3f6f0953a
• Merge pull request #31846 from bdach/fix-missing-rank-on-results

  Fix score position not being displayed in solo results screen

  Dan Balasescu · 2025-02-11 21:55:35 +09:00
  693ef8f538
• Merge branch 'master' into room-management-lio
  Dan Balasescu · 2025-02-11 21:19:32 +09:00
  38cd4fa56a
• Fix potential bad realm access to collection name
  Dean Herbert · 2025-02-11 20:05:48 +09:00
  b9c4e23595
• Use more neutral terminology to avoid contentious 'beatmap' term
  Bartłomiej Dach · 2025-02-11 09:17:11 +01:00
  d8b3c28c2e
• Add basic brighten animation instead
  Dean Herbert · 2025-02-11 17:13:34 +09:00
  b9ed217308
• Remove completely unnecessary subscriptions per collection
  Bartłomiej Dach · 2025-02-11 09:13:08 +01:00
  884fa20b28
• Disable scale animation when holding editor "test" button
  Dean Herbert · 2025-02-11 17:11:20 +09:00
  1fa8d53232
• Merge pull request #31848 from bdach/open-beatmap-in-browser-from-editor

  Add menu items to open beatmap info & discussion pages in browser from editor

  Dean Herbert · 2025-02-11 16:55:02 +09:00
  9bb108311f
• Merge branch 'master' into collection-counts
  Bartłomiej Dach · 2025-02-11 08:54:24 +01:00
  18965fe0a2
• Update xmldoc
  Bartłomiej Dach · 2025-02-11 16:14:47 +09:00
  7db0a6f817
• Reword copy to be less verbose
  Bartłomiej Dach · 2025-02-11 08:06:12 +01:00
  daf0130b23
• Fix inspection

  Interestingly, this is not a compiler error nor does R# warn about it.
  No problem, because this is just restoring the original code anyway.

  Dan Balasescu · 2025-02-11 14:23:51 +09:00
  e51c09ec3d
• Refactor RoomSubScreen update
  Dan Balasescu · 2025-02-11 12:43:54 +09:00
  748c2eb390
• Refactor with a bit more null safety

  In particular I don't like the non-null assert around
  `GetCurrentItem()`, because there's no reason why it _couldn't_ be
  `null`.
  Consider, for example, if these panels are used in matchmaking where
  there are no items initially present in the playlist.
  
  The ruleset nullability part is debatable, but I've chosen to restore
  the original code here.

  Dan Balasescu · 2025-02-11 12:20:09 +09:00
  78e5e0eddd
• Merge pull request #31844 from bdach/fix-mp-players-appearing-as-spectators

  Fix spectator list showing other users in multiplayer room even if they're not spectating

  Dean Herbert · 2025-02-10 21:49:06 +09:00
  8dc616738c
• Space out comment
  Dean Herbert · 2025-02-10 21:48:27 +09:00
  310700b4e7
• Add menu items to open beatmap info & discussion pages in browser from editor
  Bartłomiej Dach · 2025-02-10 12:47:38 +01:00
  38e2f793ca
• Fix score position not being displayed in solo results screen

  Closes https://github.com/ppy/osu/issues/31842.
  
  To be honest, I recall this working too, but I don't recall when it
  might have broken, nor do I want to go look for the point of breakage
  because it might be borderline impossible to find it now. So I'm just
  fixing as if it was just a straight omission.
  
  Opting for a client-side fix because server-side inclusion of the score
  position for an entire leaderboard has been previously rejected as too
  expensive:
  
  	https://github.com/ppy/osu-web/pull/11354#discussion_r1689217450

  Bartłomiej Dach · 2025-02-10 12:17:52 +01:00
  288851c606
• Fix spectator list showing other users in multiplayer room even if they're not spectating
  Bartłomiej Dach · 2025-02-10 11:17:17 +01:00
  ad642b8425
• Privatise a few members
  Bartłomiej Dach · 2025-02-10 10:41:10 +01:00
  3ba56e009e
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-10 18:07:07 +09:00
  afdcf40d7e
• Minor code refactors
  Dean Herbert · 2025-02-10 17:41:38 +09:00
  b8e33a28d2
• Remove unused using
  Bartłomiej Dach · 2025-02-10 09:09:43 +01:00
  45259b374a
• Allow performing beatmap reload after submission from song select
  Bartłomiej Dach · 2025-02-10 09:03:40 +01:00
  895493877c
• Fix tests failing if playlist was empty
  Layendan · 2025-02-09 23:27:28 -07:00
  5e9f195117
• Adjust animations and induce some short delays to make things more graceful
  Dean Herbert · 2025-02-10 15:23:25 +09:00
  eae1ea7e32
• Fix back button displaying before it should
  Dean Herbert · 2025-02-10 15:22:31 +09:00
  930aaecd7f
• Add delay before browser displays beatmap
  Dean Herbert · 2025-02-10 15:12:59 +09:00
  7853456c06
• Add percent progress display to editor footer
  Dean Herbert · 2025-02-10 14:51:48 +09:00
  274b422139
• Update button text to include downloaded beatmaps and collection status
  Layendan · 2025-02-09 18:45:13 -07:00
  f9bda0524a
• Changed the Currently Playing Text when no track is selected

  Changed the currently playing text for when the track isnt selected/loaded

  SebastianPeP · 2025-02-09 01:29:22 -03:00
  bcd4fcbeed
• Fix exiting being eternally blocked after successful beatmap submission
  Bartłomiej Dach · 2025-02-07 15:37:27 +01:00
  64f0d234d8
• Add staging submission service URL to development endpoint config
  Bartłomiej Dach · 2025-02-07 15:34:52 +01:00
  de0aabbfc5
• Merge branch 'master' into bss/the-actual-submission
  Bartłomiej Dach · 2025-02-07 15:30:37 +01:00
  1afd1f5000
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-02-07 21:47:56 +09:00
  b07d7e8177
• Assume room is setup correctly and remove duplicate maps before querying realm
  Layendan · 2025-02-07 04:04:29 -07:00
  d4c69f0c90
• Merge branch 'master' into carousel-v2-implement-designs
  Dean Herbert · 2025-02-07 19:37:06 +09:00
  d8f3dbf988
• Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735)

  * Calculate hit windows in performance calculator instead of databased difficulty attributes
  
  * Apply mods to beatmap difficulty in osu! performance calculator
  
  * Remove `GreatHitWindow` difficulty attribute for osu!mania
  
  * Remove use of approach rate and overall difficulty attributes for osu!
  
  * Remove use of hit window difficulty attributes in osu!taiko
  
  * Remove use of approach rate attribute in osu!catch
  
  * Remove unused attribute IDs
  
  * Code quality
  
  * Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

  James Wilson · 2025-02-07 19:21:12 +09:00
  9f90ebb2f7