30 Commits

• Fix context menu not working due to too much blocking
  Dean Herbert · 2025-08-04 17:52:27 +09:00
  3557207609
• Ensure scores are re-fetched with correct criteria on re-entering song select

  Closes https://github.com/ppy/osu/issues/34445.
  
  The primary issue is that song select is the only one that supports
  non-score sort mode, and therefore if any other component changes the
  sort mode in a way opaque to song select to score, then song select will
  lose the sort mode because it's using the global leaderboard manager's
  state which will contain scores sorted by total.
  
  Notably, the bug this is fixing requires specific circumstances. For
  instance, it is not enough to just *start gameplay* for the bug to
  manifest, because starting gameplay causes a working beatmap refetch:
  
  https://github.com/ppy/osu/blob/4b73afd1957a9161e2956fc4191c8114d9958372/osu.Game/Screens/SelectV2/SongSelect.cs#L456-L457
  
  which will trigger a *delayed schedule refetch* of the scores:
  
  https://github.com/ppy/osu/blob/d2d3d14f1572ff8fc68fd01ea43c2ef68b5882fa/osu.Game/Screens/SelectV2/BeatmapLeaderboardWedge.cs#L235-L253
  
  and because the refetch is thusly delayed, there's a very high chance it
  *will not run before the screen is resumed* because the wedge will not
  have its scheduler run until that point in time.
  
  This conundrum is also because there is no test coverage for this,
  because the above makes test coverage setup rather annoying.

  Bartłomiej Dach · 2025-07-31 10:09:07 +02:00
  d176ce7916
• Fix leaderboard SFX delegates not being cleared in some cases where scores are hidden
  Jamie Taylor · 2025-07-31 13:30:27 +09:00
  d2d3d14f15
• Adjust stereo shift effects for UI sounds to be less extreme
  Dean Herbert · 2025-07-30 19:35:26 +09:00
  0b11953b24
• Merge branch 'master' into local-score-sorting-v2
  Bartłomiej Dach · 2025-07-28 11:32:59 +02:00
  c620d58bc2
• Add SFX to scores appearing in the SSv2 Beatmap Leaderboard
  Jamie Taylor · 2025-07-26 00:16:01 +09:00
  055c2378ac
• Add fade transition in BeatmapLearderboardWedge
  jyc76 · 2025-07-07 11:51:26 +09:00
  ab6eda09a2
• Also fix leaderboard scores not eating mouse down

  Closes second portion of https://github.com/ppy/osu/issues/33748.

  Dean Herbert · 2025-07-01 19:47:33 +09:00
  5f48124a94
• Make sure you can't request non-local scores with a sort mode other than score.
  Dani211e · 2025-06-27 04:46:49 +02:00
  abfd4f6338
• RankingsSort -> LeaderboardSortMode
  Dani211e · 2025-06-26 19:03:49 +02:00
  c1a34d8c6a
• Add sorting dropdown

  Only use sorting when on local scope otherwise hide

  Dani211e · 2025-06-25 05:01:40 +02:00
  ad35dad46d
• Slightly increase delay before leaderboard scores are loaded
  Dean Herbert · 2025-06-10 13:06:30 +09:00
  0a694862e7
• SongSelectV2: Add back highlighting friend scores on the leaderboard
  Bartłomiej Dach · 2025-06-06 13:53:32 +02:00
  90084e27e5
• Debounce leaderboard load operations

  This avoids needless web requests / server load, but also improves the
  placeholder display. It used to update during ruleset changes three (or
  more) times since it had no debounce and was reacting to multiple
  changes. This is no longer the case.

  Dean Herbert · 2025-06-05 15:31:51 +09:00
  0c2fc5c74f
• SongSelectV2: Add padding to avoid overlap between mods button and personal best
  Dean Herbert · 2025-06-03 02:06:20 +09:00
  d2452ca25f
• Inflate leaderboard scores input area to avoid misclicks in gaps
  Dean Herbert · 2025-05-30 14:31:26 +09:00
  574b0eb686
• Add gradient fade when scrolling leaderboard
  Dean Herbert · 2025-05-30 14:29:49 +09:00
  6773755a5d
• Fix personal best being cut off weirdly
  Dean Herbert · 2025-05-29 20:12:00 +09:00
  1af39b6b5b
• Fix leaderboard wedge transition looking bad when user is scrolled down

  Closes https://github.com/ppy/osu/issues/33227.

  Dean Herbert · 2025-05-27 14:39:25 +09:00
  070b0c0e7f
• Remove unnecessary initial text content duplicate
  Dean Herbert · 2025-05-22 22:52:19 +09:00
  4d309ded2e
• Display total scores count in personal best score
  Salman Alshamrani · 2025-05-22 00:58:07 +03:00
  9e720509db
• Rename new song select interface to be more generic and add score presentation to it
  Dean Herbert · 2025-05-16 18:22:42 +09:00
  bc35b58db6
• Open results screen when clicking leaderboard scores
  Salman Alshamrani · 2025-05-16 18:22:42 +09:00
  4ec4923c17
• Begin to fix BeatmapLeaderboardWedge code quality
  Dean Herbert · 2025-04-24 21:14:31 +09:00
  bd58aac9cc
• Remove double binding
  Bartłomiej Dach · 2025-04-23 13:22:25 +02:00
  3b2e8281b4
• Update fetch logic to match existing leaderboard

  Also handles some display edge cases where scores may overlap
  placeholder or do other weird things.

  Dean Herbert · 2025-04-23 18:43:12 +09:00
  7c6a1f2502
• Make leaderbaord animation barely bareable
  Dean Herbert · 2025-04-22 18:30:05 +09:00
  de821005dc
• Fix regression from copy waste
  Dean Herbert · 2025-04-22 17:44:57 +09:00
  7a18a771b3
• Implement score fetch functionality

  Copied logic from `BeatmapLeaderboard`.

  Salman Alshamrani · 2025-04-18 08:54:55 -04:00
  81d54a9f32
• Add beatmap leaderboard wedge
  Salman Alshamrani · 2025-04-18 08:54:55 -04:00
  34e8943c74