66 Commits

• Adjust fail handling in multiplayer spectator player to match multiplayer player

  Closes https://github.com/ppy/osu/issues/34884.

  Bartłomiej Dach · 2025-09-02 12:38:34 +02:00
  5c6bbfcc6a
• Refactor fail management to be more centralised

  Before this commit, there was `AllowFailAnimation` (used by multiplayer)
  and `OnFail()` (used by score submitting implementations of player to
  ensure a failed play submits).
  
  The former is replaced by `PerformFail()` which allows for arbitrary
  operations on failure, which replay player shall leverage in subsequent
  commits. The latter would ideally be replaced by nothing, but it's
  placed in a very awkward place behind a schedule, so by force of
  necessity to avoid code duplication it's replaced by
  `ConcludeFailedScore()` which is overridden to submit the score in all
  submitting players --- except for multiplayer, which is never supposed
  to be calling it, so in that case it just throws an exception.

  Bartłomiej Dach · 2025-08-12 14:18:48 +02:00
  85d48f5df6
• Add local user position display to multiplayer
  Bartłomiej Dach · 2025-04-28 13:40:01 +02:00
  4e49763787
• Fix some weirdness around forced multiplayer elements

  - Naming wasn't adjusted
  - When the chat collapsed, the team score display broke due to zero
    width
  
  Partial revert of
  https://github.com/ppy/osu/commit/da1fc1013e07b8dafb0c409354f9d1cef971e449.

  Bartłomiej Dach · 2025-04-25 10:42:04 +02:00
  6d65b68100
• Fix code quality
  Bartłomiej Dach · 2025-04-24 13:18:35 +02:00
  330f213460
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06
• Simplify boolean flags
  Bartłomiej Dach · 2025-03-13 10:17:27 +01:00
  f78e371b1b
• Show user tag control only following local user gameplay
  Bartłomiej Dach · 2025-03-12 12:19:33 +01:00
  e70ad14647
• Merge branch 'master' into multiplayer-remove-cmc-and-composite
  Dean Herbert · 2024-11-20 17:24:55 +09:00
  6fba6de4dc
• Make Room.AutoSkip non-bindable
  Dan Balasescu · 2024-11-15 14:42:18 +09:00
  f001cce24a
• Refactor to avoid dual-boolean mess
  Dean Herbert · 2024-11-14 22:10:45 +09:00
  3262b6d989
• Make RoomID non-bindable

  Most important changes are to `RoomSubScreen` and `PlaylistsRoomSubScreen`, because those are the only two cases that now bind to the event instead.

  Dan Balasescu · 2024-11-13 16:28:54 +09:00
  99762da7b8
• Show user statistics after completing a playlists / multiplayer score
  Bartłomiej Dach · 2024-02-22 20:35:50 +01:00
  1e53503608
• Move solution to multiplayer flow instead
  Salman Ahmed · 2024-01-28 00:42:04 +03:00
  64b61108ad
• Add a gameplay configuration flag to disable fail animation
  Dean Herbert · 2024-01-04 17:13:24 +09:00
  0bbc27e380
• Fix MultiplayerPlayer never calling Reset on GameplayClockContainer

  This call is responsible for ensuring the clock is in a stopped state.

  Dean Herbert · 2023-10-10 17:58:37 +09:00
  100c0cf533
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Move LeaderboardFlow to HUDOverlay to share positioning logic
  Dean Herbert · 2022-09-13 18:45:11 +09:00
  678eec1c67
• Ensure gameplay leaderboard hides with rest of HUD when it should
  Dean Herbert · 2022-09-13 18:45:11 +09:00
  5894d2f0bc
• Move leaderboard implementation to Player itself
  Dean Herbert · 2022-09-13 18:00:21 +09:00
  d251c0b2ac
• Consume auto skip setting during play
  Dan Balasescu · 2022-08-31 20:24:15 +09:00
  c852c54055
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Revert comment removal
  Dan Balasescu · 2022-05-31 19:58:45 +09:00
  eaeb66547e
• Use new score processor in MultiplayerGameplayLeaderboard
  Dan Balasescu · 2022-05-30 19:26:26 +09:00
  22d998dc2a
• Add comment about how starting gameplay works
  Dan Balasescu · 2022-05-26 20:09:47 +09:00
  0224947de0
• Fix multiplayer race condition when starting gameplay
  Dan Balasescu · 2022-05-26 20:01:33 +09:00
  3915b8e414
• Change multiplayer leaderboard to always hide during gameplay unless holding-for-HUD
  Dean Herbert · 2022-05-11 16:12:54 +09:00
  d05cd69087
• Send Loaded state from PlayerLoader on update thread
  Dan Balasescu · 2022-04-28 20:10:47 +09:00
  1d8ac6917d
• Add support for gameplay abort/force start
  Dan Balasescu · 2022-04-21 23:14:37 +09:00
  41355384bd
• Rename MatchStarted() -> GameplayStarted()
  Dan Balasescu · 2022-04-21 22:39:24 +09:00
  08d250fe58
• Move null assert in MultiplayerPlayer on to update thread
  Dean Herbert · 2022-04-08 14:53:14 +09:00
  24c2d465a9
• Add current screen checks for added safety
  Dan Balasescu · 2022-03-10 20:03:02 +09:00
  885cb3ce5b
• Explain purpose of Schedule call in MultiplayerPlayer.onResultsReady
  Dean Herbert · 2022-03-10 19:56:13 +09:00
  2d135e5be6
• Fix potential multiplayer crash with async disposal
  Dan Balasescu · 2022-03-10 18:50:53 +09:00
  45d537ef72
• Rework GetScore() method signatures + implementations

  Rename legacy-facing overload to mention as much

  Dan Balasescu · 2022-03-08 22:30:44 +09:00
  f1c40bd9ed
• Merge branch 'master' into activity-on-multiplayer-screens
  Bartłomiej Dach · 2021-08-24 18:50:55 +02:00
  e503182a8d
• Don't bind to RoomId where it's expected to be constant
  smoogipoo · 2021-08-24 14:25:40 +09:00
  16ddbcd208
• Fix multiplayer crashing when entering gameplay
  smoogipoo · 2021-08-24 13:22:06 +09:00
  df170afbc4
• Merge branch 'master' into activity-on-multiplayer-screens
  smoogipoo · 2021-08-24 12:33:34 +09:00
  956c1cc216
• split multiplayer and playlist activity
  Nathan Alo · 2021-08-22 09:54:07 +08:00
  2877b43824
• Add chat display during multiplayer gameplay
  Dean Herbert · 2021-08-17 16:17:31 +09:00
  30eee363dc
• apply suggestions
  Nathan Alo · 2021-08-14 22:39:12 +08:00
  4ed06a1021
• update InitialActivity on multiplayer Player and SongSelect
  Nathan Alo · 2021-08-14 13:20:36 +08:00
  a553942a7f
• Split off multiplayer team results screen to separate class

  The previous version tried to keep both normal multiplayer and team
  multiplayer results as one screen, but didn't check that team-specific
  components aren't null in `LoadComplete()`.
  
  To decrease number of conditional, split off the team results screen to
  a separate implementation, and choose one or the other at push time in
  `MultiplayerPlayer`, depending on team count.

  Bartłomiej Dach · 2021-08-12 20:01:31 +02:00
  f06f13215b
• Convey and show team scores at the multiplayer results screen
  Dean Herbert · 2021-08-11 15:32:14 +09:00
  c376e652a4
• Pass through MultiplayerRoomUsers instead of ints to avoid re-retrieval
  Dean Herbert · 2021-08-10 18:39:20 +09:00
  a503274e1d
• Add gameplay-specific team score display which can expand and contract
  Dean Herbert · 2021-08-09 19:17:51 +09:00
  121648b593
• Add safeties to avoid MultiplayerPlayer crashing when beatmap can't be loaded
  Dean Herbert · 2021-08-09 16:31:18 +09:00
  fcec714b4f