36 Commits

• Fix navigating back and forth from beatmap submission settings screen crashing

  supersedes https://github.com/ppy/osu/pull/34656

  Bartłomiej Dach · 2025-08-14 12:57:10 +02:00
  3bfa7bf862
• Fix looping samples again
  Bartłomiej Dach · 2025-08-06 19:24:12 +02:00
  dbf60763eb
• Revert "Update framework"

  This is temporary until we have a fix for
  https://github.com/ppy/osu/issues/34340, which will require resolution
  in bass-side thread
  https://www.un4seen.com/forum/?topic=20482.msg145307#msg145307.

  Dean Herbert · 2025-07-24 22:38:08 +09:00
  d36c50de13
• Fix looping sample implementation
  Dean Herbert · 2025-07-18 18:12:30 +09:00
  7f55cc5b4f
• Pick better initial beatmap status when submitting

  Addresses https://github.com/ppy/osu/discussions/33291
  
  This is a half-baked RFC because things are awkward.
  
  For this to work correctly the submission flow has to do an API request,
  because one, the local beatmap status has been overwritten with "locally
  modified", and secondly, even if it *was* there, there's no guarantee
  that it was actually *up to date*.
  
  And if we have to do an API request then there are two choices:
  
  - Hard block on the API request and don't show anything until it
    completes which possibly means waiting at a spinner for several
    seconds if someone's on bad internet.
  
  - Don't block on the API request --- but then there's no guarantee
    what timing the API request completes at, which means that possibly the
    user could change the dropdown before the API request completes, and
    the API request will overwrite their choice, so to prevent that block
    the dropdown until the request completes. This is what this commit
    does.

  Bartłomiej Dach · 2025-06-12 10:38:22 +02:00
  a38e25115b
• Add even more logging to beatmap submission process

  Every now and again someone will report having done something horrible
  to their beatmap via lazer submission, always claim having done
  "nothing" while invariably having done *something*, will not provide me
  with a workable reproduction scenario, and even if they attempt to do
  so, I will be unable to reproduce the issue anyway. So this change is
  just desperation mostly. It's logging pretty much all that it is
  possible to log of client-side state.

  Bartłomiej Dach · 2025-05-26 11:33:59 +02:00
  c7404cb81d
• Use better error messaging in case of beatmap ID mismatch

  Should maybe give users a better idea of what's wrong.

  Bartłomiej Dach · 2025-05-07 12:53:40 +02:00
  ad586cb5dd
• Remove unnecessary try-finally usage
  Dean Herbert · 2025-04-25 17:22:25 +09:00
  c6a11a56a3
• Rework logic to use a looping sample for progress instead
  Jamie Taylor · 2025-04-24 20:38:15 +09:00
  9c56ee3e19
• Change samples to be declared nullable
  Jamie Taylor · 2025-04-24 11:31:02 +09:00
  15a4ffe344
• Move playback logic to Update()
  Jamie Taylor · 2025-04-24 10:48:32 +09:00
  f6f098a0dc
• More explicitly define arithmatic precedence
  Jamie Taylor · 2025-04-18 20:42:49 +09:00
  e5940a41b9
• Add audio feedback to BSS process
  Jamie Taylor · 2025-04-18 20:30:38 +09:00
  5208d8a0b2
• Fix differential submission process crashing when no files have changed

  Closes https://github.com/ppy/osu/issues/32247.

  Bartłomiej Dach · 2025-03-06 09:45:44 +01:00
  0f0dd58b69
• Fix hash comparison being case sensitive when choosing files for partial beatmap submission

  Noticed when investigating https://github.com/ppy/osu/issues/32059, and
  also a likely cause for user reports like
  https://discord.com/channels/188630481301012481/1097318920991559880/1342962553101357066.
  
  Honestly I have no solid defence, Your Honour. I guess this just must
  not have been tested on the client side, only relied on server-side
  testing.

  Bartłomiej Dach · 2025-02-24 12:30:37 +01:00
  0312467c88
• Send "notify on discussion replies" setting value in beatmap creation request
  Bartłomiej Dach · 2025-02-19 12:45:37 +01:00
  687c9d6e17
• Add missing early return

  As spotted in testing with production. Would cause submission to proceed
  even if the export did, with an empty archive.

  Bartłomiej Dach · 2025-02-18 11:35:29 +01:00
  b3aba537b5
• Minor code refactors
  Dean Herbert · 2025-02-10 17:41:38 +09:00
  b8e33a28d2
• Remove unused using
  Bartłomiej Dach · 2025-02-10 09:09:43 +01:00
  45259b374a
• Allow performing beatmap reload after submission from song select
  Bartłomiej Dach · 2025-02-10 09:03:40 +01:00
  895493877c
• Adjust animations and induce some short delays to make things more graceful
  Dean Herbert · 2025-02-10 15:23:25 +09:00
  eae1ea7e32
• Fix back button displaying before it should
  Dean Herbert · 2025-02-10 15:22:31 +09:00
  930aaecd7f
• Add delay before browser displays beatmap
  Dean Herbert · 2025-02-10 15:12:59 +09:00
  7853456c06
• Fix exiting being eternally blocked after successful beatmap submission
  Bartłomiej Dach · 2025-02-07 15:37:27 +01:00
  64f0d234d8
• Update strings
  Dean Herbert · 2025-02-07 18:42:41 +09:00
  753eae426d
• Change BeatmapSubmissionScreen to use global back button instead of custom implementation
  Dean Herbert · 2025-02-07 18:34:48 +09:00
  783ef00785
• Adjust beatmap stream creation to make a bit more sense
  Dean Herbert · 2025-02-07 18:17:49 +09:00
  95967a2fde
• Don't show informational screens for subsequent submissions

  These are historically only presented to the user when uploading a new
  beatmap for the first time.

  Dean Herbert · 2025-02-07 18:06:31 +09:00
  12881f3f36
• Disallow changing beatmap / ruleset while submitting beatmap
  Dean Herbert · 2025-02-07 18:05:47 +09:00
  46290ae76b
• Merge branch 'master' into bss/the-actual-submission
  Dean Herbert · 2025-02-07 17:44:48 +09:00
  6335228fb0
• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Add beatmap submission support
  Bartłomiej Dach · 2025-02-05 14:01:37 +01:00
  78e85dc2c7
• Implement special exporter intended specifically for submission flows
  Bartłomiej Dach · 2025-02-05 14:01:37 +01:00
  fff99a8b40
• Expose EndpointConfiguration directly in IAPIAccess
  Bartłomiej Dach · 2025-02-05 13:31:37 +01:00
  7d299bb2ad
• Implement visual component for displaying submission progress
  Bartłomiej Dach · 2025-02-05 13:31:35 +01:00
  092b953dca
• Implement visual appearance of beatmap submission wizard
  Bartłomiej Dach · 2025-02-04 09:06:33 +01:00
  4dd4e52e6d