1
0
mirror of https://github.com/ppy/osu.git synced 2026-05-18 16:50:21 +08:00
Commit Graph

2 Commits

  • Simplify editor "ternary button" structure
    As I look into re-implementing the ability to choose combo colour for an
    object (also known as "colourhax") from the editor UI, I stumble upon
    these wretched ternary items again and sigh a deep sigh of annoyance.
    
    The structure is overly rigid. `TernaryItem` does nothing that
    `DrawableTernaryItem` couldn't, except make it more annoying to add
    specific sub-variants of `DrawableTernaryItem` that could do more
    things.
    
    Yes you could sprinkle more levels of virtuals to
    `CreateDrawableButton()` or something, but after all, as Saint Exupéry
    says, "perfection is finally attained not when there is no longer
    anything to add, but when there is no longer anything to take away."
    So I'm leaning for taking one step towards perfection.
  • Make "double ternary button" specific to samples
    We can generalise *when* there is the need to generalise. So far the
    generalisation only looked like *obfuscation*.