661 Commits

• Adjust stereo shift effects for UI sounds to be less extreme
  Dean Herbert · 2025-07-30 19:35:26 +09:00
  0b11953b24
• Add Bopomofo characters
  Salman Alshamrani · 2025-06-18 15:28:33 +03:00
  bf02b47985
• Add support for reading release stream from assembly version
  Dean Herbert · 2025-06-13 18:52:22 +09:00
  3291a4cb7b
• Adjust wording
  Bartłomiej Dach · 2025-05-23 08:09:29 +02:00
  af5a1cea94
• Attempt to give users better disclaimer on how not to nuke their data

  I can't count the number of times where someone backed up just the file
  store without the realm database and lost data. As such this moves the
  "IMPORTANT READ ME" disclaimer a directory higher and attempts to
  describe the "proper" backup procedure in detail.
  
  People don't read, but maybe this will at least partially lower the
  volume.

  Bartłomiej Dach · 2025-05-22 19:16:42 +02:00
  6a3e9a9093
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Ensure correct global leaderboard state when presenting scores

  With `ReplayPlayer` now consuming the `LeaderboardManager`'s global
  state, flows such as presenting a score need to set the global state up
  correctly to avoid accidentally showing a leaderboard from a completely
  different score.
  
  This also incidentally closes https://github.com/ppy/osu/issues/27609.

  Bartłomiej Dach · 2025-04-10 10:19:04 +02:00
  31b98ac7b9
• Move key binding string retrieval to RealmKeyBindingStore
  Dean Herbert · 2025-04-09 15:23:55 +09:00
  9e90f80ab5
• Hook up LocalConfig functions in OsuGameBase to make work in tests
  Dean Herbert · 2025-04-08 14:15:42 +09:00
  5fc80dbddb
• Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  RFC. Another attempt at this.
  
  - Supersedes https://github.com/ppy/osu/pull/31881
  - Supersedes / closes https://github.com/ppy/osu/pull/31355
  - Closes https://github.com/ppy/osu/issues/29861
  
  This is a weird diff because I am feeling rather boxed in by all the
  constraints, namely that:
  
  - Leaderboard state should be global state
  - But the global state is essentially managed by song select and namely
    `BeatmapLeaderboard` itself. That's because trying to e.g. not have
    `BeatmapLeaderboard` pass the beatmap and the ruleset to the global
    leaderboard manager is worse, as it essentially introduces two
    parallel paths of execution that need to be somehow merged into one
    (as in I'd have to somehow sync `LeaderboardManager` responding to
    beatmap/ruleset changes with `BeatmapLeaderboard` which is inheritance
    hell)
  - Also local leaderboard fetching is data-push (as in the scores can
    change under the leaderboard manager), and online leaderboard fetching
    is data-pull (as in the scores do not change unless the leaderboard
    manager does something). Also online leaderboard fetching can fail.
    Which is why I need to still have the weird setup wherein there's a
    `FetchWithCriteriaAsync()` (because I need to be able to respond to
    online requests taking time, or failing), but also the
    `BeatmapLeaderboard` only uses the public `Scores` bindable to
    actually read the scores (because it needs to respond to new local
    scores arriving).
  - Another thing to think about here is what happens when a retrieval
    fails because e.g. the user requested friend leaderboards without
    having supporter. With how this diff is written, that special
    condition is handled to `BeatmapLeaderboard`, and
    `LeaderboardManager`'s state will remain as whatever it was before
    that scope change was requested, which may be considered good or it
    may not (I imagine it's better to show scores in gameplay than not in
    this case, but maybe I'm wrong?)

  Bartłomiej Dach · 2025-03-21 12:06:16 +01:00
  0209129618
• Rename online store class to better explain what it's doing
  Dean Herbert · 2025-03-20 16:00:01 +09:00
  a7ee6a1525
• Fix code quality
  Salman Alshamrani · 2025-03-17 03:35:27 -04:00
  597eec99e6
• Move CreateOnlineStore override to OsuGameBase and update endpoint references
  Dean Herbert · 2025-03-13 12:37:57 +09:00
  e0a23000be
• Merge branch 'master' into image-proxying
  Dean Herbert · 2025-03-13 12:33:36 +09:00
  80c896a895
• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Add test coverage of user deleting intro files
  Dean Herbert · 2025-01-04 15:26:42 +09:00
  e15978cc65
• Merge branch 'master' into improve-menu-sample-playback
  Dean Herbert · 2024-12-05 21:07:03 +09:00
  8d0e1f9d18
• Centralise supported file extensions to one helper class

  As proposed in
  https://github.com/ppy/osu-server-beatmap-submission/pull/5#discussion_r1861680837.

  Bartłomiej Dach · 2024-11-29 08:42:45 +01:00
  110e4fbb30
• Improve menu/context-menu sample playback
  Jamie Taylor · 2024-11-29 06:54:48 +09:00
  58cf1c11e4
• Add OsuOnlineStore for proxying external media lookups
  Salman Alshamrani · 2024-11-24 21:47:33 -05:00
  2417d4de83
• Fix tests not working by forgoing beatmap updates
  Dan Balasescu · 2024-11-07 17:26:10 +09:00
  bd630c189e
• Revert 'Fix any and all migration attempts dying on MusicController'

  This reverts commit 310eec69fc.
  
  Way to try and "fix" stuff and screw stuff up even harder instead, me.
  Great job, well done.

  Bartłomiej Dach · 2024-10-09 11:55:59 +02:00
  081d87fe6d
• Fix OsuGameBase.Migrate() eating exception messages for breakfast

  Whomst've thought this was an ok thing to do? How did this pass review?
  Let's leave these as rhetorical questions right now. Huge chances are
  I'd implicate myself with at least one of them.

  Bartłomiej Dach · 2024-10-08 23:16:17 +02:00
  1633cbdb66
• Fix any and all migration attempts dying on MusicController

  I'm not sure why this was "fine" for as long as it apparently was,
  but what `MusicController` was doing was completely incorrect and
  playing with fire (accessing raw managed realm objects), which went
  wrong somewhere around - admittedly -
  https://github.com/ppy/osu/pull/29917, likely because that one started
  *storing* these raw managed realm objects to fields, and you know what
  will happen to those after you do a migration and recycle realms.
  
  To attempt to circumvent this, (ab)use `DetachedBeatmapStore` instead.
  Which does necessitate moving it to `OsuGameBase`, but it's the simplest
  way out I can see. I guess the alternative would be to faff around with
  `Live<T>` but it's ugly and I'm attempting to fix this relatively quick
  right now.

  Bartłomiej Dach · 2024-10-08 23:16:10 +02:00
  310eec69fc
• Implement component for displaying hotkeys
  Bartłomiej Dach · 2024-09-04 11:57:09 +02:00
  3c6c49187a
• Fix weird test critical failure if exception happens too early in execution

  Noticed in passing.
  
  ```
  Exit code is 134 (Unhandled exception. System.NullReferenceException:
  Object reference not set to an instance of an object.
     at osu.Game.OsuGameBase.onExceptionThrown(Exception ex) in
  /Users/dean/Projects/osu/osu.Game/OsuGameBase.cs:line 695
     at osu.Framework.Platform.GameHost.abortExecutionFromException(Object
  sender, Exception exception, Boolean isTerminating)
     at osu.Framework.Platform.GameHost.unobservedExceptionHandler(Object
  sender, UnobservedTaskExceptionEventArgs args)
     at System.Threading.Tasks.TaskExceptionHolder.Finalize())
  ```

  Dean Herbert · 2024-08-30 18:35:31 +09:00
  dd7133657d
• Remove "leftover files" notification when migration partly fails

  People were deleting files they shouldn't, causing osu! to lose track of
  where the real user files are.
  
  For now let's just keep things simple and not let the users know that
  some files got left behind. Usually the files which are left behind are
  minimal and it should be fine to leave this up to the user.
  
  Closes https://github.com/ppy/osu/issues/29505.

  Dean Herbert · 2024-08-22 16:09:11 +09:00
  b3be04aff1
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Show mouse and joystick settings on mobile
  Susko3 · 2024-05-19 14:07:40 +02:00
  e4858a975d
• Apply adjustments after framework-side FriendlyGameName changes
  Bartłomiej Dach · 2024-04-29 13:00:22 +02:00
  45c2327509
• Fix a couple of xmldoc typos
  Dean Herbert · 2024-04-26 15:28:52 +08:00
  e0e790fa94
• Only attempt to disable rulesets when decidedly crashing out
  Bartłomiej Dach · 2024-03-25 11:33:15 +01:00
  fb08d6816b
• Attempt to disable rulesets that can be linked to an unhandled crash
  Bartłomiej Dach · 2024-03-22 19:05:58 +01:00
  c7c0330265
• Move SoloStatisticsWatcher to OsuGame

  Doesn't feel like it needs to be in base, and it being in base was
  causing problems elsewhere before.

  Bartłomiej Dach · 2024-02-13 14:28:24 +01:00
  21b9fb95e2
• Update endpoints to final production endpoints
  Dean Herbert · 2024-01-30 18:40:17 +09:00
  d895a91cd5
• Remove ScorePerformanceCache

  This class was only used in two places, both on the results screen, but
  was holding references to `OsuPlayfield` game-wide (due to unrelated
  issues, but still).
  
  Because I can't really think of future use cases for this, and running
  the calculation twice at results screen isn't a huge overhead, let's
  just do that for now to keep things simple.

  Dean Herbert · 2024-01-29 15:28:20 +09:00
  76832a1495
• Remove unused using
  Bartłomiej Dach · 2023-12-28 14:30:11 +01:00
  93c7ebdae3
• Merge branch 'master' into universal-offset-from-session-plays
  Bartłomiej Dach · 2023-12-28 14:07:46 +01:00
  24a80da83f
• Implement automatic suggestion of audio offset based on last plays
  Bartłomiej Dach · 2023-12-27 21:14:37 +01:00
  160342ceed
• Add components to track average hit errors across session
  Bartłomiej Dach · 2023-12-27 20:44:59 +01:00
  f51b5f5487
• Remove hexacons
  Bartłomiej Dach · 2023-12-27 17:42:18 +01:00
  89e2b6358a
• Implement new icon store
  Bartłomiej Dach · 2023-12-27 17:42:17 +01:00
  45143a6c17
• Fix hard crash when attempting to change folder location during a large import

  Closes https://github.com/ppy/osu/issues/26067.

  Dean Herbert · 2023-12-23 17:03:58 +09:00
  8349cb7bbe
• Add HexaconIcons lookup to allow usage with SpriteIcon
  Dean Herbert · 2023-11-24 13:17:39 +09:00
  95c00f9666
• Merge pull request #25348 from bdach/less-basic-touchscreen-detection

  Implement basic touchscreen detection

  Dean Herbert · 2023-11-10 18:01:40 +09:00
  1c63f1f89d
• Show touch input settings on iOS

  This does not cover android since `TouchHandler` is SDL-based.

  Susko3 · 2023-11-09 15:12:24 +01:00
  1b08f317fb
• Add component for game-wide touch detection
  Bartłomiej Dach · 2023-11-02 19:32:56 +01:00
  980c900f43
• Disable decoupling for OsuGameBase's beatmap implementation

  This avoids it ever mutating the underlying track (aka attempting to start
  it). Resolves the one caveat mentioned in
  aeef92fa710648d4a00edc523e13c17ac6104125.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  df08c4e1ad
• Remove unnecessary encapsulation workaround

  The new implementation of `DecouplingClock` will not mutate the
  underlying clock in any way (unless attempting to start it when
  approaching from a negative time value).
  
  This should be quite safe as a result.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  5f634f2812