349 Commits

• Make DrawableDate formatting localizable
  CloneWith · 2025-09-04 14:44:40 +08:00
  1c608e779d
• Fix incorrect rank animation when beatmap panels retrieved from pool

  Rank animation is played for new panels when scrolling down, showing the
  previous rank belonging to the previous beatmap assigned to that
  specific panel instance.

  Salman Alshamrani · 2025-08-11 19:21:22 +03:00
  522f94277b
• Assert that FetchWithCriteria is called from the update thread
  Salman Alshamrani · 2025-08-04 17:01:27 +09:00
  c09f40a8cf
• Fix missing disposal of Realm subscription
  Dan Balasescu · 2025-08-03 01:46:04 +09:00
  4e5dfb82ca
• Move exception in better place (and also throw it better)
  Bartłomiej Dach · 2025-07-28 11:33:59 +02:00
  99f9a3b1f4
• Make sure you can't request non-local scores with a sort mode other than score.
  Dani211e · 2025-06-27 04:46:49 +02:00
  abfd4f6338
• RankingsSort -> LeaderboardSortMode
  Dani211e · 2025-06-26 19:03:49 +02:00
  c1a34d8c6a
• Add sorting dropdown

  Only use sorting when on local scope otherwise hide

  Dani211e · 2025-06-25 05:01:40 +02:00
  ad35dad46d
• Use null coalesce wherever possible

  Rider EAP being noisy about this one now.

  Dean Herbert · 2025-05-26 17:15:35 +09:00
  5450298468
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Use actual score positions in gameplay leaderboard

  Intends to close https://github.com/ppy/osu/issues/32859.
  
  The difference between this and https://github.com/ppy/osu/pull/32942 is
  that this PR takes the approach of completely moving the score sorting
  behaviour to `IGameplayLeaderboardProvider` implementations.
  
  This is going to be helpful for further work - to be precise, I am
  looking to add a leaderboard position indicator in the bottom right of
  multiplayer player to match stable, and having the position in the
  provider will make the implementation of that *much* easier.

  Bartłomiej Dach · 2025-04-25 12:40:55 +02:00
  06dc4235f0
• Always refresh leaderboard for now
  Dean Herbert · 2025-04-23 14:51:00 +09:00
  f945abb72e
• Simplify even further by removing all of the superfluous task completion sources
  Bartłomiej Dach · 2025-04-22 13:28:42 +02:00
  4979dd86af
• Remove LeaderboardManager return value and simplify flow further

  The rationale for this change is that the return value was mostly
  useless, and at worst, misleading.
  
  When using `LeaderboardManager`, it's assumed that a consumer will bind
  to the global `Scores` list to ensure they receive updates for things
  like local score changes via the internal realm subscription. If one
  decides to instead use the return value of the task, it will be a static
  snapshot that potentially becomes stale in the future.
  
  I fell into this trap when refactoring the new leaderboard component
  (while attempting to assert correctness that the values we are
  displaying were in fact from the fetch operation we requested).
  
  In the interest of keeping things simple, removing the return value
  seems to be the best path forward.

  Dean Herbert · 2025-04-22 19:31:02 +09:00
  f7d1809cb7
• Merge branch 'master' into leaderboards/gameplay-provider
  Bartłomiej Dach · 2025-04-21 09:03:24 +02:00
  6b0567e882
• Fix gameplay leaderboard showing scores from wrong beatmaps

  Kind of a big oversight this. In wanting to get the leaderboard
  refactors to move forward I sort of didn't realise the fact that all of
  the error handling related to online status and such in
  `BeatmapLeaderboard` kind of... can't stay there...
  
  It's also an all-or-nothing business too - moving this stuff can't
  really be done only in part.
  
  Not sure whether tests are warranted if it's more or less moving logic
  across?

  Bartłomiej Dach · 2025-04-18 20:37:02 +02:00
  c29f59fcdb
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06
• Ensure correct global leaderboard state when presenting scores

  With `ReplayPlayer` now consuming the `LeaderboardManager`'s global
  state, flows such as presenting a score need to set the global state up
  correctly to avoid accidentally showing a leaderboard from a completely
  different score.
  
  This also incidentally closes https://github.com/ppy/osu/issues/27609.

  Bartłomiej Dach · 2025-04-10 10:19:04 +02:00
  31b98ac7b9
• Actually use leaderboard manager in players

  This was supposed to be the case all along, but I guess in all of the
  rewrite attempts I forgot?
  
  With this, https://github.com/ppy/osu/issues/29861 is actually fixed
  again - and additionally, so is https://github.com/ppy/osu/issues/26716.

  Bartłomiej Dach · 2025-04-10 09:46:44 +02:00
  42ff312ece
• Simplify code further
  Bartłomiej Dach · 2025-04-08 13:08:11 +02:00
  9aaa1fe5f4
• Fix test failures
  Bartłomiej Dach · 2025-04-08 13:03:35 +02:00
  f3d9f21e71
• Merge branch 'master' into yet-another-leaderboard-rewrite-attempt
  Bartłomiej Dach · 2025-04-08 12:54:27 +02:00
  567c7cb798
• Change SettingDescription to differentiate between settings and values
  Salman Alshamrani · 2025-03-23 13:43:26 -04:00
  6e635f124a
• Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  RFC. Another attempt at this.
  
  - Supersedes https://github.com/ppy/osu/pull/31881
  - Supersedes / closes https://github.com/ppy/osu/pull/31355
  - Closes https://github.com/ppy/osu/issues/29861
  
  This is a weird diff because I am feeling rather boxed in by all the
  constraints, namely that:
  
  - Leaderboard state should be global state
  - But the global state is essentially managed by song select and namely
    `BeatmapLeaderboard` itself. That's because trying to e.g. not have
    `BeatmapLeaderboard` pass the beatmap and the ruleset to the global
    leaderboard manager is worse, as it essentially introduces two
    parallel paths of execution that need to be somehow merged into one
    (as in I'd have to somehow sync `LeaderboardManager` responding to
    beatmap/ruleset changes with `BeatmapLeaderboard` which is inheritance
    hell)
  - Also local leaderboard fetching is data-push (as in the scores can
    change under the leaderboard manager), and online leaderboard fetching
    is data-pull (as in the scores do not change unless the leaderboard
    manager does something). Also online leaderboard fetching can fail.
    Which is why I need to still have the weird setup wherein there's a
    `FetchWithCriteriaAsync()` (because I need to be able to respond to
    online requests taking time, or failing), but also the
    `BeatmapLeaderboard` only uses the public `Scores` bindable to
    actually read the scores (because it needs to respond to new local
    scores arriving).
  - Another thing to think about here is what happens when a retrieval
    fails because e.g. the user requested friend leaderboards without
    having supporter. With how this diff is written, that special
    condition is handled to `BeatmapLeaderboard`, and
    `LeaderboardManager`'s state will remain as whatever it was before
    that scope change was requested, which may be considered good or it
    may not (I imagine it's better to show scores in gameplay than not in
    this case, but maybe I'm wrong?)

  Bartłomiej Dach · 2025-03-21 12:06:16 +01:00
  0209129618
• Use IconTooltip
  wezwery · 2025-03-16 15:30:27 +02:00
  b00be5477f
• Merge branch 'ppy:master' into show-mode-name-in-empty-field
  Wezwery · 2025-03-15 17:43:46 +02:00
  2fce334a7f
• Display mod name, if SettingDescription is empty.
  wezwery · 2025-03-15 17:12:11 +02:00
  ed61f87eed
• Add support for team beatmap leaderboards
  Dean Herbert · 2025-03-13 16:28:20 +09:00
  b0cf5e8bff
• Fix leaderboard date text being cut off sometimes

  Closes https://github.com/ppy/osu/issues/32256.

  Bartłomiej Dach · 2025-03-07 08:55:40 +01:00
  4acdd3365a
• Fix "use these mods" option showing if it can't do anything

  Closes https://github.com/ppy/osu/issues/32230.

  Bartłomiej Dach · 2025-03-05 09:40:11 +01:00
  0ac3a80406
• Fix "use these mods" option applying to system mods

  Closes https://github.com/ppy/osu/issues/32229.

  Bartłomiej Dach · 2025-03-05 09:25:56 +01:00
  d9a1dcf9b9
• Mostly revert sizes
  Dean Herbert · 2025-02-26 18:00:18 +09:00
  c45a403fe2
• Adjust leaderboard score design slightly

  This design is about to get replaced, so I'm just making some minor
  adjustments since a lot of people complained about the font size in the
  last update.
  
  Of note, I'm only changing the font size which is one pt size lower than
  we'd usually use. Also overlapping the mod icons to create a bit more
  space (since there's already cases where they don't fit).
  
  Closes https://github.com/ppy/osu/issues/32055 as far as I'm concerned.
  I can read everything fine at 0.8x UI scale.

  Dean Herbert · 2025-02-26 17:01:51 +09:00
  e8b7ec0f95
• Fix one more misalignment on leaderboard scores
  Dean Herbert · 2025-02-14 19:16:03 +09:00
  b86eeabef0
• Give more breathing room in leaderboard scores
  Dean Herbert · 2025-02-14 17:39:22 +09:00
  4184dd2718
• Add drawable implementations of team logo
  Dean Herbert · 2025-02-14 17:39:21 +09:00
  303961d101
• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Expose EndpointConfiguration directly in IAPIAccess
  Bartłomiej Dach · 2025-02-05 13:31:37 +01:00
  7d299bb2ad
• Don't highlight friends' scores under beatmap's friend score leaderboard
  CloneWith · 2025-01-20 00:21:10 +08:00
  72e1b2954c
• Merge branch 'master' into colour-for-friend-lb
  Plextora · 2025-01-14 05:57:44 -05:00
  31d7c6a22e
• Update game ScrollContainer usage in line with framework changes

  See https://github.com/ppy/osu-framework/pull/6467.

  Dean Herbert · 2025-01-11 01:42:59 +09:00
  94ea003d90
• Use yellow instead of pink
  Plextora · 2024-12-23 12:47:50 -05:00
  47afab8a32
• Change score background to pink if user is friended
  Plextora · 2024-12-22 16:58:00 -05:00
  b3056d6114
• Enable selected rules for usage
  Huo Yaoyuan · 2024-11-28 22:33:03 +08:00
  fced254594
• Add context menu option to copy link to an online score

  I feel like this may become useful soon enough to help diagnose weird
  issues.

  Bartłomiej Dach · 2024-11-04 13:59:48 +01:00
  6a1893ff3f
• Merge branch 'master' into LeaderBoardScore_clean
  Salman Ahmed · 2024-06-07 22:42:49 +03:00
  6f729be573
• Adjust transitions
  Dean Herbert · 2024-06-07 17:04:16 +08:00
  9c6e707f00
• Apply NRT to UpdateableRank
  Dean Herbert · 2024-06-07 16:54:12 +08:00
  366ef64a2c
• Move to SelectV2 namespace
  Salman Ahmed · 2024-05-25 17:20:10 +03:00
  2c18c10ac8
• Adjust right content width based on scoring mode
  Salman Ahmed · 2024-05-25 17:16:41 +03:00
  d395c85418