osu-lazer

Replace local copy of GetValidFilename() with direct usage

Noticed in passing.

Bartłomiej Dach · 2025-09-03 09:32:43 +02:00

5c66998c57

Correct xmldoc of GetValidFilename() and make it intentionally scary

Bartłomiej Dach · 2025-06-09 14:34:41 +02:00

257fec8795

Change lazer's valid filename method to match stable

On revisiting the issue at hand, this honestly seems like the best way
forward. It also addresses my concerns that with the method we were
using, filenames could end up being half underscores.

The main reason for choosing to change the lazer end is that stable's
difficulty update process is based on sending the beatmap's filename to
the server. This means that if we use a proposed fix of checking online
ID, it will still mean beatmaps cannot be updated on stable (for all
users which have downloaded the beatmap) if a mapper updates once on
lazer.

Implementation inspired by:

- https://referencesource.microsoft.com/#mscorlib/system/io/path.cs,1144ad3c4eff3f24
- https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/Beatmaps/Beatmap.cs#L1575-L1590

Closes #33060.

Dean Herbert · 2025-06-09 19:44:12 +09:00

81aaddca34

Add helper methods to check whether beatmap leaderboard scope requires supporter

Dean Herbert · 2025-03-13 16:28:19 +09:00

9af3c8351d

Add LegacyOnlineID handling to places that definitely need it

Mostly places that can interact with imported replays.

There are other places that use the online ID as a sort tiebreaker, or
to check presence of a score on results screens, but they should
probably still continue to only use `OnlineID`, since all scores with a
legacy online ID should have an online ID, but the converse is not
generally true.

Bartłomiej Dach · 2023-10-16 11:20:02 +02:00

b144cfd55c

Rename and add documentation to function

Dean Herbert · 2022-10-28 18:04:28 +09:00

66ed77ac91

One more little change

Damn, i forgor. Sorry, CI runners.

nullium21 · 2022-10-28 09:22:08 +03:00

6901ed997d

Fix regex by allowing file extensions + typed new

Apparently, the _whole_ filename was checked with GetValidArchiveContentFilename,
not just the stem.

nullium21 · 2022-10-28 09:19:34 +03:00

c1e9398c19

Use a regex for matching invalid characters instead

What the regex does is it matches everything except alphanumeric and [_()[] -], excluding EOL since regex101 seems to also match it, and we probably don't want that to happen.

nullium21 · 2022-10-27 10:33:50 +03:00

68d1febe6e

Only use 0-9A-Za-z-_()[] characters in filenames

nullium21 · 2022-10-26 13:31:32 +03:00

dffebdf7ed

Automated #nullable processing