89 Commits

• Replace local copy of GetValidFilename() with direct usage

  Noticed in passing.

  Bartłomiej Dach · 2025-09-03 09:32:43 +02:00
  5c66998c57
• Correct xmldoc of GetValidFilename() and make it intentionally scary
  Bartłomiej Dach · 2025-06-09 14:34:41 +02:00
  257fec8795
• Change lazer's valid filename method to match stable

  On revisiting the issue at hand, this honestly seems like the best way
  forward. It also addresses my concerns that with the method we were
  using, filenames could end up being half underscores.
  
  The main reason for choosing to change the lazer end is that stable's
  difficulty update process is based on sending the beatmap's filename to
  the server. This means that if we use a proposed fix of checking online
  ID, it will still mean beatmaps cannot be updated on stable (for all
  users which have downloaded the beatmap) if a mapper updates once on
  lazer.
  
  Implementation inspired by:
  
  - https://referencesource.microsoft.com/#mscorlib/system/io/path.cs,1144ad3c4eff3f24
  - https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/Beatmaps/Beatmap.cs#L1575-L1590
  
  Closes #33060.

  Dean Herbert · 2025-06-09 19:44:12 +09:00
  81aaddca34
• Show singular difficulty adjust modifications inline in mod icons
  Dean Herbert · 2025-04-28 16:58:16 +09:00
  c16514274d
• Fix culture variance in new formatting helper
  Bartłomiej Dach · 2025-04-18 11:23:26 +02:00
  e5636a84f1
• Move number formatting to extension method and reuse for AudioOffsetAdjustmentControl

  Also adds some basic test coverage.

  Dean Herbert · 2025-04-18 17:30:31 +09:00
  e44b134552
• Add helper methods to check whether beatmap leaderboard scope requires supporter
  Dean Herbert · 2025-03-13 16:28:19 +09:00
  9af3c8351d
• Apply minor performance rules
  Huo Yaoyuan · 2024-11-28 20:41:44 +08:00
  f5a7716509
• Fix date failing to display on leaderboard for some scores with weird datetimes

  Addresses https://github.com/ppy/osu/discussions/26517.
  
  The score reported has a datetime of 0001/1/1 05:00:00 AM.
  
  Bit of a dodge fix but maybe fine?

  Bartłomiej Dach · 2024-01-14 13:52:39 +01:00
  baf3867e17
• Merge branch 'master' into score-encoding-cleanup
  Bartłomiej Dach · 2023-10-26 09:04:05 +02:00
  ca4b09f8ef
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Add LegacyOnlineID handling to places that definitely need it

  Mostly places that can interact with imported replays.
  
  There are other places that use the online ID as a sort tiebreaker, or
  to check presence of a score on results screens, but they should
  probably still continue to only use `OnlineID`, since all scores with a
  legacy online ID should have an online ID, but the converse is not
  generally true.

  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  b144cfd55c
• Handle culture code differences of Traditional Chinese
  Salman Ahmed · 2023-06-08 03:27:05 +03:00
  251f23b2c2
• Move ApplyGameWideClock to extension method

  I don't see an issue with applying this workaround to more places, even
  though it is a workaround, because it marks each usage very clearly. If
  we design a better solution in the future it should be easy to replace
  the usages.

  Dean Herbert · 2023-06-06 16:07:50 +09:00
  b8d9c9ff93
• Move extension methods closer to serialisation classes
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  b1cf6d83d8
• Rename ISkinnableDrawable to ISerialisableDrawable
  Dean Herbert · 2023-02-15 18:37:41 +09:00
  d159d6b970
• Rename SkinnableDrawableInfo to SerialisedDrawableInfo
  Dean Herbert · 2023-02-15 18:23:19 +09:00
  856efd9fd9
• Rename SkinnableInfo to SkinnableDrawableInfo
  Dean Herbert · 2023-02-15 18:23:17 +09:00
  9e651a7ca2
• Move SkinnableInfo to better namespace
  Dean Herbert · 2023-02-15 18:23:10 +09:00
  6010dde86e
• Fix default settings not being serialised / state tracked correctly
  Dean Herbert · 2023-02-06 15:00:42 +09:00
  778b8a9bf7
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Fix parsing of Language when using default system locale
  Susko3 · 2022-11-10 22:56:24 +01:00
  5b1e39abd5
• Rename and add documentation to function
  Dean Herbert · 2022-10-28 18:04:28 +09:00
  66ed77ac91
• One more little change

  Damn, i forgor. Sorry, CI runners.

  nullium21 · 2022-10-28 09:22:08 +03:00
  6901ed997d
• Fix regex by allowing file extensions + typed new

  Apparently, the _whole_ filename was checked with GetValidArchiveContentFilename,
  not just the stem.

  nullium21 · 2022-10-28 09:19:34 +03:00
  c1e9398c19
• Use a regex for matching invalid characters instead

  What the regex does is it matches everything except alphanumeric and [_()[] -], excluding EOL since regex101 seems to also match it, and we probably don't want that to happen.

  nullium21 · 2022-10-27 10:33:50 +03:00
  68d1febe6e
• Only use 0-9A-Za-z-_()[] characters in filenames
  nullium21 · 2022-10-26 13:31:32 +03:00
  dffebdf7ed
• Replace calls to defective Humanizer methods with correct version
  Bartłomiej Dach · 2022-07-18 22:34:58 +02:00
  6f37487528
• Add own fixed copy of defective Humanizer methods
  Bartłomiej Dach · 2022-07-18 21:37:31 +02:00
  ffa9a83a4f
• Move the null check in the outside.

  AddCursor() should not accept the null value.

  andy840119 · 2022-06-30 23:29:49 +08:00
  48047f2e58
• mark the string as nullable.
  andy840119 · 2022-06-30 23:23:14 +08:00
  a5b1f1a688
• Remove the nullable disable annotation.
  andy840119 · 2022-06-30 23:20:40 +08:00
  26de34da84
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update TimeSpan localisation to use ToLocalisableString
  Salman Ahmed · 2022-04-28 11:12:50 +03:00
  c8665dc93b
• Add the ability to add settings to skinnable elements
  Dean Herbert · 2022-03-13 17:03:25 +09:00
  c99397f75a
• Convert to extension method to avoid recursive calls
  Dean Herbert · 2022-03-03 14:15:37 +09:00
  42e07b7308
• Gracefully handle undefined DateTimeOffset values

  Only seems to happen in tests, but best to safeguard against this
  regardless.

  Dean Herbert · 2022-02-21 16:35:40 +09:00
  2f6e65a9a2
• Move to extension method and revert logic to match previous implementation
  Dean Herbert · 2022-02-21 13:42:26 +09:00
  fc1877b6fa
• Fix cursors sent to osu-web being potentially string formatted in incorrect culture

  Fixed as per solution at https://github.com/JamesNK/Newtonsoft.Json/issues/874.
  
  Note that due to the use of `JsonExtensionDataAttribute` it's not
  feasible to change the actual specification to `JValue` in the
  `Dictionary`.
  
  In discussion with the osu-web team, it may be worthwhile to change the cursor
  to a string format where parsing is not required at our end. We could already
  do this in fact, but there are tests that rely on it being a `JToken` so the
  switch to `JValue` seems like the easier path right now.

  Dean Herbert · 2022-01-04 17:20:46 +09:00
  5736b7d978
• Add MatchesOnlineID implementation for IScoreInfo
  Dean Herbert · 2021-12-10 18:34:31 +09:00
  c9f6c5c673
• Move archive filename helper method to extension method
  Dean Herbert · 2021-11-25 16:35:54 +09:00
  416ee2447a
• Make BeatmapSet.Metadata non-null
  Dean Herbert · 2021-11-24 15:03:34 +09:00
  3946a39b65
• Remove usage of Nuget.Packaging extension methods for IList.AddRange
  Dean Herbert · 2021-11-23 15:02:02 +09:00
  6fb2757739
• Move StoragePath implementation to an extension method
  Dean Herbert · 2021-11-19 16:08:38 +09:00
  59e763467f
• Remove usage of key repeat helper method
  Dean Herbert · 2021-11-18 13:13:36 +09:00
  66c307e0ee
• Add missing APIUser comparison method
  Dean Herbert · 2021-11-16 12:44:20 +09:00
  2cbdac91ad
• Add type safety to MatchesOnlineID extension methods
  Dean Herbert · 2021-11-16 12:37:47 +09:00
  fbc46941fa
• Make ModelExtensions nullable enabled
  Dean Herbert · 2021-11-15 14:38:01 +09:00
  18f73b985b
• Use extension method to compare online IDs
  Dean Herbert · 2021-11-15 14:34:50 +09:00
  a4c11e8813