14 Commits

• Hide object-typed CurrentSelection and expose strongly-typed alternatives instead
  Bartłomiej Dach · 2025-09-03 10:24:25 +02:00
  4a7ee6fafc
• Add failing test for rewind not working over grouping mode changes
  Bartłomiej Dach · 2025-08-29 14:06:53 +02:00
  a27fef2437
• Fix obvious test failures from using GroupedBeatmap in BeatmapCarousel.CurrentSelection
  Bartłomiej Dach · 2025-08-29 13:25:08 +02:00
  3f637db391
• Expand test even further to cover even more potential weirdness
  Bartłomiej Dach · 2025-06-24 13:32:42 +02:00
  0de964b10b
• Expand test to cover more potential weirdness and fix said weirdness
  Dean Herbert · 2025-06-24 19:21:04 +09:00
  7b6ecbd10b
• Fix potential crash when attempting random selection after changing grouping mode
  Dean Herbert · 2025-06-24 17:48:38 +09:00
  a1ec71e677
• SongSelectV2: Fix random selection not working as expected when displaying individual difficulties

  Previously, random selection would always be done at a *set* level. The
  final operation of a random action would be "select the user's
  recommended difficulty from this randomly selected set".
  
  This makes no sense when sets are not grouped together at song select.
  In fact, it is completely broken with the previous commit which adds
  group-isolated random support – if we're grouping by difficulty and the
  user's recommendation is not in the current group it would throw the
  user into another group unexpectedly.
  
  This fixes the issue by splitting out the random implementation into two
  separate pathways depending on the carousel display mode.

  Dean Herbert · 2025-06-19 17:29:41 +09:00
  f676206331
• SongSelectV2: Fix random button not respecting open group

  Closes https://github.com/ppy/osu/issues/33569.

  Dean Herbert · 2025-06-19 17:29:41 +09:00
  d200a59902
• Fix crash when random and rewind are run on the same frame
  Dean Herbert · 2025-06-16 20:17:07 +09:00
  10c07fdf50
• Ensure filtering is always waited on after a sort/filter change in tests
  Dean Herbert · 2025-06-12 19:45:06 +09:00
  d592b984e3
• Move and rename next/previous "group" selection keybindings to make way for group-specific bindings
  Dean Herbert · 2025-06-11 21:02:52 +09:00
  b9e1b6969e
• Add failing test showing random selecting filtered-away difficulties
  Dean Herbert · 2025-06-01 00:58:56 +09:00
  0fc129fbac
• Fix difficulty grouping not working with random
  Dean Herbert · 2025-05-28 12:14:27 +02:00
  dca839211c
• SongSelectV2: Add back basic random selection support

  This is a minimal implementation in order to keep moving forward.
  
  For simplicity I've copied over the old implementation verbatim. Note
  that this is beatmap*set* based randomisation, which means that when
  panels are split up by difficulty, it is still randomising by set (with
  the difficulty choice being left up to the user recommendation system).
  I think this is what we want, but if it isn't, any changes can come
  later.

  Dean Herbert · 2025-05-28 16:54:11 +09:00
  1b56ce9a39