18 Commits

• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Remove unnecessary null casts
  Dean Herbert · 2022-06-24 14:50:11 +09:00
  f71f6302fd
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Reword & clarify comments
  Bartłomiej Dach · 2021-05-04 22:59:10 +02:00
  f7d9fb094e
• Simplify test case further
  Bartłomiej Dach · 2021-05-04 22:48:57 +02:00
  9734758237
• Use LINQ select for data assigning for simplicity

  To avoid having to read through all of frames and ensure nothing is failing there

  Salman Ahmed · 2021-05-04 23:41:50 +03:00
  45c0b74151
• Avoid randomizing and overestimating logic with simple hardcoding

  Not sure what was in my mind while I was pushing that..

  Salman Ahmed · 2021-05-04 23:36:50 +03:00
  4ceb9b1562
• Add test coverage
  Salman Ahmed · 2021-05-04 09:45:59 +03:00
  e00af3e71d
• Partially revert the changes of CurrentFrame and NextFrame for compatibility

  Making those always non-null is postponed as when a replay's frame contains keypress the behavior is changed.
  Previously, the key is pressed at the time of the first frame. But using non-null frames means the key is pressed at negative infinity.
  However, I think the new way of always using non-null frames makes the client code so I plan to bundle the change to more breaking changes.

  ekrctb · 2021-04-13 15:55:23 +09:00
  57ba7b7cbb
• Rename property
  ekrctb · 2021-04-12 18:50:25 +09:00
  359fae895f
• Add more FramedReplayInputHandler tests
  ekrctb · 2021-04-12 16:18:35 +09:00
  3c28c09ab5
• Rewrite FramedReplayInputHandler for robustness

  This commit changes the semantics of `CurrentFrame` and `NextFrame` of the class.
  The ordering of `NextFrame.Time` and `CurrentFrame.Time` was dependent on the current direction.
  Now, it should always satisfy `CurrentFrame.Time <= CurrentTime <= NextFrame.Time` except at the start/end.
  This change, however, doesn't break existing deriving classes if the template code pattern usage of interpolation is used.
  The deriving class code can be simplified due to the elimination of nullable types. I didn't include those changes in this commit.
  
  I removed `StreamingFramedReplayInputHandlerTest` for now, as it is almost-duplicate of `FramedReplayInputHandlerTest`. I'll include more tests in later commits.
  
  This commit fixes #6150.

  ekrctb · 2021-04-12 16:18:11 +09:00
  e19e8ff2a3
• Add spaces to comments
  alex · 2020-05-04 18:36:24 -07:00
  0e2ccac33b
• Apply brace style.
  Huo Yaoyuan · 2019-11-11 20:13:13 +08:00
  ccc8aa6fa4
• Enforce frame accuracy for tests
  Dean Herbert · 2019-07-10 11:53:34 +09:00
  5e2adf59be
• Ensure tests cannot run forever
  Dean Herbert · 2019-07-10 11:52:55 +09:00
  bd53a96507
• Fix test class filename case
  Dean Herbert · 2019-07-10 11:42:30 +09:00
  2a3601e43b