266 Commits

• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Fix another missing disposal

  This one probably doesn't matter as much because it's used as a single
  instance in `TaikoPlayfield` (so its lifetime should end around the same
  time as the `HealthProcessor`).

  Dan Balasescu · 2025-04-10 16:09:47 +09:00
  d0dddcde78
• Fix progressively worsening performance on taiko argon skin
  Dan Balasescu · 2025-04-10 15:53:14 +09:00
  92c0b3cae2
• Fix taiko legacy skins playing scale animations even when skins contain animations

  Closes https://github.com/ppy/osu/issues/32477.
  
  Can be tested using
  https://drive.google.com/drive/folders/1HUCsTL_iqCGPCyruSSfdSoxL19EQuy_a.

  Dean Herbert · 2025-03-24 16:14:32 +09:00
  bb998ad687
• Fix clear sample potentially playing multiple times simultaneously
  Bartłomiej Dach · 2025-02-12 13:25:46 +01:00
  d87a775e71
• Add missing animation of warning sprite
  Bartłomiej Dach · 2025-02-12 13:25:46 +01:00
  e385848edc
• Fix transforms from swell progress being cleared on completion by not using transforms
  Bartłomiej Dach · 2025-02-12 13:25:42 +01:00
  0ac08158e3
• Adjust things further
  Bartłomiej Dach · 2025-02-12 13:20:04 +01:00
  96db6964df
• Adjust things to be closer to stable (but not close enough yet)
  Bartłomiej Dach · 2025-02-11 15:29:53 +01:00
  231988bc9d
• Fix remaining hit counter scaling in the incorrect direction
  Bartłomiej Dach · 2025-02-11 14:01:32 +01:00
  be035538c2
• code cleanup
  Nathan Du · 2025-02-04 17:48:44 +08:00
  ccc446a8ca
• further adjust swell behavior

  The outstanding visual issues of the clear animation is fixed. The
  HandleUserInput state management is removed as it no longer seems
  necessary.

  Nathan Du · 2025-02-01 13:34:52 +08:00
  e794389fe8
• fix code style
  Nathan Du · 2025-01-31 20:48:29 +08:00
  a62a84a30f
• change legacy spinner animations to match stable

  Also removed a few fallbacks pointed out in code review that I don't
  understand.

  Nathan Du · 2025-01-31 20:16:28 +08:00
  ac17b4065f
• remove spinner-osu.png workaround

  https://github.com/ppy/osu/issues/22084

  Nathan Du · 2025-01-31 18:52:19 +08:00
  ad2b469b14
• remove ISkinnableSwell

  This commit removes ISkinnableSwell for taiko swell animations. In place
  of it, an event named UpdateHitProgress is added to DrawableSwell, and
  the skin swells are converted to listen to said event and
  ApplyCustomUpdateState, like how spinner skinning is implemented for
  std.

  Nathan Du · 2025-01-31 18:10:50 +08:00
  2a5540b392
• Merge taiko swell components

  Per <https://github.com/ppy/osu/pull/21601/files#r1064167756>, taking a
  variation of the "Make all swell main pieces implement
  ISkinnableSwellPart" path. Should clean the interface up enough for
  further refactors.

  Nathan Du · 2025-01-31 16:55:39 +08:00
  4fd8a4dc5a
• Rename methods and skin component + add comments
  Joppe27 · 2025-01-31 10:24:45 +08:00
  e2196e8b9b
• Add legacy taiko swell
  Joppe27 · 2025-01-31 10:24:45 +08:00
  4a164b7b14
• Fix drum roll editor blueprint size & input handling
  Bartłomiej Dach · 2024-11-05 13:12:01 +01:00
  5668c62446
• Fix argon volume-aware hitsounds not correctly playing immediately after object placement

  Closes https://github.com/ppy/osu/issues/29832.
  
  The underlying reason for the incorrect sample playback was an equality
  comparer failure.
  
  Samples are contained in several pools which are managed by the
  playfield. In particular, the pools are keyed by `ISampleInfo`
  instances. This means that for correct operation, `ISampleInfo` has to
  implement `IEquatable<ISampleInfo>` and also provide an appropriately
  correct `GetHashCode()` implementation. Different audible samples must
  not compare equal to each other when represented by `ISampleInfo`.
  
  As it turns out, `VolumeAwareHitSampleInfo` failed on this, due to not
  overriding equality members. Therefore, a `new
  HitSampleInfo(HitSampleInfo.HIT_NORMAL, HitSampleInfo.BANK_NORMAL,
  volume: 70)` was allowed to compare equal to a
  `VolumeAwareHitSampleInfo` wrapping it, *even though they correspond to
  completely different sounds and go through entirely different lookup
  path sequences*.
  
  Therefore, to fix, provide more proper equality implementations for
  `VolumeAwareHitSampleInfo`.
  
  When testing note that this issue *only occurs immediately after
  placing an object*. Saving and re-entering editor makes this issue go
  away. I haven't looked too long into why, but the general gist of it is
  ordering; it appears that a `normal-hitnormal` pool exists at point
  of query of a new object placement, but does not seem to exist when
  entering editor afresh. That said I'm not sure that ordering aspect of
  this bug matters much if at all, since the two `IHitSampleInfo`s should
  never be allowed to alias with each other at all wrt equality.

  Bartłomiej Dach · 2024-09-23 13:38:26 +02:00
  e8a394f894
• Rename GameplaySkinComponentLookup -> SkinComponentLookup
  Dean Herbert · 2024-08-22 18:46:03 +09:00
  36b4013fa6
• Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer

  This didn't make any sense, so let's do it a better way.

  Dean Herbert · 2024-08-08 16:29:54 +09:00
  60d383448f
• Merge branch 'master' into ruleset-specific-combo-counter
  Bartłomiej Dach · 2024-06-04 15:44:11 +02:00
  5fcea01c13
• Share scale factor with hit target
  Dean Herbert · 2024-05-27 14:20:28 +09:00
  0d6adf160b
• Correct scale of taiko-glow element
  Joppe27 · 2024-05-25 23:28:51 +02:00
  76f13b21da
• Merge pull request #26703 from peppy/smaller-slider-misses

  Adjust slider tick / end defaults again

  Bartłomiej Dach · 2024-01-29 13:51:07 +01:00
  2667cb8b36
• Merge branch 'master' into constant-taiko-input-drum-width
  Dean Herbert · 2024-01-26 17:18:26 +09:00
  b84457fd15
• Merge pull request #26631 from frenzibyte/refactor-taiko-playfield-layout

  Rewrite osu!taiko playfield adjustment container to keep playfield height constant

  Dean Herbert · 2024-01-26 17:17:49 +09:00
  e78f0bc89b
• Simplify TaikoLegacyHitTarget container hierarchy
  Dean Herbert · 2024-01-25 21:02:22 +09:00
  5aa4235c3d
• Rename JudgementPiece to TextJudgementPiece
  Dean Herbert · 2024-01-25 19:31:57 +09:00
  dda96d7106
• Define constant input drum width for osu!taiko
  Salman Ahmed · 2024-01-20 01:46:15 +03:00
  d4fef99e1f
• Update remaining usages of playfield height
  Salman Ahmed · 2024-01-20 01:45:39 +03:00
  0c03326eaf
• Rename DEFAULT_HEIGHT to BASE_HEIGHT
  Salman Ahmed · 2024-01-19 23:58:58 +03:00
  ce4fd6aca5
• apply proposed changes
  mouzedrift · 2024-01-18 08:22:26 +01:00
  cbfc6091af
• ease out input drum animation and add delay before fading out
  mouzedrift · 2024-01-18 07:19:29 +01:00
  a870f99877
• Move combo counter to ruleset-specific HUD components target
  Salman Ahmed · 2023-12-30 03:47:52 +03:00
  eedb436389
• Merge pull request #25190 from frenzibyte/match-skin-element-animation-support

  Match capability of animating legacy skin elements with osu!(stable)

  Dean Herbert · 2023-10-30 18:25:06 +09:00
  fbba3787d1
• Apply same changes to "argon" osu!taiko barline design that were applied to osu!mania
  Dean Herbert · 2023-10-25 14:20:43 +09:00
  2886d2d4c2
• Fix incorrect assumption in taiko circle piece logic
  Salman Ahmed · 2023-10-24 02:29:46 +03:00
  bcbb77d383
• Refactor osu!taiko circle piece logic to read better
  Salman Ahmed · 2023-10-21 00:22:34 +03:00
  ab3b51e4a0
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Adjust gameplay element maximum size limits for backwards compatibility

  The new limits were chosen by sampling across over 4000 skins. The
  methodology for doing so is described in the following gist:
  
  	https://gist.github.com/bdach/6228ba41d128b23d1f89142f404108a3

  Bartłomiej Dach · 2023-10-05 20:37:10 +02:00
  0ae4a0f11f
• Revert redundant size limitations

  Already handled by the sprites themselves being resized.

  Salman Ahmed · 2023-09-21 19:03:59 +03:00
  ad86bf2d56
• Change extension from retrieval to post-processing instead
  Salman Ahmed · 2023-09-19 03:40:30 +03:00
  291a91be66
• Add size limitations for taiko drum rolls
  Dean Herbert · 2023-09-05 18:01:19 +09:00
  9d17539778
• Add limit to taiko hit elements
  Salman Ahmed · 2023-09-03 02:22:58 +03:00
  d286816ba8
• Fix flourish sample not playing if strong hits are hit early
  Bartłomiej Dach · 2023-07-08 19:22:32 +02:00
  ba0cd7a3f2
• Merge branch 'master' into taiko-hitsounding-final-attempt
  Bartłomiej Dach · 2023-07-08 18:10:04 +02:00
  055e4a78f0
• Implement flourish trigger source via base class
  Dean Herbert · 2023-07-07 14:54:49 +09:00
  755b82a308