12 Commits

• Store tracking history to slider judgement result instead
  Bartłomiej Dach · 2024-02-29 12:11:50 +01:00
  876b806423
• Reset slider input manager state completely on new object application

  Kind of scary this wasn't happening already.
  
  Mirrors `SpinnerRotationTracker`.

  Bartłomiej Dach · 2024-02-29 11:59:19 +01:00
  1d1db951f0
• Fix slider tracking state not restoring correctly in all cases on rewind
  Bartłomiej Dach · 2024-02-29 11:59:15 +01:00
  d05b31933f
• Reduce allocation overheads in SliderInputManager
  Dean Herbert · 2024-01-26 17:49:20 +09:00
  b6fa50c312
• Fix relax mod not considering full follow area radius when automatically holding sliders

  Closes https://github.com/ppy/osu/issues/25947.
  
  Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
  `DrawableSliderBall`.
  
  I would have liked to include tests, but relax mod is a bit untestable,
  because it disengages completely in the presence of a replay:
  
  	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs#L49-L58
  
  Additionally, `RulesetInputManager` disengages completely from parent
  inputs when there is a replay active:
  
  	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game/Rulesets/UI/RulesetInputManager.cs#L116
  
  which means there is really no easy way to control positional input
  while still having relax logic work. So I'm hoping the fix could be
  considered obvious enough to not require test coverage.

  Bartłomiej Dach · 2023-12-22 12:50:42 +01:00
  7e557152fb
• Require slider head to be judged before ticks
  Dan Balasescu · 2023-12-17 21:26:48 +09:00
  2b33aec124
• Fix 1-frame issues due to referencing external value
  Dan Balasescu · 2023-12-17 20:19:25 +09:00
  fddfa33e49
• Only track if in slider ball after any ticks missed
  Dan Balasescu · 2023-12-17 20:12:02 +09:00
  9b02bd712b
• Fix tail being missed too early
  Dan Balasescu · 2023-12-17 20:11:15 +09:00
  fbe48d7be8
• Only hit passed-through ticks if none were missed
  Dan Balasescu · 2023-12-17 19:57:48 +09:00
  f77884b62f
• Use the cursor position to test nested object validity
  Dan Balasescu · 2023-12-15 17:05:14 +09:00
  12210017e4
• Refactor all slider input into SliderInputManager
  Dan Balasescu · 2023-12-15 16:13:32 +09:00
  6bd190c55d