1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 19:22:54 +08:00
Commit Graph

56391 Commits

Author SHA1 Message Date
Salman Ahmed
0148f25171
Merge pull request #20848 from peppy/fix-settings-volume-sliders-double-samples
Fix adjusting volume via settings playing tick samples twice
2022-10-21 22:07:16 +03:00
Salman Ahmed
678bfb2caa Ban char.ToLower()/char.ToUpper() as well for better safety 2022-10-21 20:56:34 +03:00
Dean Herbert
c1ed775deb Update framework 2022-10-21 23:36:16 +09:00
Dean Herbert
bace3df4ca Update test assertions in line with change 2022-10-21 22:58:10 +09:00
Dean Herbert
7dc03097ff Change distance snap to never account for slider velocity
This is a nuanced detail that was implemented incorrectly from the
outset. When mapping, generally a mapper chooses the distance spacing
with no regard to the SV. It has always been common to have a lower
or higher distance spacing than SV, but with the way the lazer editor
has worked, the SV was multiplied into the distance snap grid display,
incorectly changing its spacing depending on the "reference object"
(which is usually the previous hitobject chronologically).
2022-10-21 21:51:24 +09:00
Dean Herbert
447d420c99 Fix adjusting volume via settings playing tick samples twice 2022-10-21 21:03:39 +09:00
Dean Herbert
4803f606c2
Merge pull request #20845 from nekodex/settings-sidebar-sfx
Add unique hover/select samples to settings sidebar buttons
2022-10-21 20:56:58 +09:00
Dean Herbert
8b74b5807f Update resources 2022-10-21 20:53:37 +09:00
Dan Balasescu
bbdeec1630
Merge pull request #20846 from peppy/reduce-solo-scores-legacy-serialisation
Avoid serialising some more properties of `SoloScoreInfo` unless present
2022-10-21 20:38:49 +09:00
Dean Herbert
bcd65f3c3c
Merge pull request #20827 from goodtrailer/smoke-uncapped-v3
Remove smoke point maximum
2022-10-21 19:58:49 +09:00
Dean Herbert
af84f708b7 Avoid serialising some more properties of SoloScoreInfo unless present 2022-10-21 19:30:35 +09:00
Jamie Taylor
7b1edff2b3
Add unique hover/select samples to settings sidebar buttons 2022-10-21 18:06:38 +09:00
Alden Wu
23b7b9013e Change smoke quadbatch growth factor to 2 from 1.5 2022-10-20 23:37:05 -07:00
Dean Herbert
d441e98af7 Adjust kiai flash period in line with stable 2022-10-21 15:34:25 +09:00
Dan Balasescu
703a8afb11
Merge pull request #20809 from peppy/fix-taiko-broken-drum-roll-ticks
Fix taiko drum roll ticks sometimes overflowing outside the drum roll itself
2022-10-21 12:56:14 +09:00
Dean Herbert
7dbd6e2469
Merge branch 'master' into taiko-kiai-flashing 2022-10-21 12:48:35 +09:00
Dean Herbert
39099e293d
Merge pull request #20840 from Joehuu/fix-skin-toolbox-component-button
Fix skin toolbox component button not playing hover/click sounds
2022-10-21 10:03:18 +09:00
Joseph Madamba
bf4a91f1f0 Fix skin toolbox component button not playing hover/click sounds 2022-10-20 13:16:03 -07:00
Dean Herbert
5c13c443ff Fix incorrect fallback logic
Regressed when attempting to share implementation of binary search.
2022-10-20 23:08:44 +09:00
Dean Herbert
26860a903e Refactor implementation to support hitobjects nested multiple levels deep 2022-10-20 22:30:30 +09:00
cdwcgt
42bb9dc3e3
revert EndPlacement change 2022-10-20 22:17:26 +09:00
Dean Herbert
a754dc6d3b
Expose binary search methods publicly
Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
2022-10-20 14:34:07 +09:00
Dan Balasescu
e577a87618
Merge pull request #20825 from peppy/fix-argon-editor-combo-colour-change
Fix some argon circle layers not getting correct colour updates in editor
2022-10-20 12:56:34 +09:00
Dan Balasescu
fd7274095f
Merge pull request #20826 from peppy/fix-missing-beatmap-backgrounds
Fix some older beatmaps having missing backgrounds
2022-10-20 12:46:24 +09:00
Dean Herbert
cc311eef2a
Merge pull request #20834 from frenzibyte/fix-slider-ball-tint
Enable slider ball tint on "classic" skin
2022-10-20 12:34:45 +09:00
Dean Herbert
6b26547d03
Merge pull request #20835 from frenzibyte/improve-hide-mouse-on-keyboard
Improve automatic cursor hiding logic and limit to gameplay screen
2022-10-20 11:44:20 +09:00
Dean Herbert
a5fdd461ed
Merge pull request #20763 from smoogipoo/remove-current-item
Add ability to remove the current item in multiplayer
2022-10-20 11:00:24 +09:00
Salman Ahmed
212f15e2d2 Update existing test cases 2022-10-20 04:06:33 +03:00
Dean Herbert
2f8a4fd2d0
Merge branch 'master' into remove-current-item 2022-10-20 10:02:09 +09:00
Salman Ahmed
f444bb9ba6 Update existing test case 2022-10-20 03:55:53 +03:00
Salman Ahmed
7d31eaea54 Move ball tinting logic to overwrite SliderBall colour 2022-10-20 03:55:53 +03:00
Dean Herbert
77b25c4a5c
Merge pull request #20788 from frenzibyte/handle-submitting-player-request-timeout
Fix potential exception in `SubmittingPlayer` token retrieval on request timeout
2022-10-20 09:51:57 +09:00
Salman Ahmed
39650717ea Improve input detection to not make cursor flicker on combined input 2022-10-20 03:45:25 +03:00
Salman Ahmed
4bf4938b72 Keep cursor hiding feature to gameplay screens for now 2022-10-20 03:44:58 +03:00
Salman Ahmed
eb386d4bd5 Enable slider ball tint in default legacy skin 2022-10-20 03:29:25 +03:00
Dean Herbert
a7d4a74ed6
Update osu.Game/Tests/Visual/ScrollingTestContainer.cs
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-20 08:07:56 +09:00
Dean Herbert
78943a21d8
Update osu.Game/Beatmaps/ControlPoints/IControlPoint.cs
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2022-10-20 08:06:05 +09:00
Salman Ahmed
ba37daa456 Bring back removed newline 2022-10-20 01:18:10 +03:00
Salman Ahmed
1852714d2d Fix existing alpha transform cleared on accent colour change
Clearing it causes its start value to be lost.
2022-10-20 01:16:27 +03:00
Joppe27
d83c398b58 Apply review: changed DelayUntilTransformsFinished to ArmedState check 2022-10-19 23:31:23 +02:00
Dean Herbert
59e2478b0e Fix some older beatmaps having missing backgrounds
Closes https://github.com/ppy/osu/issues/20824.

Note that this will require a reimport of beatmaps as it is baked into the database. Probably not worth making a migration for at this point in time.
2022-10-19 16:01:10 +09:00
Dean Herbert
aca0d04834 Forcefully remove transforms before reapplying to avoid old accent colour getting rewound 2022-10-19 15:52:25 +09:00
Dean Herbert
9356a40a39 Remove redundant flash layer colour logic
In a previous iteration, the flash layer was white on the initial hit,
but this seems to have been removed for the final implementation.
2022-10-19 15:13:22 +09:00
Alden Wu
50ab9bff8b Rename for consistency 2022-10-18 23:05:09 -07:00
Alden Wu
a9b8ba94fa Add necessary newlines 2022-10-18 22:59:58 -07:00
Alden Wu
343c560b1b Remove smoke point maximum/cap 2022-10-18 22:54:17 -07:00
Dan Balasescu
31f499a950
Merge pull request #20740 from peppy/player-loader-improvements
Improve transition visuals of player load sequence
2022-10-19 13:12:49 +09:00
Dean Herbert
16c86b0744
Merge pull request #20815 from frenzibyte/remove-hitcircle-fade-easing
Remove fade easing from legacy hit circles to match stable
2022-10-19 12:08:45 +09:00
Dean Herbert
299131c985
Merge pull request #20816 from frenzibyte/adjust-slider-fade-parameters
Adjust slider fade out transition to match stable
2022-10-19 12:04:24 +09:00
Dean Herbert
b5a7a112e5
Merge pull request #20817 from frenzibyte/adjust-spinner-fade-parameters
Adjust spinner fade transitions to match stable
2022-10-19 11:58:17 +09:00