25 Commits

• Use larger offset to ensure depth is still backmost even with DepthLayer is in use
  Dean Herbert · 2025-05-16 19:08:54 +09:00
  bfc23c98f1
• Avoid animating list tail

  At very high scroll speeds (using pageup/pagedown) you would see a weird
  animation of panels appearing. This removes the animation for that edge
  case.

  Dean Herbert · 2025-05-16 17:45:32 +09:00
  a32da2ea10
• Add new panels to carousel with a better initial Y position

  Previously, carousel panels would appear immediately at their required Y
  position. This didn't look great when they appear with other panels
  surrounding them.
  
  Now they will spawn in underneath the nearest item before them, making
  the animation feel much more correct.

  Dean Herbert · 2025-05-16 17:23:08 +09:00
  615d4accfb
• Add fade animation when carousel panels are expired

  This fixes the hard cut that was previously very jarring.

  Dean Herbert · 2025-05-16 17:21:49 +09:00
  6a2337dbea
• Fix depth flip-flopping during initial animation
  Dean Herbert · 2025-05-16 17:14:27 +09:00
  7efa724a8a
• Remove misplaced assert
  Dean Herbert · 2025-05-16 17:14:11 +09:00
  0302a37190
• Code quality fixes
  Dean Herbert · 2025-05-15 12:14:54 +03:00
  bb8d3bcf66
• Allow starting beatmap with autoplay via ctrl-enter
  Salman Alshamrani · 2025-05-15 17:01:23 +09:00
  8e7c093476
• Make carousel handle pressing enter with modifier keys
  Salman Alshamrani · 2025-05-15 16:54:14 +09:00
  87c97ad0b5
• Merge branch 'master' into full-sorting-support
  Bartłomiej Dach · 2025-05-14 14:42:29 +02:00
  a57ca72ccf
• Allow tests to accedss CarouselItems post filter operation
  Dean Herbert · 2025-05-14 19:21:57 +09:00
  8e15af2b2d
• Fix new (beatmap) carousel not correctly accounting for user scroll overrides

  The new carousel implementation was lacking some scroll related
  behaviours. This makes sure that post-filter, the selection is
  re-centered *unless* the user has scrolled away manually.
  
  This matches the old carousel's behaviour. See
  https://github.com/ppy/osu/pull/16647 for original implementation.
  
  Closes https://github.com/ppy/osu/issues/33052.

  Dean Herbert · 2025-05-14 17:32:44 +09:00
  a8d8d2d84c
• Fix exceptions being hidden by async task usage
  Dean Herbert · 2025-05-13 17:43:57 +09:00
  36317bc459
• Expose a way of knowing when carousel's displayed items are updated
  Dean Herbert · 2025-05-09 14:49:38 +09:00
  a957f41ffc
• Merge pull request #33039 from frenzibyte/song-select-filter-support

  Hook up filter control with beatmap carousel

  Dean Herbert · 2025-05-07 19:28:24 +09:00
  724176458f
• Change ICarouselFilter interface return type rather than manual ToList

  I was hung up on keeping `IEnumerable` but there doesn't seem to be a
  good reason to do so.

  Dean Herbert · 2025-05-07 16:40:23 +09:00
  ebd6776898
• Ensure carousel filters are manifested to lists at each step

  The original `IEnumerable` flow prioritised slight performance gains,
  but a filter's implementation could actually make this detrimental to
  overall performance.
  
  I noticed in passing that there were already potentially multiple
  enumerations, via `updateYPositions` and the final `ToList` call. Rather
  than faffing around, let's keep things simple and require lists.
  
  In benchmarking, the difference is (currently) negiligible. Slight
  improvement if anything.

  Dean Herbert · 2025-05-07 15:55:20 +09:00
  cc0c21a216
• Add test coverage for song select filtering
  Salman Alshamrani · 2025-05-07 09:17:54 +03:00
  d34e040b4e
• Ensure selection is retained over beatmap update
  Dean Herbert · 2025-04-22 21:01:56 +09:00
  615c7b29b5
• Change equality to allow non-reference comparisons

  This is required to hold selection when beatmaps are updates, as one
  important case.

  Dean Herbert · 2025-04-22 20:03:07 +09:00
  ac67473433
• Merge pull request #32839 from frenzibyte/song-select-v2-panel-metrics

  Use new font specifications in beatmap panels and apply minor adjustments

  Dean Herbert · 2025-04-22 16:35:11 +09:00
  3ba3f3ace7
• Add accounting of nested group items for group panel display purposes
  Dean Herbert · 2025-04-18 19:07:44 +09:00
  b80ea26475
• Update song select panel metrics in line with standard specifications and apply minor adjustments
  Salman Alshamrani · 2025-04-17 08:21:32 -04:00
  9e2a05a1fb
• Disable masking of Carousel

  The default for carousels should be unmasked as their usage generally
  sees them overflowing outside their main usage area (see `bleed`
  variables).

  Dean Herbert · 2025-04-16 19:41:49 +09:00
  376b4e8929
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5