86 Commits

• Cleanup mod bindings
  o-dasher · 2022-09-25 15:49:22 -04:00
  537796c3a1
• Fix target mod crashing if beatmap is played with a break after all hitobjects

  Closes https://github.com/ppy/osu/issues/20161.

  Dean Herbert · 2022-09-07 17:46:51 +09:00
  b5b66de3c9
• Fix typing of new setting to allow it to be visible to tools export
  Dean Herbert · 2022-08-31 22:34:07 +09:00
  6af8143c8c
• Add setting to toggle metronome in "Target" mod

  As mentioned in https://github.com/ppy/osu/discussions/20006#discussioncomment-3496732.

  Dean Herbert · 2022-08-29 17:12:10 +09:00
  780121eeee
• Change ruleset mod description types
  naoei · 2022-08-10 16:09:11 -04:00
  3e38baca3c
• Remove unnecessary AsNonNull()
  Dan Balasescu · 2022-08-01 13:22:58 +09:00
  415d6def2d
• Mark the property as non-nullable.
  andy840119 · 2022-07-31 21:43:16 +08:00
  632577389d
• Flip method parameters to make sense

  See https://github.com/ppy/osu/pull/19407/commits/537f64c75ecd9608b7f8f2b0e184dc18ba4bfa58#r931785228

  Salman Ahmed · 2022-07-28 08:04:55 +03:00
  72961ec336
• Make original hit objects and random properties as local variable.
  andy840119 · 2022-07-27 22:15:41 +08:00
  537f64c75e
• Mark the property as nullable and add some assert check.
  為什麼 · 2022-07-26 23:58:50 +08:00
  9134525111
• Mark the property as nullable or non-nullable.
  為什麼 · 2022-07-26 23:52:08 +08:00
  deb39bd330
• Remove nullable disable annotation in the Osu ruleset.
  為什麼 · 2022-07-26 23:25:28 +08:00
  e28584da89
• Convert == usages to ReferenceEquals
  Dan Balasescu · 2022-06-20 16:56:19 +09:00
  e0c82d11ab
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Move metronome into own class and rename to avoid conflict with mod sounds
  Dean Herbert · 2022-05-20 17:30:04 +09:00
  2e21d75b10
• Make Classic and Target compatible again
  Pasi4K5 · 2022-04-28 22:31:48 +02:00
  e31fdc28dd
• Append incompatible mods to base.IncompatibleMods
  Pasi4K5 · 2022-04-28 18:29:37 +02:00
  d5702e2955
• Add incompatibilities
  Pasi4K5 · 2022-04-28 05:15:04 +02:00
  d6395b14be
• Mark OsuModTarget and OsuModSuddenDeath as mutually exclusive

  `OsuModTarget` already fails on miss, so "Sudden Death" doesn't make
  sense to be enabled and may only cause issues.

  Salman Ahmed · 2022-04-26 23:27:03 +03:00
  fb6a112708
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Copy BaseDifficulty to Beatmap<T> and move all write operations across
  Dean Herbert · 2021-10-06 15:10:45 +09:00
  b339c149d8
• Convert usages of BeatmapDifficulty to IBeatmapDifficultyInfo
  Dean Herbert · 2021-10-01 16:55:50 +09:00
  a92d499d7a
• Rename MetronomeBeatContainer to Metronome
  Henry Lin · 2021-07-29 15:17:21 +08:00
  935984d200
• Remove unused constants
  Henry Lin · 2021-07-29 14:52:40 +08:00
  0196141335
• Extract metronome from OsuModTarget
  Henry Lin · 2021-07-29 14:52:18 +08:00
  18e760ee91
• Disallow mistimed event firing
  Henry Lin · 2021-07-20 10:31:19 +08:00
  1c6a13fca7
• Use BeatSyncClock
  Henry Lin · 2021-07-20 10:30:40 +08:00
  a387d8df74
• Code formatting fixes
  Henry Lin · 2021-07-18 22:01:26 +08:00
  fdebe4b94a
• Move approach circle hiding within BeginAbsoluteSequence
  Dean Herbert · 2021-07-18 22:34:28 +09:00
  49f0c707f6
• Fix metronome playing during intro time
  Dean Herbert · 2021-07-15 16:50:55 +09:00
  ea87869753
• Use a slightly more appropriate metronome sound
  Dean Herbert · 2021-07-15 16:43:24 +09:00
  c38590f1ff
• Adjust transform logic to hopefully be a bit easier to parse
  Dean Herbert · 2021-07-13 20:26:05 +09:00
  e7b78b1ea5
• Rename map to mapRange
  Henry Lin · 2021-07-04 10:01:56 +08:00
  d1862d8cff
• Use IHidesApproachCircles
  Henry Lin · 2021-07-03 13:02:39 +08:00
  1470bb1563
• Prevent multiple enumeration in checkForOverlap
  Henry Lin · 2021-07-01 12:49:34 +08:00
  b0a619bb4c
• Added definitelyBigger
  Henry Lin · 2021-07-01 12:21:41 +08:00
  34be437d7a
• Several requested changes

  - Rename `origHitObjects` to `originalHitObjects`
  - Use `Value` instead of `GetValueOrDefault()`
  - Remove `endObj`
  - Added comments
  - Rename `closestIdx` to `precedingIndex`
  - Changed an `almostEquals` call

  Henry Lin · 2021-07-01 11:57:57 +08:00
  58f80abe32
• Change seed control type in line with changes
  Bartłomiej Dach · 2021-06-30 20:41:08 +02:00
  913f7602e4
• Split part of addHitSamples to a subroutine
  Henry Lin · 2021-06-29 12:49:25 +08:00
  d4ff4b26f5
• Use IHasRepeats instead of IHasPathWithRepeats
  Henry Lin · 2021-06-28 11:33:19 +08:00
  ea8993d6d6
• Use OsuHitObjectGenerationUtils
  Henry Lin · 2021-06-26 11:34:10 +08:00
  3eaa04115f
• Increase acceptable difference for Precision calls
  Henry Lin · 2021-06-24 14:55:49 +08:00
  1a47bc254d
• Minor fixes in comments
  Henry Lin · 2021-06-24 13:39:50 +08:00
  be55c7e075
• Directly fade to gray instead of computing the color values
  Henry Lin · 2021-06-24 12:31:25 +08:00
  6629f8706a
• Added comments
  Henry Lin · 2021-06-24 12:20:46 +08:00
  877c775e35
• Refactor and rename isOverlappingWithRecent
  Henry Lin · 2021-06-24 12:02:48 +08:00
  f8fe4ab482
• Avoid using osuTK constants; Use MathF
  Henry Lin · 2021-06-24 11:37:00 +08:00
  71b5ed16c0
• Moved RNG initialisation to a better place
  Henry Lin · 2021-06-24 11:29:10 +08:00
  f74275a3b5
• Better explanation for fixComboInfo
  Henry Lin · 2021-06-24 11:21:43 +08:00
  6fca8ba5b0
• Moved a misplaced !
  Henry Lin · 2021-06-24 10:56:14 +08:00
  6202eed5e2