From a0aeccf2322d06c782c9fc15d5eda86d1b15df6b Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Thu, 5 Sep 2019 23:24:13 +0900
Subject: [PATCH 1/2] Fix fallback to default combo colours not working

---
 osu.Game/Skinning/DefaultSkin.cs | 19 ++++++++++++++++++-
 1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/osu.Game/Skinning/DefaultSkin.cs b/osu.Game/Skinning/DefaultSkin.cs
index 4dee70a47f..c0d6bb34e0 100644
--- a/osu.Game/Skinning/DefaultSkin.cs
+++ b/osu.Game/Skinning/DefaultSkin.cs
@@ -1,11 +1,13 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using System.Collections.Generic;
 using osu.Framework.Audio.Sample;
 using osu.Framework.Bindables;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Textures;
 using osu.Game.Audio;
+using osuTK.Graphics;
 
 namespace osu.Game.Skinning
 {
@@ -23,6 +25,21 @@ namespace osu.Game.Skinning
 
         public override SampleChannel GetSample(ISampleInfo sampleInfo) => null;
 
-        public override IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup) => null;
+        public override IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup)
+        {
+            switch (lookup)
+            {
+                case GlobalSkinConfiguration global:
+                    switch (global)
+                    {
+                        case GlobalSkinConfiguration.ComboColours:
+                            return SkinUtils.As<TValue>(new Bindable<List<Color4>>(Configuration.ComboColours));
+                    }
+
+                    break;
+            }
+
+            return null;
+        }
     }
 }

From f4f95197616cce29716fb31f1f36d3cb03bde0b2 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Fri, 6 Sep 2019 12:16:20 +0900
Subject: [PATCH 2/2] Add todo comment

---
 osu.Game/Skinning/DefaultSkin.cs | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/osu.Game/Skinning/DefaultSkin.cs b/osu.Game/Skinning/DefaultSkin.cs
index c0d6bb34e0..529c1afca5 100644
--- a/osu.Game/Skinning/DefaultSkin.cs
+++ b/osu.Game/Skinning/DefaultSkin.cs
@@ -29,6 +29,8 @@ namespace osu.Game.Skinning
         {
             switch (lookup)
             {
+                // todo: this code is pulled from LegacySkin and should not exist.
+                // will likely change based on how databased storage of skin configuration goes.
                 case GlobalSkinConfiguration global:
                     switch (global)
                     {