From fb4b681cc527c1b9430d2537e474d77f9035286c Mon Sep 17 00:00:00 2001
From: Terochi <mates.cernicky@gmail.com>
Date: Sun, 30 Apr 2023 16:36:01 +0200
Subject: [PATCH] Use `Queue` instead of `Stack`

---
 .../SkinEditor/SkinEditorChangeHandler.cs       | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/osu.Game/Overlays/SkinEditor/SkinEditorChangeHandler.cs b/osu.Game/Overlays/SkinEditor/SkinEditorChangeHandler.cs
index 8c7f7bbab7..18ffdb0edc 100644
--- a/osu.Game/Overlays/SkinEditor/SkinEditorChangeHandler.cs
+++ b/osu.Game/Overlays/SkinEditor/SkinEditorChangeHandler.cs
@@ -61,17 +61,16 @@ namespace osu.Game.Overlays.SkinEditor
             ISerialisableDrawable[] targetComponents = firstTarget.Components.ToArray();
 
             // Store components based on type for later lookup
-            var typedComponents = new Dictionary<Type, Stack<Drawable>>();
+            var typedComponents = new Dictionary<Type, Queue<Drawable>>();
 
-            for (int i = targetComponents.Length - 1; i >= 0; i--)
+            foreach (ISerialisableDrawable component in targetComponents)
             {
-                Drawable component = (Drawable)targetComponents[i];
                 Type lookup = component.GetType();
 
-                if (!typedComponents.TryGetValue(lookup, out Stack<Drawable>? typeComponents))
-                    typedComponents.Add(lookup, typeComponents = new Stack<Drawable>());
+                if (!typedComponents.TryGetValue(lookup, out Queue<Drawable>? typeComponents))
+                    typedComponents.Add(lookup, typeComponents = new Queue<Drawable>());
 
-                typeComponents.Push(component);
+                typeComponents.Enqueue((Drawable)component);
             }
 
             // Remove all components
@@ -82,13 +81,13 @@ namespace osu.Game.Overlays.SkinEditor
             {
                 Type lookup = skinnableInfo.Type;
 
-                if (!typedComponents.TryGetValue(lookup, out Stack<Drawable>? typeComponents))
+                if (!typedComponents.TryGetValue(lookup, out Queue<Drawable>? typeComponents))
                 {
                     firstTarget.Add((ISerialisableDrawable)skinnableInfo.CreateInstance());
                     continue;
                 }
 
-                if (typeComponents.TryPop(out Drawable? component))
+                if (typeComponents.TryDequeue(out Drawable? component))
                 {
                     // Re-use unused component
                     component.ApplySerialisedInfo(skinnableInfo);
@@ -102,7 +101,7 @@ namespace osu.Game.Overlays.SkinEditor
                 firstTarget.Add((ISerialisableDrawable)component);
             }
 
-            foreach ((Type _, Stack<Drawable> typeComponents) in typedComponents)
+            foreach ((Type _, Queue<Drawable> typeComponents) in typedComponents)
             {
                 // Dispose extra components
                 foreach (var component in typeComponents)