h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-26 17:02:57 +08:00
Code Issues Releases Wiki Activity

Merge pull request #24792 from bdach/fix-score-v1-multiplier-handling

Browse Source 
Fix Score V1 simulation in scoring test scene incorrectly applying multiplier
This commit is contained in:
Dean Herbert 2023-09-13 13:30:11 +09:00 committed by GitHub
commit f90f2491c3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game.Tests/Visual/Gameplay/TestSceneScoring.cs
View File

@ -190,7 +190,9 @@ namespace osu.Game.Tests.Visual.Gameplay
return;
}
const float score_multiplier = 1;
// this corresponds to stable's `ScoreMultiplier`.
// value is chosen arbitrarily, towards the upper range.
const float score_multiplier = 4;
totalScore += baseScore;
@ -208,13 +210,7 @@ namespace osu.Game.Tests.Visual.Gameplay
ApplyHit = () => applyHitV1(base_great),
ApplyNonPerfect = () => applyHitV1(base_ok),
ApplyMiss = () => applyHitV1(0),
GetTotalScore = () =>
{
// Arbitrary value chosen towards the upper range.
const double score_multiplier = 4;
return (int)(totalScore * score_multiplier);
},
GetTotalScore = () => totalScore,
Visible = scoreV1Visible
});
}