From f872343babd8ecc5285212d430abdef00be5664e Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Fri, 10 Jul 2020 18:35:20 +0900
Subject: [PATCH] Make Apply virtual to further simplify application process

---
 .../Objects/Drawables/DrawableOsuJudgement.cs         | 11 +++++++++++
 osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs              | 11 +----------
 osu.Game/Rulesets/Judgements/DrawableJudgement.cs     |  2 +-
 3 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs
index 9d0c406295..fa980c7581 100644
--- a/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs
+++ b/osu.Game.Rulesets.Osu/Objects/Drawables/DrawableOsuJudgement.cs
@@ -43,6 +43,17 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
             }
         }
 
+        public override void Apply(JudgementResult result, DrawableHitObject judgedObject)
+        {
+            base.Apply(result, judgedObject);
+
+            if (judgedObject?.HitObject is OsuHitObject osuObject)
+            {
+                Position = osuObject.StackedPosition;
+                Scale = new Vector2(osuObject.Scale);
+            }
+        }
+
         protected override void PrepareForUse()
         {
             base.PrepareForUse();
diff --git a/osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs b/osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs
index 291a572fdf..474e7c0f93 100644
--- a/osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs
+++ b/osu.Game.Rulesets.Osu/UI/OsuPlayfield.cs
@@ -107,16 +107,7 @@ namespace osu.Game.Rulesets.Osu.UI
             if (!judgedObject.DisplayResult || !DisplayJudgements.Value)
                 return;
 
-            var osuObject = (OsuHitObject)judgedObject.HitObject;
-
-            DrawableOsuJudgement explosion = poolDictionary[result.Type].Get(doj =>
-            {
-                doj.Apply(result, judgedObject);
-
-                // todo: move to JudgedObject property?
-                doj.Position = osuObject.StackedEndPosition;
-                doj.Scale = new Vector2(osuObject.Scale);
-            });
+            DrawableOsuJudgement explosion = poolDictionary[result.Type].Get(doj => doj.Apply(result, judgedObject));
 
             judgementLayer.Add(explosion);
         }
diff --git a/osu.Game/Rulesets/Judgements/DrawableJudgement.cs b/osu.Game/Rulesets/Judgements/DrawableJudgement.cs
index 1671e97db1..4e7f0018ef 100644
--- a/osu.Game/Rulesets/Judgements/DrawableJudgement.cs
+++ b/osu.Game/Rulesets/Judgements/DrawableJudgement.cs
@@ -75,7 +75,7 @@ namespace osu.Game.Rulesets.Judgements
             this.Delay(FadeOutDelay).FadeOut(400);
         }
 
-        public void Apply([NotNull] JudgementResult result, [CanBeNull] DrawableHitObject judgedObject)
+        public virtual void Apply([NotNull] JudgementResult result, [CanBeNull] DrawableHitObject judgedObject)
         {
             Result = result;
             JudgedObject = judgedObject;