From f7c5a3f506815eee95fc36e62fb88e411319f8ca Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Fri, 10 Dec 2021 18:32:32 +0900
Subject: [PATCH] Use similar method of consuming `OnlineID` as done in beatmap
 classes

---
 osu.Game/Database/OsuDbContext.cs |  2 +-
 osu.Game/Scoring/ScoreInfo.cs     | 16 +++++++++-------
 osu.Game/Screens/Play/Player.cs   |  2 +-
 3 files changed, 11 insertions(+), 9 deletions(-)

diff --git a/osu.Game/Database/OsuDbContext.cs b/osu.Game/Database/OsuDbContext.cs
index 13d362e0be..7cd9ae2885 100644
--- a/osu.Game/Database/OsuDbContext.cs
+++ b/osu.Game/Database/OsuDbContext.cs
@@ -147,7 +147,7 @@ namespace osu.Game.Database
 
             modelBuilder.Entity<BeatmapInfo>().HasOne(b => b.BaseDifficulty);
 
-            modelBuilder.Entity<ScoreInfo>().HasIndex(b => b.OnlineScoreID).IsUnique();
+            modelBuilder.Entity<ScoreInfo>().HasIndex(b => b.OnlineID).IsUnique();
         }
 
         private class OsuDbLoggerFactory : ILoggerFactory
diff --git a/osu.Game/Scoring/ScoreInfo.cs b/osu.Game/Scoring/ScoreInfo.cs
index 7c2d882f91..7acc7bd055 100644
--- a/osu.Game/Scoring/ScoreInfo.cs
+++ b/osu.Game/Scoring/ScoreInfo.cs
@@ -137,7 +137,14 @@ namespace osu.Game.Scoring
         [Column("Beatmap")]
         public BeatmapInfo BeatmapInfo { get; set; }
 
-        public long? OnlineScoreID { get; set; }
+        private long? onlineID;
+
+        [Column("OnlineScoreID")]
+        public long? OnlineID
+        {
+            get => onlineID;
+            set => onlineID = value > 0 ? value : null;
+        }
 
         public DateTimeOffset Date { get; set; }
 
@@ -243,12 +250,7 @@ namespace osu.Game.Scoring
 
         #region Implementation of IHasOnlineID
 
-        [NotMapped]
-        public long OnlineID
-        {
-            get => OnlineScoreID ?? -1;
-            set => OnlineScoreID = value;
-        }
+        long IHasOnlineID<long>.OnlineID => OnlineID ?? -1;
 
         #endregion
 
diff --git a/osu.Game/Screens/Play/Player.cs b/osu.Game/Screens/Play/Player.cs
index 521cf7d1e9..e2896c174f 100644
--- a/osu.Game/Screens/Play/Player.cs
+++ b/osu.Game/Screens/Play/Player.cs
@@ -1031,7 +1031,7 @@ namespace osu.Game.Screens.Play
             //
             // Until we better define the server-side logic behind this, let's not store the online ID to avoid potential unique constraint
             // conflicts across various systems (ie. solo and multiplayer).
-            long onlineScoreId = score.ScoreInfo.OnlineID;
+            long? onlineScoreId = score.ScoreInfo.OnlineID;
             score.ScoreInfo.OnlineID = -1;
 
             await scoreManager.Import(score.ScoreInfo, replayReader).ConfigureAwait(false);