From 6c4c2c1a6a8a9366223de441a1458689843fc1fb Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Thu, 14 Aug 2025 19:43:03 +0900 Subject: [PATCH 1/2] Fix tags popover search functionality not always working This is super haphazard in the first place but I'm going to look past that for now. Basically, due to the order of operation, the tags could be initialised via `updateTags()` before the perform search action was initialised, leading to clicks doing nothing. --- .../Screens/SelectV2/BeatmapMetadataWedge_MetadataDisplay.cs | 2 +- osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_MetadataDisplay.cs b/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_MetadataDisplay.cs index 606b5e6a8c..1c3cf8f8eb 100644 --- a/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_MetadataDisplay.cs +++ b/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_MetadataDisplay.cs @@ -165,8 +165,8 @@ namespace osu.Game.Screens.SelectV2 { clear(); - contentTags.Tags = tags; contentTags.PerformSearch = searchAction; + contentTags.Tags = tags; } private void setLoading() diff --git a/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs b/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs index aee7731f55..7c5f203cc8 100644 --- a/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs +++ b/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs @@ -135,7 +135,7 @@ namespace osu.Game.Screens.SelectV2 public float LineBaseHeight => text.LineBaseHeight; - public Action? PerformSearch { get; set; } + public Action? PerformSearch { get; init; } public TagsOverflowButton(string[] tags) { From 7a1cad73128b42dd5f285a25a2a59c04e59f07e8 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Thu, 14 Aug 2025 21:14:35 +0900 Subject: [PATCH 2/2] Also ensure that ordering doesn't matter --- osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs b/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs index 7c5f203cc8..e48b4f20da 100644 --- a/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs +++ b/osu.Game/Screens/SelectV2/BeatmapMetadataWedge_TagsLine.cs @@ -117,7 +117,7 @@ namespace osu.Game.Screens.SelectV2 Add(overflowButton = new TagsOverflowButton(tags) { Alpha = 0f, - PerformSearch = PerformSearch, + PerformSearch = s => PerformSearch?.Invoke(s), }); drawSizeLayout.Invalidate();