h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-09-21 20:07:25 +08:00
Code Issues Releases Wiki Activity

Autosave edited skin on change

Browse Source
This commit is contained in:
Bartłomiej Dach 2024-04-29 14:06:23 +02:00
parent fa3aeca09d
commit f78abf801c
No known key found for this signature in database
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
osu.Game/Overlays/SkinEditor/SkinEditor.cs
View File

@ -255,8 +255,11 @@ namespace osu.Game.Overlays.SkinEditor
// schedule ensures this only happens when the skin editor is visible. // schedule ensures this only happens when the skin editor is visible.
// also avoid some weird endless recursion / bindable feedback loop (something to do with tracking skins across three different bindable types). // also avoid some weird endless recursion / bindable feedback loop (something to do with tracking skins across three different bindable types).
// probably something which will be factored out in a future database refactor so not too concerning for now. // probably something which will be factored out in a future database refactor so not too concerning for now.
currentSkin.BindValueChanged(_ => currentSkin.BindValueChanged(val =>
{ {
if (val.OldValue != null && hasBegunMutating)
save(val.OldValue);
hasBegunMutating = false; hasBegunMutating = false;
Scheduler.AddOnce(skinChanged); Scheduler.AddOnce(skinChanged);
}, true); }, true);
@ -537,7 +540,9 @@ namespace osu.Game.Overlays.SkinEditor
protected void Redo() => changeHandler?.RestoreState(1); protected void Redo() => changeHandler?.RestoreState(1);
public void Save(bool userTriggered = true) public void Save(bool userTriggered = true) => save(currentSkin.Value);
private void save(Skin skin, bool userTriggered = true)
{ {
if (!hasBegunMutating) if (!hasBegunMutating)
return; return;
@ -551,11 +556,11 @@ namespace osu.Game.Overlays.SkinEditor
return; return;
foreach (var t in targetContainers) foreach (var t in targetContainers)
currentSkin.Value.UpdateDrawableTarget(t); skin.UpdateDrawableTarget(t);
// In the case the save was user triggered, always show the save message to make them feel confident. // In the case the save was user triggered, always show the save message to make them feel confident.
if (skins.Save(skins.CurrentSkin.Value) || userTriggered) if (skins.Save(skin) || userTriggered)
onScreenDisplay?.Display(new SkinEditorToast(ToastStrings.SkinSaved, currentSkin.Value.SkinInfo.ToString() ?? "Unknown")); onScreenDisplay?.Display(new SkinEditorToast(ToastStrings.SkinSaved, skin.SkinInfo.ToString() ?? "Unknown"));
} }
protected override bool OnHover(HoverEvent e) => true; protected override bool OnHover(HoverEvent e) => true;