h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-03-05 13:13:22 +08:00
Code Issues Releases Wiki Activity

Fix blocking overhead when calling WriteAsync

Browse Source
This commit is contained in:
Dean Herbert 2022-06-21 17:15:25 +09:00
parent 7d988da2c7
commit f74b4ac277
1 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
osu.Game/Database/RealmAccess.cs
View File

@ -385,11 +385,22 @@ namespace osu.Game.Database
/// Write changes to realm asynchronously, guaranteeing order of execution. /// Write changes to realm asynchronously, guaranteeing order of execution.
/// </summary> /// </summary>
/// <param name="action">The work to run.</param> /// <param name="action">The work to run.</param>
public async Task WriteAsync(Action<Realm> action) public Task WriteAsync(Action<Realm> action)
{ {
total_writes_async.Value++; // Regardless of calling Realm.GetInstance of Realm.GetInstanceAsync, there is a blocking overhead on retrieval.
using (var realm = getRealmInstance()) // Adding a forced Task.Run resolves this.
await realm.WriteAsync(() => action(realm));
return Task.Run(async () =>
{
total_writes_async.Value++;
// Not attempting to use Realm.GetInstanceAsync as there's seemingly no benefit to us (for now) and it adds complexity due to locking
// concerns in getRealmInstance(). On a quick check, it looks to be more suited to cases where realm is connecting to an online sync
// server, which we don't use. May want to report upstream or revisit in the future.
using (var realm = getRealmInstance())
// ReSharper disable once AccessToDisposedClosure (WriteAsync should be marked as [InstantHandle]).
await realm.WriteAsync(() => action(realm));
});
} }
/// <summary> /// <summary>