h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 04:52:57 +08:00
Code Issues Releases Wiki Activity

Fix TestAllSamplesStopDuringSeek test failure

Browse Source 
https://github.com/smoogipoo/osu/actions/runs/9986761756/job/27599851263

This is a bit of a workaround, likely timing related. I don't foresee an
until step in this case to cause false-passes.
This commit is contained in:
Dan Balasescu 2024-07-18 16:22:39 +09:00
parent 7bb680a8a4
commit f3cd3d7d3b
No known key found for this signature in database
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Tests/Visual/Gameplay/TestSceneGameplaySamplePlayback.cs
View File

@ -48,7 +48,7 @@ namespace osu.Game.Tests.Visual.Gameplay
return true; return true;
}); });
AddAssert("sample playback disabled", () => sampleDisabler.SamplePlaybackDisabled.Value); AddUntilStep("sample playback disabled", () => sampleDisabler.SamplePlaybackDisabled.Value);
// because we are in frame stable context, it's quite likely that not all samples are "played" at this point. // because we are in frame stable context, it's quite likely that not all samples are "played" at this point.
// the important thing is that at least one started, and that sample has since stopped. // the important thing is that at least one started, and that sample has since stopped.