h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-13 19:43:22 +08:00
Code Issues Releases Wiki Activity

Fix HitError Clear methods not correctly returning pooled drawables

Browse Source
This commit is contained in:
Dean Herbert 2023-12-13 16:13:23 +09:00
parent 110749205d
commit f2c6c348be
No known key found for this signature in database
2 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
osu.Game/Screens/Play/HUD/HitErrorMeters/BarHitErrorMeter.cs
View File

@ -485,7 +485,11 @@ namespace osu.Game.Screens.Play.HUD.HitErrorMeters
} }
} }
public override void Clear() => judgementsContainer.Clear(); public override void Clear()
{
foreach (var j in judgementsContainer)
j.FadeOut().Expire();
}
public enum CentreMarkerStyles public enum CentreMarkerStyles
{ {

6
osu.Game/Screens/Play/HUD/HitErrorMeters/ColourHitErrorMeter.cs
View File

@ -63,7 +63,11 @@ namespace osu.Game.Screens.Play.HUD.HitErrorMeters
judgementsFlow.Push(GetColourForHitResult(judgement.Type)); judgementsFlow.Push(GetColourForHitResult(judgement.Type));
} }
public override void Clear() => judgementsFlow.Clear(); public override void Clear()
{
foreach (var j in judgementsFlow)
j.FadeOut().Expire();
}
private partial class JudgementFlow : FillFlowContainer<HitErrorShape> private partial class JudgementFlow : FillFlowContainer<HitErrorShape>
{ {