h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 12:57:25 +08:00
Code Issues Releases Wiki Activity

Merge pull request #8007 from peppy/fix-hidden-ui-performance

Browse Source 
Fix stutter when showing game HUD after being hidden for a while
This commit is contained in:
Dan Balasescu 2020-02-26 21:33:53 +09:00 committed by GitHub
commit f1c97451d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 14 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Screens/Play/HUD/HealthDisplay.cs
View File

@ -13,12 +13,5 @@ namespace osu.Game.Screens.Play.HUD
MinValue = 0, MinValue = 0,
MaxValue = 1 MaxValue = 1
}; };
protected HealthDisplay()
{
Current.ValueChanged += health => SetHealth((float)health.NewValue);
}
protected abstract void SetHealth(float value);
} }
} }

15
osu.Game/Screens/Play/HUD/StandardHealthDisplay.cs
View File

@ -12,6 +12,7 @@ using osu.Game.Rulesets.Judgements;
using osuTK; using osuTK;
using osuTK.Graphics; using osuTK.Graphics;
using osu.Framework.Graphics.Shapes; using osu.Framework.Graphics.Shapes;
using osu.Framework.Utils;
using osu.Game.Rulesets.Scoring; using osu.Game.Rulesets.Scoring;
namespace osu.Game.Screens.Play.HUD namespace osu.Game.Screens.Play.HUD
@ -108,11 +109,23 @@ namespace osu.Game.Screens.Play.HUD
if (result.Type == HitResult.Miss) if (result.Type == HitResult.Miss)
return; return;
Scheduler.AddOnce(flash);
}
private void flash()
{
fill.FadeEdgeEffectTo(Math.Min(1, fill.EdgeEffect.Colour.Linear.A + (1f - base_glow_opacity) / glow_max_hits), 50, Easing.OutQuint) fill.FadeEdgeEffectTo(Math.Min(1, fill.EdgeEffect.Colour.Linear.A + (1f - base_glow_opacity) / glow_max_hits), 50, Easing.OutQuint)
.Delay(glow_fade_delay) .Delay(glow_fade_delay)
.FadeEdgeEffectTo(base_glow_opacity, glow_fade_time, Easing.OutQuint); .FadeEdgeEffectTo(base_glow_opacity, glow_fade_time, Easing.OutQuint);
} }
protected override void SetHealth(float value) => fill.ResizeTo(new Vector2(value, 1), 200, Easing.OutQuint); protected override void Update()
{
base.Update();
fill.Width = Interpolation.ValueAt(
Math.Clamp(Clock.ElapsedFrameTime, 0, 200),
fill.Width, (float)Current.Value, 0, 200, Easing.OutQuint);
}
} }
} }