mirror of
https://github.com/ppy/osu.git
synced 2025-01-29 01:22:54 +08:00
Improve nested scroll behaviour
This commit is contained in:
parent
23dad7bdc4
commit
f156cb797d
@ -151,9 +151,10 @@ namespace osu.Game.Overlays.Mods
|
|||||||
},
|
},
|
||||||
new Drawable[]
|
new Drawable[]
|
||||||
{
|
{
|
||||||
new OsuScrollContainer
|
new NestedVerticalScrollContainer
|
||||||
{
|
{
|
||||||
RelativeSizeAxes = Axes.Both,
|
RelativeSizeAxes = Axes.Both,
|
||||||
|
ClampExtension = 100,
|
||||||
ScrollbarOverlapsContent = false,
|
ScrollbarOverlapsContent = false,
|
||||||
Child = panelFlow = new FillFlowContainer<ModPanel>
|
Child = panelFlow = new FillFlowContainer<ModPanel>
|
||||||
{
|
{
|
||||||
@ -194,6 +195,63 @@ namespace osu.Game.Overlays.Mods
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/// <summary>
|
||||||
|
/// A scroll container that handles the case of vertically scrolling content inside a larger horizontally scrolling parent container.
|
||||||
|
/// </summary>
|
||||||
|
private class NestedVerticalScrollContainer : OsuScrollContainer
|
||||||
|
{
|
||||||
|
private OsuScrollContainer? parentScrollContainer;
|
||||||
|
|
||||||
|
protected override void LoadComplete()
|
||||||
|
{
|
||||||
|
base.LoadComplete();
|
||||||
|
|
||||||
|
parentScrollContainer = findClosestParent<OsuScrollContainer>();
|
||||||
|
}
|
||||||
|
|
||||||
|
protected override bool OnScroll(ScrollEvent e)
|
||||||
|
{
|
||||||
|
if (parentScrollContainer == null)
|
||||||
|
return base.OnScroll(e);
|
||||||
|
|
||||||
|
// If not on screen, handle scroll but also allow parent to scroll at the same time.
|
||||||
|
bool topRightOutsideOfView = parentScrollContainer.ScreenSpaceDrawQuad.Contains(ScreenSpaceDrawQuad.TopRight) == false;
|
||||||
|
bool bottomLeftOutsideOfView = parentScrollContainer.ScreenSpaceDrawQuad.Contains(ScreenSpaceDrawQuad.BottomLeft) == false;
|
||||||
|
|
||||||
|
if (topRightOutsideOfView || bottomLeftOutsideOfView)
|
||||||
|
{
|
||||||
|
base.OnScroll(e);
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
bool scrollingPastEnd = e.ScrollDelta.Y < 0 && IsScrolledToEnd();
|
||||||
|
bool scrollingPastStart = e.ScrollDelta.Y > 0 && Target <= 0;
|
||||||
|
|
||||||
|
// Same deal if at one of the two extents of the view.
|
||||||
|
if (scrollingPastStart || scrollingPastEnd)
|
||||||
|
{
|
||||||
|
base.OnScroll(e);
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
return base.OnScroll(e);
|
||||||
|
}
|
||||||
|
|
||||||
|
// TODO: remove when https://github.com/ppy/osu-framework/pull/5092 is available.
|
||||||
|
private T? findClosestParent<T>() where T : class, IDrawable
|
||||||
|
{
|
||||||
|
Drawable cursor = this;
|
||||||
|
|
||||||
|
while ((cursor = cursor.Parent) != null)
|
||||||
|
{
|
||||||
|
if (cursor is T match)
|
||||||
|
return match;
|
||||||
|
}
|
||||||
|
|
||||||
|
return default;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
private void createHeaderText()
|
private void createHeaderText()
|
||||||
{
|
{
|
||||||
IEnumerable<string> headerTextWords = ModType.Humanize(LetterCasing.Title).Split(' ');
|
IEnumerable<string> headerTextWords = ModType.Humanize(LetterCasing.Title).Split(' ');
|
||||||
|
@ -106,6 +106,7 @@ namespace osu.Game.Overlays.Mods
|
|||||||
{
|
{
|
||||||
RelativeSizeAxes = Axes.Both,
|
RelativeSizeAxes = Axes.Both,
|
||||||
Masking = false,
|
Masking = false,
|
||||||
|
ClampExtension = 100,
|
||||||
ScrollbarOverlapsContent = false,
|
ScrollbarOverlapsContent = false,
|
||||||
Child = columnFlow = new ModColumnContainer
|
Child = columnFlow = new ModColumnContainer
|
||||||
{
|
{
|
||||||
|
Loading…
Reference in New Issue
Block a user