h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-11-12 00:27:25 +08:00
Code Issues Releases Wiki Activity

Use Queue instead of List for stored Judgements

Browse Source
This commit is contained in:
Andrei Zavatski 2019-08-18 14:43:34 +03:00
parent 50133ba863
commit ee5568e596
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game/Screens/Play/HUD/HitErrorDisplay.cs
View File

@ -38,7 +38,7 @@ namespace osu.Game.Screens.Play.HUD
private readonly bool mirrored; private readonly bool mirrored;
private readonly SpriteIcon arrow; private readonly SpriteIcon arrow;
private readonly FillFlowContainer bar; private readonly FillFlowContainer bar;
private readonly List<double> judgementOffsets = new List<double>(); private readonly Queue<double> judgementOffsets = new Queue<double>();
public HitErrorDisplay(bool mirrored = false) public HitErrorDisplay(bool mirrored = false)
{ {
@ -117,7 +117,7 @@ namespace osu.Game.Screens.Play.HUD
judgementLine.FadeOut(10000, Easing.OutQuint); judgementLine.FadeOut(10000, Easing.OutQuint);
judgementLine.Expire(); judgementLine.Expire();
arrow.MoveToY(getRelativeJudgementPosition(calculateArrowPosition(newJudgement)), 500, Easing.OutQuint); arrow.MoveToY(calculateArrowPosition(newJudgement), 500, Easing.OutQuint);
} }
protected virtual Container CreateJudgementLine(JudgementResult judgement) => new CircularContainer protected virtual Container CreateJudgementLine(JudgementResult judgement) => new CircularContainer
@ -138,14 +138,14 @@ namespace osu.Game.Screens.Play.HUD
private float getRelativeJudgementPosition(double value) => (float)(value / HitWindows.Meh); private float getRelativeJudgementPosition(double value) => (float)(value / HitWindows.Meh);
private double calculateArrowPosition(JudgementResult newJudgement) private float calculateArrowPosition(JudgementResult newJudgement)
{ {
if (judgementOffsets.Count > stored_judgements_amount) if (judgementOffsets.Count > stored_judgements_amount)
judgementOffsets.RemoveAt(0); judgementOffsets.Dequeue();
judgementOffsets.Add(newJudgement.TimeOffset); judgementOffsets.Enqueue(newJudgement.TimeOffset);
return judgementOffsets.Average(); return getRelativeJudgementPosition(judgementOffsets.Average());
} }
} }
} }