From ee16c964dce4e3ecff95c6b8688c0673a2f5c2f5 Mon Sep 17 00:00:00 2001
From: smallketchup82 <ketchup@smallketchup.ca>
Date: Fri, 11 Oct 2024 14:06:43 -0400
Subject: [PATCH] Make everything translatable

---
 osu.Game/Localisation/EditorStrings.cs      | 10 ++++++++++
 osu.Game/Overlays/SkinEditor/SkinEditor.cs  |  6 +++---
 osu.Game/Screens/Edit/Editor.cs             |  2 +-
 osu.Game/Screens/Edit/ExternalEditScreen.cs |  3 ++-
 4 files changed, 16 insertions(+), 5 deletions(-)

diff --git a/osu.Game/Localisation/EditorStrings.cs b/osu.Game/Localisation/EditorStrings.cs
index bcffc18d4d..6aaab1f653 100644
--- a/osu.Game/Localisation/EditorStrings.cs
+++ b/osu.Game/Localisation/EditorStrings.cs
@@ -134,6 +134,16 @@ namespace osu.Game.Localisation
         /// </summary>
         public static LocalisableString TimelineShowTimingChanges => new TranslatableString(getKey(@"timeline_show_timing_changes"), @"Show timing changes");
 
+        /// <summary>
+        /// "Edit externally"
+        /// </summary>
+        public static LocalisableString EditExternally => new TranslatableString(getKey(@"edit_externally"), @"Edit externally");
+
+        /// <summary>
+        /// "Finish editing and import changes"
+        /// </summary>
+        public static LocalisableString FinishEditingExternally => new TranslatableString(getKey(@"Finish editing and import changes"), @"Finish editing and import changes");
+
         /// <summary>
         /// "Show ticks"
         /// </summary>
diff --git a/osu.Game/Overlays/SkinEditor/SkinEditor.cs b/osu.Game/Overlays/SkinEditor/SkinEditor.cs
index 56529de88d..ef76cd0378 100644
--- a/osu.Game/Overlays/SkinEditor/SkinEditor.cs
+++ b/osu.Game/Overlays/SkinEditor/SkinEditor.cs
@@ -164,7 +164,7 @@ namespace osu.Game.Overlays.SkinEditor
                                                     {
                                                         new EditorMenuItem(Web.CommonStrings.ButtonsSave, MenuItemType.Standard, () => Save()),
                                                         new EditorMenuItem(CommonStrings.Export, MenuItemType.Standard, () => skins.ExportCurrentSkin()) { Action = { Disabled = !RuntimeInfo.IsDesktop } },
-                                                        mountMenuItem = new EditorMenuItem("Edit externally", MenuItemType.Standard, () => _ = editExternally()) { Action = { Disabled = !RuntimeInfo.IsDesktop } },
+                                                        mountMenuItem = new EditorMenuItem(EditorStrings.EditExternally, MenuItemType.Standard, () => _ = editExternally()) { Action = { Disabled = !RuntimeInfo.IsDesktop } },
                                                         new OsuMenuItemSpacer(),
                                                         new EditorMenuItem(CommonStrings.RevertToDefault, MenuItemType.Destructive, () => dialogOverlay?.Push(new RevertConfirmDialog(revert))),
                                                         new OsuMenuItemSpacer(),
@@ -306,7 +306,7 @@ namespace osu.Game.Overlays.SkinEditor
             Schedule(() =>
             {
                 mountMenuItem.Action.Disabled = false;
-                mountMenuItem.Text.Value = "Finish external edit";
+                mountMenuItem.Text.Value = EditorStrings.FinishEditingExternally;
                 mountMenuItem.Action.Value = () => _ = finishExternalEdit();
             });
         }
@@ -332,7 +332,7 @@ namespace osu.Game.Overlays.SkinEditor
                 oldskin.Dispose();
 
                 mountMenuItem.Action.Disabled = false;
-                mountMenuItem.Text.Value = "Edit externally";
+                mountMenuItem.Text.Value = EditorStrings.EditExternally;
                 mountMenuItem.Action.Value = () => _ = editExternally();
             });
         }
diff --git a/osu.Game/Screens/Edit/Editor.cs b/osu.Game/Screens/Edit/Editor.cs
index e9bcd3050b..5a5716b056 100644
--- a/osu.Game/Screens/Edit/Editor.cs
+++ b/osu.Game/Screens/Edit/Editor.cs
@@ -1210,7 +1210,7 @@ namespace osu.Game.Screens.Edit
                 saveRelatedMenuItems.AddRange(export.Items);
                 yield return export;
 
-                var externalEdit = new EditorMenuItem("Edit externally", MenuItemType.Standard, editExternally);
+                var externalEdit = new EditorMenuItem(EditorStrings.EditExternally, MenuItemType.Standard, editExternally);
                 saveRelatedMenuItems.Add(externalEdit);
                 yield return externalEdit;
             }
diff --git a/osu.Game/Screens/Edit/ExternalEditScreen.cs b/osu.Game/Screens/Edit/ExternalEditScreen.cs
index 8a97e3dcb2..e906d74855 100644
--- a/osu.Game/Screens/Edit/ExternalEditScreen.cs
+++ b/osu.Game/Screens/Edit/ExternalEditScreen.cs
@@ -21,6 +21,7 @@ using osu.Game.Graphics.Containers;
 using osu.Game.Graphics.Sprites;
 using osu.Game.Graphics.UserInterface;
 using osu.Game.Graphics.UserInterfaceV2;
+using osu.Game.Localisation;
 using osu.Game.Online.Multiplayer;
 using osu.Game.Overlays;
 using osu.Game.Screens.OnlinePlay.Match.Components;
@@ -156,7 +157,7 @@ namespace osu.Game.Screens.Edit
                 },
                 new DangerousRoundedButton
                 {
-                    Text = "Finish editing and import changes",
+                    Text = EditorStrings.FinishEditingExternally,
                     Width = 350,
                     Anchor = Anchor.TopCentre,
                     Origin = Anchor.TopCentre,