1
0
mirror of https://github.com/ppy/osu.git synced 2025-03-06 05:53:11 +08:00

Remove IsActive property

as it never really made sense to have it in the first place
This commit is contained in:
Craftplacer 2020-01-22 10:47:51 +01:00
parent 73d4b6a6be
commit e4accb3344

View File

@ -38,11 +38,6 @@ namespace osu.Game.Online.Chat
private Bindable<bool> notifyOnChat; private Bindable<bool> notifyOnChat;
private Bindable<User> localUser; private Bindable<User> localUser;
/// <summary>
/// Determines if the user is able to see incoming messages.
/// </summary>
public bool IsActive => chatOverlay?.IsPresent == true;
private readonly List<PrivateMessageNotification> privateMessageNotifications = new List<PrivateMessageNotification>(); private readonly List<PrivateMessageNotification> privateMessageNotifications = new List<PrivateMessageNotification>();
[BackgroundDependencyLoader] [BackgroundDependencyLoader]
@ -93,7 +88,7 @@ namespace osu.Game.Online.Chat
public void HandleMessages(Channel channel, IEnumerable<Message> messages) public void HandleMessages(Channel channel, IEnumerable<Message> messages)
{ {
// Only send notifications, if ChatOverlay and the target channel aren't visible. // Only send notifications, if ChatOverlay and the target channel aren't visible.
if (IsActive && channelManager.CurrentChannel.Value == channel) if (chatOverlay?.IsPresent == true && channelManager.CurrentChannel.Value == channel)
return; return;
foreach (var message in messages.OrderByDescending(m => m.Id)) foreach (var message in messages.OrderByDescending(m => m.Id))