diff --git a/osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapEncoderTest.cs b/osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapEncoderTest.cs
index dee4626cd0..8d5060e2fe 100644
--- a/osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapEncoderTest.cs
+++ b/osu.Game.Tests/Beatmaps/Formats/LegacyBeatmapEncoderTest.cs
@@ -45,7 +45,7 @@ namespace osu.Game.Tests.Beatmaps.Formats
Assert.IsTrue(decoded.beatmapSkin.Configuration.Equals(decodedAfterEncode.beatmapSkin.Configuration));
}
- private void sort((IBeatmap beatmap, LegacyBeatmapSkin beatmapSkin) tuple)
+ private void sort((IBeatmap beatmap, IBeatmapSkin beatmapSkin) tuple)
{
// Sort control points to ensure a sane ordering, as they may be parsed in different orders. This works because each group contains only uniquely-typed control points.
foreach (var g in tuple.beatmap.ControlPointInfo.Groups)
@@ -77,7 +77,7 @@ namespace osu.Game.Tests.Beatmaps.Formats
}
}
- private Stream encodeToLegacy((IBeatmap beatmap, LegacyBeatmapSkin beatmapSkin) fullBeatmap)
+ private Stream encodeToLegacy((IBeatmap beatmap, IBeatmapSkin beatmapSkin) fullBeatmap)
{
var (beatmap, beatmapSkin) = fullBeatmap;
var stream = new MemoryStream();
diff --git a/osu.Game/Beatmaps/BeatmapManager.cs b/osu.Game/Beatmaps/BeatmapManager.cs
index 86d35749ac..89a776dd31 100644
--- a/osu.Game/Beatmaps/BeatmapManager.cs
+++ b/osu.Game/Beatmaps/BeatmapManager.cs
@@ -196,22 +196,14 @@ namespace osu.Game.Beatmaps
/// The to save the content against. The file referenced by will be replaced.
/// The content to write.
/// The beatmap content to write, or null if not to be changed.
- public void Save(BeatmapInfo info, IBeatmap beatmapContent, LegacyBeatmapSkin beatmapSkin = null)
+ public void Save(BeatmapInfo info, IBeatmap beatmapContent, IBeatmapSkin beatmapSkin = null)
{
var setInfo = QueryBeatmapSet(s => s.Beatmaps.Any(b => b.ID == info.ID));
using (var stream = new MemoryStream())
{
using (var sw = new StreamWriter(stream, Encoding.UTF8, 1024, true))
- {
- if (beatmapSkin == null)
- {
- var workingBeatmap = GetWorkingBeatmap(info);
- beatmapSkin = (workingBeatmap.Skin is LegacyBeatmapSkin legacy) ? legacy : null;
- }
-
new LegacyBeatmapEncoder(beatmapContent, beatmapSkin).Encode(sw);
- }
stream.Seek(0, SeekOrigin.Begin);
diff --git a/osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs b/osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs
index 497c3c88d0..543d960300 100644
--- a/osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs
+++ b/osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs
@@ -25,14 +25,14 @@ namespace osu.Game.Beatmaps.Formats
public const int LATEST_VERSION = 128;
private readonly IBeatmap beatmap;
- private readonly LegacyBeatmapSkin skin;
+ private readonly IBeatmapSkin skin;
///
/// Creates a new .
///
/// The beatmap to encode.
/// An optional skin, for encoding the beatmap's combo colours.
- public LegacyBeatmapEncoder(IBeatmap beatmap, [CanBeNull] LegacyBeatmapSkin skin)
+ public LegacyBeatmapEncoder(IBeatmap beatmap, [CanBeNull] IBeatmapSkin skin)
{
this.beatmap = beatmap;
this.skin = skin;
@@ -211,10 +211,7 @@ namespace osu.Game.Beatmaps.Formats
private void handleComboColours(TextWriter writer)
{
- if (!(skin is LegacyBeatmapSkin legacySkin))
- return;
-
- var colours = legacySkin.GetConfig>(GlobalSkinColours.ComboColours)?.Value;
+ var colours = skin.GetConfig>(GlobalSkinColours.ComboColours)?.Value;
if (colours == null || colours.Count == 0)
return;