h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-02-06 08:12:55 +08:00
Code Issues Releases Wiki Activity

compare metdata and remove duplicate from beatmap to prevent redundant storage

Browse Source
This commit is contained in:
Aergwyn 2017-11-23 19:46:58 +01:00
parent 0df5432f5e
commit e3a230320a
2 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Beatmaps/BeatmapManager.cs
View File

@ -515,6 +515,10 @@ namespace osu.Game.Beatmaps
if (existing == null) if (existing == null)
{ {
// Exclude beatmap-metadata if it's equal to beatmapset-metadata
if (metadata.Equals(beatmap.Metadata))
beatmap.BeatmapInfo.Metadata = null;
RulesetInfo ruleset = rulesets.GetRuleset(beatmap.BeatmapInfo.RulesetID); RulesetInfo ruleset = rulesets.GetRuleset(beatmap.BeatmapInfo.RulesetID);
// TODO: this should be done in a better place once we actually need to dynamically update it. // TODO: this should be done in a better place once we actually need to dynamically update it.

18
osu.Game/Beatmaps/BeatmapMetadata.cs
View File

@ -66,5 +66,23 @@ namespace osu.Game.Beatmaps
Source, Source,
Tags Tags
}.Where(s => !string.IsNullOrEmpty(s)).ToArray(); }.Where(s => !string.IsNullOrEmpty(s)).ToArray();
public override bool Equals(object other)
{
var otherMetadata = other as BeatmapMetadata;
if (otherMetadata == null) return false;
return (onlineBeatmapSetID?.Equals(otherMetadata.onlineBeatmapSetID) ?? false)
&& (Title?.Equals(otherMetadata.Title) ?? false)
&& (TitleUnicode?.Equals(otherMetadata.TitleUnicode) ?? false)
&& (Artist?.Equals(otherMetadata.Artist) ?? false)
&& (ArtistUnicode?.Equals(otherMetadata.ArtistUnicode) ?? false)
&& (AuthorString?.Equals(otherMetadata.AuthorString) ?? false)
&& (Source?.Equals(otherMetadata.Source) ?? false)
&& (Tags?.Equals(otherMetadata.Tags) ?? false)
&& PreviewTime.Equals(otherMetadata.PreviewTime)
&& (AudioFile?.Equals(otherMetadata.AudioFile) ?? false)
&& (BackgroundFile?.Equals(otherMetadata.BackgroundFile) ?? false);
}
} }
} }