h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-21 12:12:56 +08:00
Code Issues Releases Wiki Activity

Remove unnecessary manager parameter

Browse Source 
Confused why I added this in the first place..
This commit is contained in:
Dean Herbert 2021-11-25 18:36:01 +09:00
parent cc1b91e4bd
commit e2ebcf7a26
7 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Database/LegacyBeatmapExporter.cs
View File

@ -10,8 +10,8 @@ namespace osu.Game.Database
{ {
protected override string FileExtension => ".osz"; protected override string FileExtension => ".osz";
public LegacyBeatmapExporter(Storage storage, IModelManager<BeatmapSetInfo> manager) public LegacyBeatmapExporter(Storage storage)
: base(storage, manager) : base(storage)
{ {
} }
} }

6
osu.Game/Database/LegacyExporter.cs
View File

@ -19,16 +19,12 @@ namespace osu.Game.Database
/// </summary> /// </summary>
protected abstract string FileExtension { get; } protected abstract string FileExtension { get; }
protected readonly IModelManager<TModel> Manager;
protected readonly Storage UserFileStorage; protected readonly Storage UserFileStorage;
private readonly Storage exportStorage; private readonly Storage exportStorage;
protected LegacyExporter(Storage storage, IModelManager<TModel> manager) protected LegacyExporter(Storage storage)
{ {
Manager = manager;
exportStorage = storage.GetStorageForDirectory(@"exports"); exportStorage = storage.GetStorageForDirectory(@"exports");
UserFileStorage = storage.GetStorageForDirectory(@"files"); UserFileStorage = storage.GetStorageForDirectory(@"files");
} }

4
osu.Game/Database/LegacyScoreExporter.cs
View File

@ -13,8 +13,8 @@ namespace osu.Game.Database
{ {
protected override string FileExtension => ".osr"; protected override string FileExtension => ".osr";
public LegacyScoreExporter(Storage storage, IModelManager<ScoreInfo> manager) public LegacyScoreExporter(Storage storage)
: base(storage, manager) : base(storage)
{ {
} }

4
osu.Game/Database/LegacySkinExporter.cs
View File

@ -10,8 +10,8 @@ namespace osu.Game.Database
{ {
protected override string FileExtension => ".osk"; protected override string FileExtension => ".osk";
public LegacySkinExporter(Storage storage, IModelManager<SkinInfo> manager) public LegacySkinExporter(Storage storage)
: base(storage, manager) : base(storage)
{ {
} }
} }

2
osu.Game/Online/Leaderboards/LeaderboardScore.cs
View File

@ -400,7 +400,7 @@ namespace osu.Game.Online.Leaderboards
items.Add(new OsuMenuItem("Use these mods", MenuItemType.Highlighted, () => songSelect.Mods.Value = Score.Mods)); items.Add(new OsuMenuItem("Use these mods", MenuItemType.Highlighted, () => songSelect.Mods.Value = Score.Mods));
if (Score.Files.Count > 0) if (Score.Files.Count > 0)
items.Add(new OsuMenuItem("Export", MenuItemType.Standard, () => new LegacyScoreExporter(storage, scoreManager).Export(Score))); items.Add(new OsuMenuItem("Export", MenuItemType.Standard, () => new LegacyScoreExporter(storage).Export(Score)));
if (Score.ID != 0) if (Score.ID != 0)
items.Add(new OsuMenuItem("Delete", MenuItemType.Destructive, () => dialogOverlay?.Push(new LocalScoreDeleteDialog(Score)))); items.Add(new OsuMenuItem("Delete", MenuItemType.Destructive, () => dialogOverlay?.Push(new LocalScoreDeleteDialog(Score))));

2
osu.Game/Overlays/Settings/Sections/SkinSection.cs
View File

@ -188,7 +188,7 @@ namespace osu.Game.Overlays.Settings.Sections
{ {
try try
{ {
new LegacySkinExporter(storage, skins).Export(currentSkin.Value.SkinInfo); new LegacySkinExporter(storage).Export(currentSkin.Value.SkinInfo);
} }
catch (Exception e) catch (Exception e)
{ {

2
osu.Game/Screens/Edit/Editor.cs
View File

@ -758,7 +758,7 @@ namespace osu.Game.Screens.Edit
private void exportBeatmap() private void exportBeatmap()
{ {
Save(); Save();
new LegacyBeatmapExporter(storage, beatmapManager).Export(Beatmap.Value.BeatmapSetInfo); new LegacyBeatmapExporter(storage).Export(Beatmap.Value.BeatmapSetInfo);
} }
private void updateLastSavedHash() private void updateLastSavedHash()