From 54d1afb6557489fa38862a66151023226443d6da Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Fri, 7 Apr 2017 20:38:57 +0900 Subject: [PATCH 1/3] Fade in HitRenderer post entering animation. --- osu.Game/Screens/Play/Player.cs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/osu.Game/Screens/Play/Player.cs b/osu.Game/Screens/Play/Player.cs index ac03d0e2b8..47945c0a1b 100644 --- a/osu.Game/Screens/Play/Player.cs +++ b/osu.Game/Screens/Play/Player.cs @@ -292,6 +292,10 @@ namespace osu.Game.Screens.Play sourceClock.Start(); initializeSkipButton(); }); + + //keep in mind this is using the interpolatedSourceClock so won't be run as early as we may expect. + HitRenderer.Alpha = 0; + HitRenderer.FadeIn(750, EasingTypes.OutQuint); } protected override void OnSuspending(Screen next) From 0d4f45726582580b420d3bb4b0bdecf9faff693c Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Fri, 7 Apr 2017 20:46:35 +0900 Subject: [PATCH 2/3] Improve transitions when exiting play mode. --- osu.Game/Screens/Play/Player.cs | 33 ++++++++++++++++----------------- 1 file changed, 16 insertions(+), 17 deletions(-) diff --git a/osu.Game/Screens/Play/Player.cs b/osu.Game/Screens/Play/Player.cs index 47945c0a1b..36ab1ab946 100644 --- a/osu.Game/Screens/Play/Player.cs +++ b/osu.Game/Screens/Play/Player.cs @@ -308,25 +308,24 @@ namespace osu.Game.Screens.Play protected override bool OnExiting(Screen next) { - if (pauseOverlay == null) return false; - - if (HitRenderer.HasReplayLoaded) - return false; - - if (pauseOverlay.State != Visibility.Visible && !canPause) return true; - - if (!IsPaused && sourceClock.IsRunning) // For if the user presses escape quickly when entering the map + if (pauseOverlay != null && !HitRenderer.HasReplayLoaded) { - Pause(); - return true; - } - else - { - FadeOut(250); - Content.ScaleTo(0.7f, 750, EasingTypes.InQuint); - Background?.FadeTo(1f, 200); - return base.OnExiting(next); + //pause screen override logic. + if (pauseOverlay?.State == Visibility.Hidden && !canPause) return true; + + if (!IsPaused && sourceClock.IsRunning) // For if the user presses escape quickly when entering the map + { + Pause(); + return true; + } } + + HitRenderer?.FadeOut(60); + + FadeOut(250); + Content.ScaleTo(0.7f, 750, EasingTypes.InQuint); + Background?.FadeTo(1f, 200); + return base.OnExiting(next); } private Bindable mouseWheelDisabled; From 06a655af5d0187803a0048ddd28fa500f92fe8ba Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Fri, 7 Apr 2017 20:51:37 +0900 Subject: [PATCH 3/3] Move initial position of KeyCounter upwards. --- osu.Game/Modes/UI/StandardHudOverlay.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/osu.Game/Modes/UI/StandardHudOverlay.cs b/osu.Game/Modes/UI/StandardHudOverlay.cs index f77191adf7..f07e421f00 100644 --- a/osu.Game/Modes/UI/StandardHudOverlay.cs +++ b/osu.Game/Modes/UI/StandardHudOverlay.cs @@ -40,6 +40,7 @@ namespace osu.Game.Modes.UI Anchor = Anchor.BottomRight, Origin = Anchor.BottomRight, Margin = new MarginPadding(10), + Y = - TwoLayerButton.SIZE_RETRACTED.Y, }; protected override ScoreCounter CreateScoreCounter() => new ScoreCounter(6)