1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-13 18:07:25 +08:00

Fix some more missed CI inspections

This commit is contained in:
Bartłomiej Dach 2023-06-24 17:11:38 +02:00
parent df2dcf85b4
commit e273c223a8
No known key found for this signature in database
4 changed files with 7 additions and 6 deletions

View File

@ -44,7 +44,7 @@ namespace osu.Game.Tests.Visual.Online
selector.BeatmapSet = new APIBeatmapSet selector.BeatmapSet = new APIBeatmapSet
{ {
Beatmaps = selector.BeatmapSet.Beatmaps Beatmaps = selector.BeatmapSet!.Beatmaps
.Where(b => b.Ruleset.OnlineID != ruleset) .Where(b => b.Ruleset.OnlineID != ruleset)
.Concat(Enumerable.Range(0, count).Select(_ => new APIBeatmap { RulesetID = ruleset })) .Concat(Enumerable.Range(0, count).Select(_ => new APIBeatmap { RulesetID = ruleset }))
.ToArray(), .ToArray(),

View File

@ -10,9 +10,9 @@ namespace osu.Game.Online.Rooms
public class JoinRoomRequest : APIRequest public class JoinRoomRequest : APIRequest
{ {
public readonly Room Room; public readonly Room Room;
public readonly string Password; public readonly string? Password;
public JoinRoomRequest(Room room, string password) public JoinRoomRequest(Room room, string? password)
{ {
Room = room; Room = room;
Password = password; Password = password;

View File

@ -8,6 +8,7 @@ using System.Linq;
using System.Threading; using System.Threading;
using System.Threading.Tasks; using System.Threading.Tasks;
using JetBrains.Annotations; using JetBrains.Annotations;
using osu.Framework.Extensions.ObjectExtensions;
using osu.Game.Beatmaps; using osu.Game.Beatmaps;
using osu.Game.Rulesets.Mods; using osu.Game.Rulesets.Mods;
using osu.Game.Rulesets.Objects; using osu.Game.Rulesets.Objects;
@ -88,7 +89,7 @@ namespace osu.Game.Rulesets.Difficulty
).ConfigureAwait(false); ).ConfigureAwait(false);
// ScorePerformanceCache is not used to avoid caching multiple copies of essentially identical perfect performance attributes // ScorePerformanceCache is not used to avoid caching multiple copies of essentially identical perfect performance attributes
return difficulty == null ? null : ruleset.CreatePerformanceCalculator()?.Calculate(perfectPlay, difficulty.Value.Attributes); return difficulty == null ? null : ruleset.CreatePerformanceCalculator()?.Calculate(perfectPlay, difficulty.Value.Attributes.AsNonNull());
}, cancellationToken); }, cancellationToken);
} }

View File

@ -9,9 +9,9 @@ namespace osu.Game.Screens.OnlinePlay.Match
{ {
public partial class RoomBackgroundScreen : OnlinePlayBackgroundScreen public partial class RoomBackgroundScreen : OnlinePlayBackgroundScreen
{ {
public readonly Bindable<PlaylistItem> SelectedItem = new Bindable<PlaylistItem>(); public readonly Bindable<PlaylistItem?> SelectedItem = new Bindable<PlaylistItem?>();
public RoomBackgroundScreen(PlaylistItem initialPlaylistItem) public RoomBackgroundScreen(PlaylistItem? initialPlaylistItem)
{ {
PlaylistItem = initialPlaylistItem; PlaylistItem = initialPlaylistItem;
SelectedItem.BindValueChanged(item => PlaylistItem = item.NewValue); SelectedItem.BindValueChanged(item => PlaylistItem = item.NewValue);