From f13303c86c7542ab90211b03ff098d665c5c0b84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20M=C3=BCller?= Date: Sat, 17 Dec 2016 08:44:58 +0100 Subject: [PATCH] Do not lengthen slider curves according to the length prescribed in the .osu file for now. This fixes some issues with the map http://osu.ppy.sh/s/484689 . There is still one problem with an almost stationary slider in this map at around the 2/3 mark, but the rest seems to work fine now. --- osu.Game.Modes.Osu/Objects/SliderCurve.cs | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/osu.Game.Modes.Osu/Objects/SliderCurve.cs b/osu.Game.Modes.Osu/Objects/SliderCurve.cs index 961658112f..1c2ef3a604 100644 --- a/osu.Game.Modes.Osu/Objects/SliderCurve.cs +++ b/osu.Game.Modes.Osu/Objects/SliderCurve.cs @@ -101,9 +101,11 @@ namespace osu.Game.Modes.Osu.Objects cumulativeLength.Add(l); } + //TODO: Figure out if the following code is needed in some cases. Judging by the map + // "Transform" http://osu.ppy.sh/s/484689 it seems like we should _not_ be doing this. // Lengthen slider curves that are too short compared to what's // in the .osu file. - if (l < Length && calculatedPath.Count > 1) + /*if (l < Length && calculatedPath.Count > 1) { Vector2 diff = calculatedPath[calculatedPath.Count - 1] - calculatedPath[calculatedPath.Count - 2]; double d = diff.Length; @@ -113,7 +115,7 @@ namespace osu.Game.Modes.Osu.Objects calculatedPath[calculatedPath.Count - 1] += diff * (float)((Length - l) / d); cumulativeLength[calculatedPath.Count - 1] = Length; - } + }*/ } public void Calculate()