From e207a4288925a22d2dbfc6a514c0e5e6866df2bc Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Thu, 2 Apr 2026 19:49:45 +0900 Subject: [PATCH] Fix osu!mania editor not zooming playfield to match timeline (#37176) - Fixes CI failures due to completely wrong test (sorry) - Fixes #37167 (oops) --- osu.Game.Rulesets.Mania/Edit/DrawableManiaEditorRuleset.cs | 2 +- osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/osu.Game.Rulesets.Mania/Edit/DrawableManiaEditorRuleset.cs b/osu.Game.Rulesets.Mania/Edit/DrawableManiaEditorRuleset.cs index 49ee83dc17..181bc7341c 100644 --- a/osu.Game.Rulesets.Mania/Edit/DrawableManiaEditorRuleset.cs +++ b/osu.Game.Rulesets.Mania/Edit/DrawableManiaEditorRuleset.cs @@ -44,7 +44,7 @@ namespace osu.Game.Rulesets.Mania.Edit protected override void Update() { - TimeRange.Value = TimelineTimeRange == null || ShowSpeedChanges.Value ? ComputeScrollTime(Config.Get(ManiaRulesetSetting.ScrollSpeed)) : TimelineTimeRange.Value; + TargetTimeRange = TimelineTimeRange == null || ShowSpeedChanges.Value ? ComputeScrollTime(Config.Get(ManiaRulesetSetting.ScrollSpeed)) : TimelineTimeRange.Value; base.Update(); } } diff --git a/osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs b/osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs index f24767bd54..68aaba6c68 100644 --- a/osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs +++ b/osu.Game.Tests/Visual/Navigation/TestSceneScreenNavigation.cs @@ -472,7 +472,7 @@ namespace osu.Game.Tests.Visual.Navigation void checkScrollSpeed(double configValue, double gameplayValue) { AddUntilStep($"config value is {configValue}", () => getConfigManager().Get(ManiaRulesetSetting.ScrollSpeed), () => Is.EqualTo(configValue)); - AddUntilStep($"gameplay value is {gameplayValue}", () => this.ChildrenOfType().Single().ScrollingInfo.TimeRange.Value, + AddUntilStep($"gameplay value is {gameplayValue}", () => this.ChildrenOfType().Single().TargetTimeRange, () => Is.EqualTo(DrawableManiaRuleset.ComputeScrollTime(gameplayValue))); }