h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-12 19:42:55 +08:00
Code Issues Releases Wiki Activity

Fix potential exception during removal

Browse Source
This commit is contained in:
smoogipoo 2019-12-18 12:03:15 +09:00
parent bcc19e29f2
commit df8f8ffd0d
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
osu.Game/Rulesets/UI/HitObjectContainer.cs
View File

@ -33,13 +33,14 @@ namespace osu.Game.Rulesets.UI
public virtual bool Remove(DrawableHitObject hitObject) public virtual bool Remove(DrawableHitObject hitObject)
{ {
bool result = RemoveInternal(hitObject); if (!RemoveInternal(hitObject))
return false;
// Removed last for the comparer to remain ordered during RemoveInternal // Removed last for the comparer to remain ordered during RemoveInternal
startTimeMap[hitObject].bindable.UnbindAll(); startTimeMap[hitObject].bindable.UnbindAll();
startTimeMap.Remove(hitObject); startTimeMap.Remove(hitObject);
return result; return true;
} }
private void onStartTimeChanged(DrawableHitObject hitObject) private void onStartTimeChanged(DrawableHitObject hitObject)