From df662afbd56a9f2e7042eb4f1900ac6a1647c5f4 Mon Sep 17 00:00:00 2001
From: Dean Herbert <pe@ppy.sh>
Date: Mon, 29 May 2023 20:00:42 +0900
Subject: [PATCH] Pass `ScoreProcessorStatistics` to `FrameHeader`, rather than
 the full processor

---
 osu.Game/Online/Spectator/FrameDataBundle.cs | 2 +-
 osu.Game/Online/Spectator/FrameHeader.cs     | 7 +++----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/osu.Game/Online/Spectator/FrameDataBundle.cs b/osu.Game/Online/Spectator/FrameDataBundle.cs
index b936847434..d58ddd5310 100644
--- a/osu.Game/Online/Spectator/FrameDataBundle.cs
+++ b/osu.Game/Online/Spectator/FrameDataBundle.cs
@@ -24,7 +24,7 @@ namespace osu.Game.Online.Spectator
         public FrameDataBundle(ScoreInfo score, ScoreProcessor scoreProcessor, IList<LegacyReplayFrame> frames)
         {
             Frames = frames;
-            Header = new FrameHeader(score, scoreProcessor);
+            Header = new FrameHeader(score, scoreProcessor.GetScoreProcessorStatistics());
         }
 
         [JsonConstructor]
diff --git a/osu.Game/Online/Spectator/FrameHeader.cs b/osu.Game/Online/Spectator/FrameHeader.cs
index 4d1c2c2cff..45f920e65b 100644
--- a/osu.Game/Online/Spectator/FrameHeader.cs
+++ b/osu.Game/Online/Spectator/FrameHeader.cs
@@ -60,18 +60,17 @@ namespace osu.Game.Online.Spectator
         /// Construct header summary information from a point-in-time reference to a score which is actively being played.
         /// </summary>
         /// <param name="score">The score for reference.</param>
-        /// <param name="scoreProcessor">The score processor for reference.</param>
-        public FrameHeader(ScoreInfo score, ScoreProcessor scoreProcessor)
+        /// <param name="statistics">The score processor statistics for the current point in time.</param>
+        public FrameHeader(ScoreInfo score, ScoreProcessorStatistics statistics)
         {
             TotalScore = score.TotalScore;
             Accuracy = score.Accuracy;
             Combo = score.Combo;
             MaxCombo = score.MaxCombo;
-
             // copy for safety
             Statistics = new Dictionary<HitResult, int>(score.Statistics);
 
-            ScoreProcessorStatistics = scoreProcessor.GetScoreProcessorStatistics();
+            ScoreProcessorStatistics = statistics;
         }
 
         [JsonConstructor]