From de57daeb3c65bd0c8be1de69e7a4cd4b3f78594b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= Date: Tue, 10 Jun 2025 10:48:26 +0200 Subject: [PATCH] Fix results screen not showing local scores on results screen for some beatmap statuses Closes https://github.com/ppy/osu/issues/33609. Case of leftover code that should have been removed. This condition is still active in the online leaderboards path via https://github.com/ppy/osu/blob/4dcc928c7e46e020c62f4d60e7b859ba18c9142f/osu.Game/Online/Leaderboards/LeaderboardManager.cs#L91-L95 Not sure trying to add test coverage is a productive use of time? Will do on request though. --- osu.Game/Screens/Ranking/SoloResultsScreen.cs | 4 ---- 1 file changed, 4 deletions(-) diff --git a/osu.Game/Screens/Ranking/SoloResultsScreen.cs b/osu.Game/Screens/Ranking/SoloResultsScreen.cs index d11e7db178..7d57bc80aa 100644 --- a/osu.Game/Screens/Ranking/SoloResultsScreen.cs +++ b/osu.Game/Screens/Ranking/SoloResultsScreen.cs @@ -8,7 +8,6 @@ using System.Threading.Tasks; using osu.Framework.Allocation; using osu.Framework.Bindables; using osu.Framework.Logging; -using osu.Game.Beatmaps; using osu.Game.Extensions; using osu.Game.Online.API; using osu.Game.Online.Leaderboards; @@ -42,9 +41,6 @@ namespace osu.Game.Screens.Ranking { Debug.Assert(Score != null); - if (Score.BeatmapInfo!.OnlineID <= 0 || Score.BeatmapInfo.Status <= BeatmapOnlineStatus.Pending) - return []; - var criteria = new LeaderboardCriteria( Score.BeatmapInfo!, Score.Ruleset,