h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2025-01-07 18:33:04 +08:00
Code Issues Releases Wiki Activity

Remove unnecessary methods and event

Browse Source
This commit is contained in:
Dean Herbert 2020-12-15 15:26:20 +09:00
parent 8362ad37e3
commit dd5572b20a
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Screens/Play/InGameScoreContainer.cs
View File

@ -19,12 +19,6 @@ namespace osu.Game.Screens.Play
{ {
public class InGameScoreContainer : FillFlowContainer<InGameScoreItem> public class InGameScoreContainer : FillFlowContainer<InGameScoreItem>
{ {
/// <summary>
/// Called once an item's score has changed.
/// Useful for doing calculations on what score to show or hide next. (scrolling system)
/// </summary>
public Action OnScoreChange;
/// <summary> /// <summary>
/// Whether to declare a new position for un-positioned players. /// Whether to declare a new position for un-positioned players.
/// Must be disabled for online leaderboards with top 50 scores only. /// Must be disabled for online leaderboards with top 50 scores only.
@ -101,9 +95,16 @@ namespace osu.Game.Screens.Play
private void updateScores() private void updateScores()
{ {
reorderPositions(); var orderedByScore = this.OrderByDescending(i => i.TotalScore).ToList();
var orderedPositions = this.Select(i => this.Any(item => item.InitialPosition.HasValue) ? i.InitialPosition : i.ScorePosition).OrderByDescending(p => p.HasValue).ThenBy(p => p).ToList();
OnScoreChange?.Invoke(); for (int i = 0; i < Count; i++)
{
int newPosition = orderedPositions[i] ?? maxPosition + 1;
SetLayoutPosition(orderedByScore[i], newPosition);
orderedByScore[i].ScorePosition = DeclareNewPosition ? newPosition : orderedPositions[i];
}
} }
} }