diff --git a/osu.Game/OsuGame.cs b/osu.Game/OsuGame.cs
index 8e32b2e6a7..3cfa2cc755 100644
--- a/osu.Game/OsuGame.cs
+++ b/osu.Game/OsuGame.cs
@@ -1058,7 +1058,7 @@ namespace osu.Game
OverlayActivationMode.BindTo(newOsuScreen.OverlayActivationMode);
API.Activity.BindTo(newOsuScreen.Activity);
- MusicController.AllowRateAdjustments = newOsuScreen.AllowRateAdjustments;
+ MusicController.AllowTrackAdjustments = newOsuScreen.AllowTrackAdjustments;
if (newOsuScreen.HideOverlaysOnEnter)
CloseAllOverlays();
diff --git a/osu.Game/Overlays/MusicController.cs b/osu.Game/Overlays/MusicController.cs
index 3978d2aa6e..8fd50c3df2 100644
--- a/osu.Game/Overlays/MusicController.cs
+++ b/osu.Game/Overlays/MusicController.cs
@@ -400,40 +400,38 @@ namespace osu.Game.Overlays
NextTrack();
}
- private bool allowRateAdjustments;
+ private bool allowTrackAdjustments;
///
- /// Whether mod rate adjustments are allowed to be applied.
+ /// Whether mod track adjustments are allowed to be applied.
///
- public bool AllowRateAdjustments
+ public bool AllowTrackAdjustments
{
- get => allowRateAdjustments;
+ get => allowTrackAdjustments;
set
{
- if (allowRateAdjustments == value)
+ if (allowTrackAdjustments == value)
return;
- allowRateAdjustments = value;
+ allowTrackAdjustments = value;
ResetTrackAdjustments();
}
}
///
- /// Resets the track adjustments currently applied on and applies the mod adjustments if is true.
+ /// Resets the adjustments currently applied on and applies the mod adjustments if is true.
///
///
/// Does not reset any adjustments applied directly to the beatmap track.
///
public void ResetTrackAdjustments()
{
- CurrentTrack.ResetSpeedAdjustments();
-
- // Adjustments other than speed should also be reset
- // e.g. ModMuted may apply volume adjustments
CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Balance);
+ CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Frequency);
+ CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Tempo);
CurrentTrack.RemoveAllAdjustments(AdjustableProperty.Volume);
- if (allowRateAdjustments)
+ if (allowTrackAdjustments)
{
foreach (var mod in mods.Value.OfType())
mod.ApplyToTrack(CurrentTrack);
diff --git a/osu.Game/Screens/Edit/Editor.cs b/osu.Game/Screens/Edit/Editor.cs
index b6dc97a7f6..61a3b0f5cc 100644
--- a/osu.Game/Screens/Edit/Editor.cs
+++ b/osu.Game/Screens/Edit/Editor.cs
@@ -55,7 +55,7 @@ namespace osu.Game.Screens.Edit
public override bool DisallowExternalBeatmapRulesetChanges => true;
- public override bool AllowRateAdjustments => false;
+ public override bool AllowTrackAdjustments => false;
protected bool HasUnsavedChanges => lastSavedHash != changeHandler.CurrentStateHash;
diff --git a/osu.Game/Screens/IOsuScreen.cs b/osu.Game/Screens/IOsuScreen.cs
index 0434135547..17384c161c 100644
--- a/osu.Game/Screens/IOsuScreen.cs
+++ b/osu.Game/Screens/IOsuScreen.cs
@@ -59,9 +59,9 @@ namespace osu.Game.Screens
Bindable Ruleset { get; }
///
- /// Whether mod rate adjustments are allowed to be applied.
+ /// Whether mod track adjustments are allowed to be applied.
///
- bool AllowRateAdjustments { get; }
+ bool AllowTrackAdjustments { get; }
///
/// Invoked when the back button has been pressed to close any overlays before exiting this .
diff --git a/osu.Game/Screens/Menu/MainMenu.cs b/osu.Game/Screens/Menu/MainMenu.cs
index e53b46f391..1d0182a945 100644
--- a/osu.Game/Screens/Menu/MainMenu.cs
+++ b/osu.Game/Screens/Menu/MainMenu.cs
@@ -36,7 +36,7 @@ namespace osu.Game.Screens.Menu
public override bool AllowExternalScreenChange => true;
- public override bool AllowRateAdjustments => false;
+ public override bool AllowTrackAdjustments => false;
private Screen songSelect;
diff --git a/osu.Game/Screens/OnlinePlay/Multiplayer/Spectate/MultiSpectatorScreen.cs b/osu.Game/Screens/OnlinePlay/Multiplayer/Spectate/MultiSpectatorScreen.cs
index 2a2759e0dd..56ed7a9564 100644
--- a/osu.Game/Screens/OnlinePlay/Multiplayer/Spectate/MultiSpectatorScreen.cs
+++ b/osu.Game/Screens/OnlinePlay/Multiplayer/Spectate/MultiSpectatorScreen.cs
@@ -24,7 +24,7 @@ namespace osu.Game.Screens.OnlinePlay.Multiplayer.Spectate
public override bool DisallowExternalBeatmapRulesetChanges => true;
// We are managing our own adjustments. For now, this happens inside the Player instances themselves.
- public override bool AllowRateAdjustments => false;
+ public override bool AllowTrackAdjustments => false;
///
/// Whether all spectating players have finished loading.
diff --git a/osu.Game/Screens/OsuScreen.cs b/osu.Game/Screens/OsuScreen.cs
index c3b2612e79..e3fe14a585 100644
--- a/osu.Game/Screens/OsuScreen.cs
+++ b/osu.Game/Screens/OsuScreen.cs
@@ -81,7 +81,7 @@ namespace osu.Game.Screens
public virtual float BackgroundParallaxAmount => 1;
- public virtual bool AllowRateAdjustments => true;
+ public virtual bool AllowTrackAdjustments => true;
public Bindable Beatmap { get; private set; }
diff --git a/osu.Game/Screens/Play/Player.cs b/osu.Game/Screens/Play/Player.cs
index 0e4d38660b..d76d44767a 100644
--- a/osu.Game/Screens/Play/Player.cs
+++ b/osu.Game/Screens/Play/Player.cs
@@ -56,7 +56,7 @@ namespace osu.Game.Screens.Play
protected override OverlayActivation InitialOverlayActivationMode => OverlayActivation.UserTriggered;
// We are managing our own adjustments (see OnEntering/OnExiting).
- public override bool AllowRateAdjustments => false;
+ public override bool AllowTrackAdjustments => false;
private readonly IBindable gameActive = new Bindable(true);
diff --git a/osu.Game/Screens/StartupScreen.cs b/osu.Game/Screens/StartupScreen.cs
index e5e134fd39..15f75d7cff 100644
--- a/osu.Game/Screens/StartupScreen.cs
+++ b/osu.Game/Screens/StartupScreen.cs
@@ -16,7 +16,7 @@ namespace osu.Game.Screens
public override bool CursorVisible => false;
- public override bool AllowRateAdjustments => false;
+ public override bool AllowTrackAdjustments => false;
protected override OverlayActivation InitialOverlayActivationMode => OverlayActivation.Disabled;
}