From 275d075acda463cafa23bb6ac97145d3a1262597 Mon Sep 17 00:00:00 2001 From: mcendu Date: Wed, 4 Mar 2020 10:53:30 +0800 Subject: [PATCH 1/4] comment out log locations in bug report template --- .github/ISSUE_TEMPLATE/01-bug-issues.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/01-bug-issues.md b/.github/ISSUE_TEMPLATE/01-bug-issues.md index 0aff276d03..0b80ce44dd 100644 --- a/.github/ISSUE_TEMPLATE/01-bug-issues.md +++ b/.github/ISSUE_TEMPLATE/01-bug-issues.md @@ -9,6 +9,8 @@ about: Issues regarding encountered bugs. **osu!lazer version:** **Logs:** + From fc0821f1942d141854b9ff6823d0762256068a37 Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Wed, 4 Mar 2020 12:37:42 +0900 Subject: [PATCH 2/4] Fix nullref when deleting teams in the ladder screen --- osu.Game.Tournament/Screens/Ladder/LadderScreen.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game.Tournament/Screens/Ladder/LadderScreen.cs b/osu.Game.Tournament/Screens/Ladder/LadderScreen.cs index 8ea366e1b4..86d1081241 100644 --- a/osu.Game.Tournament/Screens/Ladder/LadderScreen.cs +++ b/osu.Game.Tournament/Screens/Ladder/LadderScreen.cs @@ -80,7 +80,7 @@ namespace osu.Game.Tournament.Screens.Ladder break; case NotifyCollectionChangedAction.Remove: - foreach (var p in args.NewItems.Cast()) + foreach (var p in args.OldItems.Cast()) { foreach (var d in MatchesContainer.Where(d => d.Match == p)) d.Expire(); From e9b0770f6418e904686f0744b82475d9db41f026 Mon Sep 17 00:00:00 2001 From: Dean Herbert Date: Wed, 4 Mar 2020 12:44:44 +0900 Subject: [PATCH 3/4] Apply suggestions from code review Co-Authored-By: Dan Balasescu --- osu.Game/Graphics/OsuFont.cs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/osu.Game/Graphics/OsuFont.cs b/osu.Game/Graphics/OsuFont.cs index 4dd7bcdf31..12e36871f0 100644 --- a/osu.Game/Graphics/OsuFont.cs +++ b/osu.Game/Graphics/OsuFont.cs @@ -109,27 +109,27 @@ namespace osu.Game.Graphics Light = 300, /// - /// equivalent to weight 400 + /// Equivalent to weight 400. /// Regular = 400, /// - /// equivalent to weight 500 + /// Equivalent to weight 500. /// Medium = 500, /// - /// equivalent to weight 600 + /// Equivalent to weight 600. /// SemiBold = 600, /// - /// equivalent to weight 700 + /// Equivalent to weight 700. /// Bold = 700, /// - /// equivalent to weight 900 + /// Equivalent to weight 900. /// Black = 900 } From aa17a64a0e383e7a6f7b011439a84f2cf1bef191 Mon Sep 17 00:00:00 2001 From: Dan Balasescu Date: Wed, 4 Mar 2020 12:47:01 +0900 Subject: [PATCH 4/4] Apply missed xmldoc suggestion --- osu.Game/Graphics/OsuFont.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osu.Game/Graphics/OsuFont.cs b/osu.Game/Graphics/OsuFont.cs index 12e36871f0..841936d2c5 100644 --- a/osu.Game/Graphics/OsuFont.cs +++ b/osu.Game/Graphics/OsuFont.cs @@ -104,7 +104,7 @@ namespace osu.Game.Graphics public enum FontWeight { /// - /// equivalent to weight 300 + /// Equivalent to weight 300. /// Light = 300,