diff --git a/osu.Game/Overlays/Chat/Tabs/PrivateChannelTabItem.cs b/osu.Game/Overlays/Chat/Tabs/PrivateChannelTabItem.cs
index 00f46b0035..7c82420e08 100644
--- a/osu.Game/Overlays/Chat/Tabs/PrivateChannelTabItem.cs
+++ b/osu.Game/Overlays/Chat/Tabs/PrivateChannelTabItem.cs
@@ -51,7 +51,7 @@ namespace osu.Game.Overlays.Chat.Tabs
Child = new DelayedLoadWrapper(avatar = new ClickableAvatar(value.Users.First())
{
RelativeSizeAxes = Axes.Both,
- OpenOnClick = { Value = false },
+ OpenOnClick = false,
})
{
RelativeSizeAxes = Axes.Both,
diff --git a/osu.Game/Overlays/Profile/Header/TopHeaderContainer.cs b/osu.Game/Overlays/Profile/Header/TopHeaderContainer.cs
index e0642d650c..419ae96738 100644
--- a/osu.Game/Overlays/Profile/Header/TopHeaderContainer.cs
+++ b/osu.Game/Overlays/Profile/Header/TopHeaderContainer.cs
@@ -58,12 +58,11 @@ namespace osu.Game.Overlays.Profile.Header
Origin = Anchor.CentreLeft,
Children = new Drawable[]
{
- avatar = new UpdateableAvatar
+ avatar = new UpdateableAvatar(openOnClick: false)
{
Size = new Vector2(avatar_size),
Masking = true,
CornerRadius = avatar_size * 0.25f,
- OpenOnClick = { Value = false },
ShowGuestOnNull = false,
},
new Container
diff --git a/osu.Game/Overlays/Toolbar/ToolbarUserButton.cs b/osu.Game/Overlays/Toolbar/ToolbarUserButton.cs
index db4e491d9a..165c095514 100644
--- a/osu.Game/Overlays/Toolbar/ToolbarUserButton.cs
+++ b/osu.Game/Overlays/Toolbar/ToolbarUserButton.cs
@@ -32,14 +32,13 @@ namespace osu.Game.Overlays.Toolbar
Add(new OpaqueBackground { Depth = 1 });
- Flow.Add(avatar = new UpdateableAvatar
+ Flow.Add(avatar = new UpdateableAvatar(openOnClick: false)
{
Masking = true,
Size = new Vector2(32),
Anchor = Anchor.CentreLeft,
Origin = Anchor.CentreLeft,
CornerRadius = 4,
- OpenOnClick = { Value = false },
EdgeEffect = new EdgeEffectParameters
{
Type = EdgeEffectType.Shadow,
diff --git a/osu.Game/Users/Drawables/ClickableAvatar.cs b/osu.Game/Users/Drawables/ClickableAvatar.cs
index 0fca9c7c9b..c3bf740108 100644
--- a/osu.Game/Users/Drawables/ClickableAvatar.cs
+++ b/osu.Game/Users/Drawables/ClickableAvatar.cs
@@ -2,7 +2,6 @@
// See the LICENCE file in the repository root for full licence text.
using osu.Framework.Allocation;
-using osu.Framework.Bindables;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Textures;
@@ -13,16 +12,32 @@ namespace osu.Game.Users.Drawables
{
public class ClickableAvatar : Container
{
+ private const string default_tooltip_text = "view profile";
+
///
/// Whether to open the user's profile when clicked.
///
- public readonly BindableBool OpenOnClick = new BindableBool(true);
+ public bool OpenOnClick
+ {
+ set => clickableArea.Enabled.Value = value;
+ }
+
+ ///
+ /// By default, the tooltip will show "view profile" as avatars are usually displayed next to a username.
+ /// Setting this to true exposes the username via tooltip for special cases where this is not true.
+ ///
+ public bool ShowUsernameTooltip
+ {
+ set => clickableArea.TooltipText = value ? (user?.Username ?? string.Empty) : default_tooltip_text;
+ }
private readonly User user;
[Resolved(CanBeNull = true)]
private OsuGame game { get; set; }
+ private readonly ClickableArea clickableArea;
+
///
/// A clickable avatar for the specified user, with UI sounds included.
/// If is true, clicking will open the user's profile.
@@ -31,35 +46,35 @@ namespace osu.Game.Users.Drawables
public ClickableAvatar(User user = null)
{
this.user = user;
- }
- [BackgroundDependencyLoader]
- private void load(LargeTextureStore textures)
- {
- ClickableArea clickableArea;
Add(clickableArea = new ClickableArea
{
RelativeSizeAxes = Axes.Both,
Action = openProfile
});
+ }
+ [BackgroundDependencyLoader]
+ private void load(LargeTextureStore textures)
+ {
LoadComponentAsync(new DrawableAvatar(user), clickableArea.Add);
-
- clickableArea.Enabled.BindTo(OpenOnClick);
}
private void openProfile()
{
- if (!OpenOnClick.Value)
- return;
-
if (user?.Id > 1)
game?.ShowUser(user.Id);
}
private class ClickableArea : OsuClickableContainer
{
- public override string TooltipText => Enabled.Value ? @"view profile" : null;
+ private string tooltip = default_tooltip_text;
+
+ public override string TooltipText
+ {
+ get => Enabled.Value ? tooltip : null;
+ set => tooltip = value;
+ }
protected override bool OnClick(ClickEvent e)
{
diff --git a/osu.Game/Users/Drawables/UpdateableAvatar.cs b/osu.Game/Users/Drawables/UpdateableAvatar.cs
index 927e48cb56..df724404e9 100644
--- a/osu.Game/Users/Drawables/UpdateableAvatar.cs
+++ b/osu.Game/Users/Drawables/UpdateableAvatar.cs
@@ -1,7 +1,6 @@
// Copyright (c) ppy Pty Ltd . Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.
-using osu.Framework.Bindables;
using osu.Framework.Graphics;
using osu.Framework.Graphics.Containers;
using osu.Framework.Graphics.Effects;
@@ -45,33 +44,38 @@ namespace osu.Game.Users.Drawables
protected override double LoadDelay => 200;
- ///
- /// Whether to show a default guest representation on null user (as opposed to nothing).
- ///
- public bool ShowGuestOnNull = true;
+ private readonly bool openOnClick;
+ private readonly bool showUsernameTooltip;
+ private readonly bool showGuestOnNull;
///
- /// Whether to open the user's profile when clicked.
+ /// Construct a new UpdateableAvatar.
///
- public readonly BindableBool OpenOnClick = new BindableBool(true);
-
- public UpdateableAvatar(User user = null)
+ /// The initial user to display.
+ /// Whether to open the user's profile when clicked.
+ /// Whether to show the username rather than "view profile" on the tooltip.
+ /// Whether to show a default guest representation on null user (as opposed to nothing).
+ public UpdateableAvatar(User user = null, bool openOnClick = true, bool showUsernameTooltip = false, bool showGuestOnNull = true)
{
+ this.openOnClick = openOnClick;
+ this.showUsernameTooltip = showUsernameTooltip;
+ this.showGuestOnNull = showGuestOnNull;
+
User = user;
}
protected override Drawable CreateDrawable(User user)
{
- if (user == null && !ShowGuestOnNull)
+ if (user == null && !showGuestOnNull)
return null;
var avatar = new ClickableAvatar(user)
{
+ OpenOnClick = openOnClick,
+ ShowUsernameTooltip = showUsernameTooltip,
RelativeSizeAxes = Axes.Both,
};
- avatar.OpenOnClick.BindTo(OpenOnClick);
-
return avatar;
}
}
diff --git a/osu.Game/Users/ExtendedUserPanel.cs b/osu.Game/Users/ExtendedUserPanel.cs
index 2604815751..24317e6069 100644
--- a/osu.Game/Users/ExtendedUserPanel.cs
+++ b/osu.Game/Users/ExtendedUserPanel.cs
@@ -48,11 +48,7 @@ namespace osu.Game.Users
statusIcon.FinishTransforms();
}
- protected UpdateableAvatar CreateAvatar() => new UpdateableAvatar
- {
- User = User,
- OpenOnClick = { Value = false }
- };
+ protected UpdateableAvatar CreateAvatar() => new UpdateableAvatar(User, false);
protected UpdateableFlag CreateFlag() => new UpdateableFlag(User.Country)
{