From d88bfa2080f7c1dcf852dfa278fd7f068dd3d8dc Mon Sep 17 00:00:00 2001
From: smoogipoo <smoogipoo@smgi.me>
Date: Thu, 28 May 2020 20:07:51 +0900
Subject: [PATCH] Cache ruleset + fix possible nullrefs

---
 osu.Game/Online/API/RoomScore.cs | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/osu.Game/Online/API/RoomScore.cs b/osu.Game/Online/API/RoomScore.cs
index 00907eaa38..a1b08fe40e 100644
--- a/osu.Game/Online/API/RoomScore.cs
+++ b/osu.Game/Online/API/RoomScore.cs
@@ -7,6 +7,7 @@ using System.Linq;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Converters;
 using osu.Game.Online.Multiplayer;
+using osu.Game.Rulesets.Mods;
 using osu.Game.Rulesets.Scoring;
 using osu.Game.Scoring;
 using osu.Game.Users;
@@ -48,6 +49,8 @@ namespace osu.Game.Online.API
 
         public ScoreInfo CreateScoreInfo(PlaylistItem playlistItem)
         {
+            var rulesetInstance = playlistItem.Ruleset.Value.CreateInstance();
+
             var scoreInfo = new ScoreInfo
             {
                 OnlineScoreID = ID,
@@ -62,7 +65,7 @@ namespace osu.Game.Online.API
                 Date = EndedAt,
                 Hash = string.Empty, // todo: temporary?
                 Rank = Rank,
-                Mods = Mods.Select(m => m.ToMod(playlistItem.Ruleset.Value.CreateInstance())).ToArray()
+                Mods = Mods?.Select(m => m.ToMod(rulesetInstance)).ToArray() ?? Array.Empty<Mod>()
             };
 
             return scoreInfo;