From d87a65f19e4b5edcdc21e9e71be75b70fcce49dc Mon Sep 17 00:00:00 2001 From: smoogipooo Date: Thu, 6 Apr 2017 13:44:43 +0900 Subject: [PATCH] Fix accuracy calculations. --- osu.Game.Modes.Taiko/Judgements/TaikoJudgement.cs | 5 +++-- osu.Game.Modes.Taiko/Scoring/TaikoScoreProcessor.cs | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/osu.Game.Modes.Taiko/Judgements/TaikoJudgement.cs b/osu.Game.Modes.Taiko/Judgements/TaikoJudgement.cs index c2c4093b1b..7676ef8c29 100644 --- a/osu.Game.Modes.Taiko/Judgements/TaikoJudgement.cs +++ b/osu.Game.Modes.Taiko/Judgements/TaikoJudgement.cs @@ -3,6 +3,7 @@ using osu.Game.Modes.Judgements; using osu.Framework.Extensions; +using osu.Game.Modes.Objects.Drawables; namespace osu.Game.Modes.Taiko.Judgements { @@ -21,12 +22,12 @@ namespace osu.Game.Modes.Taiko.Judgements /// /// The result value for the combo portion of the score. /// - public int ResultValueForScore => NumericResultForScore(TaikoResult); + public int ResultValueForScore => Result == HitResult.Miss ? 0 : NumericResultForScore(TaikoResult); /// /// The result value for the accuracy portion of the score. /// - public int ResultValueForAccuracy => NumericResultForAccuracy(TaikoResult); + public int ResultValueForAccuracy => Result == HitResult.Miss ? 0 : NumericResultForAccuracy(TaikoResult); /// /// The maximum result value for the combo portion of the score. diff --git a/osu.Game.Modes.Taiko/Scoring/TaikoScoreProcessor.cs b/osu.Game.Modes.Taiko/Scoring/TaikoScoreProcessor.cs index fa7e18cadb..d215793abe 100644 --- a/osu.Game.Modes.Taiko/Scoring/TaikoScoreProcessor.cs +++ b/osu.Game.Modes.Taiko/Scoring/TaikoScoreProcessor.cs @@ -261,7 +261,7 @@ namespace osu.Game.Modes.Taiko.Scoring foreach (var j in Judgements) { scoreForAccuracy += j.ResultValueForAccuracy; - maxScoreForAccuracy = j.MaxResultValueForAccuracy; + maxScoreForAccuracy += j.MaxResultValueForAccuracy; } Accuracy.Value = (double)scoreForAccuracy / maxScoreForAccuracy;